• Jakob Gruber's avatar
    Revert "[builtins] Remove Builtins::Name() accessors" · 17a26c0b
    Jakob Gruber authored
    This reverts commit 2f79e035.
    
    Reason for revert: Conflicts with successor CL.
    
    Original change's description:
    > [builtins] Remove Builtins::Name() accessors
    > 
    > Instead of auto-generating the Name() convenience accessor, use a macro to
    > avoid wasting code space.
    > 
    >   BUILTIN_CODE(isolate, Name)
    > 
    > expands to
    > 
    >   isolate->builtins()->builtin_handle(Builtins::kName);
    > 
    > This reduces the size of libv8.so by 134,752 bytes on a x64 release build.
    > 
    > Bug: v8:6624
    > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    > Change-Id: Idff7ee5c45e344e73412c0f47e92553c7c7ff75f
    > Reviewed-on: https://chromium-review.googlesource.com/593607
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47010}
    
    TBR=yangguo@chromium.org,ahaas@chromium.org,jgruber@chromium.org,bmeurer@chromium.org
    
    Change-Id: Ia9ef5c755b26c3f4e143d87a7c51033614ea435e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6624
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/594048Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47012}
    17a26c0b
test-helpers.cc 2.04 KB