• Seth Brenith's avatar
    [torque] Use @generateCppClass in some simple cases · 14274bb1
    Seth Brenith authored
    This change is mostly mechanical, but it's worth mentioning a few
    slightly interesting cases:
    - A couple of field definitions didn't match the signedness of their
      corresponding accessors.
    - The generated accessors for Smi data use Smi values directly, but
      usually we want C++ accessors to use ints instead. I added a macro
      that hides the generated Smi accessors and exposes int accessors,
      but we might consider generating int accessors directly.
    - The data held in some fields is described in comments next to the
      accessor definition for those fields. With automatically generated
      accessors, those comments need a new home. In this change I put them
      in the Torque object definition, but I'm open to other suggestions.
    - gen-postmortem-metadata couldn't find updated class definitions after
      they got split across multiple lines, so I changed its matching
      logic. (Ideally debug-support.cc should be a Torque compiler output
      rather than something that involves parsing C++ with regexes, but
      this makes it correctly report subclass relationships for now.)
    - The end offsets generated by Torque were off by one from the values
      that would be generated by DEFINE_FIELD_OFFSET_CONSTANTS.
    
    Change-Id: I3df4fcd27997b46c41ca879065b9d97f6c939f07
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692192Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#62719}
    14274bb1
base.tq 104 KB