• Matheus Marchini's avatar
    Reland "[error] extend error stack w/ function parameters" · 3724a125
    Matheus Marchini authored
    This is a reland of 97628eee.
    
    Original change's description:
    > [error] extend error stack w/ function parameters
    >
    > Extend FrameArray to hold weak references to parameters forfunctions in
    > the call stack. The goal here is to provide more metadata for postmortem
    > tools (such as llnode), especially in cases of rethrowing (this will be
    > particularly useful when using postmortem with promises on Node.js).
    >
    > Besides postmortem, these changes allow us to print a more detailed
    > stack trace for errors with parameters types (or even values), which can
    > be useful since JavaScript functions can receive any number of
    > parameters of any type, and having a function behave differently
    > according to the number of parameters received as well as their types is
    > a common pattern on JS libraries and frameworks.
    >
    > R=<U+200B>bmeurer@google.com, yangguo@google.com
    >
    > Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61
    > Reviewed-on: https://chromium-review.googlesource.com/c/1289489
    > Commit-Queue: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58468}
    
    R=bmeurer@google.com, jkummerow@chromium.org, yangguo@google.com
    
    Change-Id: I53d90bb862d9c5e9541116b375fa4de70e3e76dd
    Reviewed-on: https://chromium-review.googlesource.com/c/1405568
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59458}
    3724a125
frame-array.h 3.52 KB