• Ganesh Ajjanagadde's avatar
    swresample/resample: speed up upsampling by precomputing sines · b87ca4bf
    Ganesh Ajjanagadde authored
    When upsampling, factor is set to 1 and sines need to be evaluated only
    once for each phase, and the complexity should not depend on the number
    of filter taps. This does the desired precomputation, yielding
    significant speedups. Hard guarantees on the gain are not possible, but gains
    themselves are obvious and are illustrated below.
    
    Sample benchmark (x86-64, Haswell, GNU/Linux)
    test: fate-swr-resample-dblp-2626-44100
    old:
    29161085 decicycles in build_filter (loop 1000),     256 runs,      0 skips
    28821467 decicycles in build_filter (loop 1000),     512 runs,      0 skips
    28668201 decicycles in build_filter (loop 1000),    1000 runs,     24 skips
    
    new:
    14351936 decicycles in build_filter (loop 1000),     256 runs,      0 skips
    14306652 decicycles in build_filter (loop 1000),     512 runs,      0 skips
    14299923 decicycles in build_filter (loop 1000),    1000 runs,     24 skips
    
    Note that this does not statically allocate the sin lookup table. This
    may be done for the default 1024 phases, yielding a 512*8 = 4kB array
    which should be small enough.
    This should yield a small improvement. Nevertheless, this is separate from
    this patch, is more ambiguous due to the binary increase, and requires a
    lut to be generated offline.
    Reviewed-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    Signed-off-by: 's avatarGanesh Ajjanagadde <gajjanagadde@gmail.com>
    b87ca4bf
Name
Last commit
Last update
compat Loading commit data...
doc Loading commit data...
libavcodec Loading commit data...
libavdevice Loading commit data...
libavfilter Loading commit data...
libavformat Loading commit data...
libavresample Loading commit data...
libavutil Loading commit data...
libpostproc Loading commit data...
libswresample Loading commit data...
libswscale Loading commit data...
presets Loading commit data...
tests Loading commit data...
tools Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
COPYING.GPLv2 Loading commit data...
COPYING.GPLv3 Loading commit data...
COPYING.LGPLv2.1 Loading commit data...
COPYING.LGPLv3 Loading commit data...
CREDITS Loading commit data...
Changelog Loading commit data...
INSTALL.md Loading commit data...
LICENSE.md Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
RELEASE Loading commit data...
arch.mak Loading commit data...
cmdutils.c Loading commit data...
cmdutils.h Loading commit data...
cmdutils_common_opts.h Loading commit data...
cmdutils_opencl.c Loading commit data...
common.mak Loading commit data...
configure Loading commit data...
ffmpeg.c Loading commit data...
ffmpeg.h Loading commit data...
ffmpeg_dxva2.c Loading commit data...
ffmpeg_filter.c Loading commit data...
ffmpeg_opt.c Loading commit data...
ffmpeg_qsv.c Loading commit data...
ffmpeg_vdpau.c Loading commit data...
ffmpeg_videotoolbox.c Loading commit data...
ffplay.c Loading commit data...
ffprobe.c Loading commit data...
ffserver.c Loading commit data...
ffserver_config.c Loading commit data...
ffserver_config.h Loading commit data...
library.mak Loading commit data...
version.sh Loading commit data...