• Anssi Hannula's avatar
    avformat/hls: Fix regression with ranged media segments · 9cb30f7a
    Anssi Hannula authored
    Commit 81306fd4bdf ("hls: eliminate ffurl_* usage", merged in d0fc5de3)
    changed the hls demuxer to use AVIOContext instead of URLContext for its
    HTTP requests.
    
    HLS demuxer uses the "offset" option of the http demuxer, requesting
    the initial file offset for the I/O (http URLProtocol uses the "Range:"
    HTTP header to try to accommodate that).
    
    However, the code in libavformat/aviobuf.c seems to be doing its own
    accounting for the current file offset (AVIOContext.pos), with the
    assumption that the initial offset is always zero.
    
    HLS demuxer does an explicit seek after open_url to account for cases
    where the "offset" was not effective (due to the URL being a local file
    or the HTTP server not obeying it), which should be a no-op in case the
    file offset is already at that position.
    
    However, since aviobuf.c code thinks the starting offset is 0, this
    doesn't work properly.
    
    This breaks retrieval of ranged media segments.
    
    To fix the regression, just drop the seek call from the HLS demuxer when
    the HTTP(S) protocol is used.
    9cb30f7a
Name
Last commit
Last update
compat Loading commit data...
doc Loading commit data...
libavcodec Loading commit data...
libavdevice Loading commit data...
libavfilter Loading commit data...
libavformat Loading commit data...
libavresample Loading commit data...
libavutil Loading commit data...
libpostproc Loading commit data...
libswresample Loading commit data...
libswscale Loading commit data...
presets Loading commit data...
tests Loading commit data...
tools Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
COPYING.GPLv2 Loading commit data...
COPYING.GPLv3 Loading commit data...
COPYING.LGPLv2.1 Loading commit data...
COPYING.LGPLv3 Loading commit data...
CREDITS Loading commit data...
Changelog Loading commit data...
INSTALL.md Loading commit data...
LICENSE.md Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
RELEASE Loading commit data...
arch.mak Loading commit data...
cmdutils.c Loading commit data...
cmdutils.h Loading commit data...
cmdutils_common_opts.h Loading commit data...
cmdutils_opencl.c Loading commit data...
common.mak Loading commit data...
configure Loading commit data...
ffmpeg.c Loading commit data...
ffmpeg.h Loading commit data...
ffmpeg_cuvid.c Loading commit data...
ffmpeg_dxva2.c Loading commit data...
ffmpeg_filter.c Loading commit data...
ffmpeg_opt.c Loading commit data...
ffmpeg_qsv.c Loading commit data...
ffmpeg_vaapi.c Loading commit data...
ffmpeg_vdpau.c Loading commit data...
ffmpeg_videotoolbox.c Loading commit data...
ffplay.c Loading commit data...
ffprobe.c Loading commit data...
ffserver.c Loading commit data...
ffserver_config.c Loading commit data...
ffserver_config.h Loading commit data...
library.mak Loading commit data...
version.sh Loading commit data...