• wm4's avatar
    matroskadec: export cover art correctly · 511585ce
    wm4 authored
    Generally, libavformat exports cover art pictures as video streams with
    1 packet and AV_DISPOSITION_ATTACHED_PIC set. Only matroskadec exported
    it as attachment with codec_id set to AV_CODEC_ID_MJPEG.
    
    Obviously, this should be consistent, so change the Matroska demuxer to
    export a AV_DISPOSITION_ATTACHED_PIC pseudo video stream.
    
    Matroska muxing is probably incorrect too. I know that it can create
    broken files with an audio track and just 1 video frame when e.g.
    remuxing mp3 with APIC to mkv. But for now this commit does not change
    anything about muxing, and also continues to write attachments with
    AV_CODEC_ID_MJPEG should the muxer application have special knowledge
    that the Matroska is broken in this way.
    
    Fixes trac #4423.
    Signed-off-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
    511585ce
Name
Last commit
Last update
compat Loading commit data...
doc Loading commit data...
libavcodec Loading commit data...
libavdevice Loading commit data...
libavfilter Loading commit data...
libavformat Loading commit data...
libavresample Loading commit data...
libavutil Loading commit data...
libpostproc Loading commit data...
libswresample Loading commit data...
libswscale Loading commit data...
presets Loading commit data...
tests Loading commit data...
tools Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
COPYING.GPLv2 Loading commit data...
COPYING.GPLv3 Loading commit data...
COPYING.LGPLv2.1 Loading commit data...
COPYING.LGPLv3 Loading commit data...
CREDITS Loading commit data...
Changelog Loading commit data...
INSTALL.md Loading commit data...
LICENSE.md Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
RELEASE Loading commit data...
arch.mak Loading commit data...
cmdutils.c Loading commit data...
cmdutils.h Loading commit data...
cmdutils_common_opts.h Loading commit data...
cmdutils_opencl.c Loading commit data...
common.mak Loading commit data...
configure Loading commit data...
ffmpeg.c Loading commit data...
ffmpeg.h Loading commit data...
ffmpeg_dxva2.c Loading commit data...
ffmpeg_filter.c Loading commit data...
ffmpeg_opt.c Loading commit data...
ffmpeg_vda.c Loading commit data...
ffmpeg_vdpau.c Loading commit data...
ffplay.c Loading commit data...
ffprobe.c Loading commit data...
ffserver.c Loading commit data...
ffserver_config.c Loading commit data...
ffserver_config.h Loading commit data...
library.mak Loading commit data...
version.sh Loading commit data...