• Bodecs Bela's avatar
    av_format/hlsenc: fix %v handling by format_name function · 09a48539
    Bodecs Bela authored
    Hi All,
    
    When multiple variant streams are specified by var_stream_map option, %v
    placeholder in various names ensures that each variant has its unique
    names. Most of %v handlng is done in format_name function. Currently
    in this function the result buffer is the same as the
    input pattern buffer, so you must allocate it before calling format_name
    function. It also means, that it is silently assumed that the result
    string will NOT be
    longer that the pattern string. It is true most of the time, because %v
    may appear only once in the pattern string and number of variant streams
    is less than 100 in practical cases. But theoretically it will fail if
    specified number of variant streams is greater than 100 (i.e. longer
    than 2 digits).
    This patch fixes this behaviour by altering format_name function to
    allocate the
    result buffer and return it to the caller.
    
    Please, review this patch.
    
    best,
    
    Bela
    >From 6377ebee8a106a9684d41b270c7d6c8e57cd3e7b Mon Sep 17 00:00:00 2001
    From: Bela Bodecs <bodecsb@vivanet.hu>
    Date: Mon, 17 Jun 2019 14:31:36 +0200
    Subject: [PATCH] av_format/hlsenc: fix %v handling by format_name function
    
    When multiple variant streams are specified by var_stream_map option, %v
    placeholder in various names ensures that each variant has its unique
    names. Most of %v handlng is done in format_name function. Currently
    in this function the result buffer is the same as the input pattern
    buffer, so you must allocate it before calling format_name function. It
    also means, that it is silently assumed that the result string will NOT
    be longer that the pattern string. It is true most of the time, because
    %v may appear only once in the pattern string and number of variant
    streams is less than 100 in practical cases. But theoretically it will
    fail if specified number of variant streams is greater than 100. This
    patch fixes this behaviour by altering format_name function to allocate
    the result buffer and return it to the caller.
    Signed-off-by: 's avatarBela Bodecs <bodecsb@vivanet.hu>
    09a48539
Name
Last commit
Last update
compat Loading commit data...
doc Loading commit data...
ffbuild Loading commit data...
fftools Loading commit data...
libavcodec Loading commit data...
libavdevice Loading commit data...
libavfilter Loading commit data...
libavformat Loading commit data...
libavresample Loading commit data...
libavutil Loading commit data...
libpostproc Loading commit data...
libswresample Loading commit data...
libswscale Loading commit data...
presets Loading commit data...
tests Loading commit data...
tools Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYING.GPLv2 Loading commit data...
COPYING.GPLv3 Loading commit data...
COPYING.LGPLv2.1 Loading commit data...
COPYING.LGPLv3 Loading commit data...
CREDITS Loading commit data...
Changelog Loading commit data...
INSTALL.md Loading commit data...
LICENSE.md Loading commit data...
MAINTAINERS Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
RELEASE Loading commit data...
configure Loading commit data...