Commits · f83b46e2181c9eb0360cb61419f29a1e44f04954 · Linshizhi / ffmpeg.wasm-core

08 Jul, 2019 39 commits

configure, cbs_h2645: Remove unneeded golomb dependency · f83b46e2
Andreas Rheinhardt authored Jul 08, 2019
```
This has been forgotten in 44cde38c.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
```
f83b46e2

cbs_h264, h264_metadata: Deleting SEI messages never fails · d9418aba

Andreas Rheinhardt authored Jul 07, 2019

Given the recent changes to ff_cbs_delete_unit, it is no longer sensible
to use a return value for ff_cbs_h264_delete_sei_message; instead, use
asserts to ensure that the required conditions are met and remove the
callers' checks for the return value. Also, document said conditions.

An assert that is essentially equivalent to the one used in
ff_cbs_delete_unit has been removed, too.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>

d9418aba

cbs: ff_cbs_delete_unit: Replace return value with assert · 730e5be3

Andreas Rheinhardt authored Jul 07, 2019

ff_cbs_delete_unit never fails if the index of the unit to delete is
valid, as it is with all current callers of the function. So just assert
in ff_cbs_delete_unit that the index is valid and change the return
value to void in order to remove the callers' checks for whether
ff_cbs_delete_unit failed.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>

730e5be3

lavd/avfoundation: Set correct default value 0 for option capture_raw_data. · 70a4f46e
Thilo Borgmann authored Jul 08, 2019

70a4f46e
doc/indevs: Add new option and example to avfoundation. · d16f2faf
Thilo Borgmann authored Jul 08, 2019

d16f2faf
lavd/avfoundation: Reindent after last commit. · 5c2e0e41
Thilo Borgmann authored Jul 08, 2019

5c2e0e41
lavd/avfoundation: Support muxed type of devices including raw muxed data capture. · 02f65678
Thilo Borgmann authored Jul 08, 2019

02f65678
lavd/avfoundation: Refine some log messages. · 3a5f9ab8
Thilo Borgmann authored Jul 08, 2019

3a5f9ab8
lavd/avfoundation: Change binary Options to boolean type. · 7d4df4b3
Thilo Borgmann authored Jul 08, 2019

7d4df4b3
lavd/avfoundation: Remove useless index increment. · 48cf9524
Thilo Borgmann authored Jun 30, 2019

48cf9524
doc/filters: document new readeia608 option · 43160c7b
Paul B Mahol authored Jul 08, 2019

43160c7b
avfilter/vf_readeia608: implement lowpass operation prior to processing lines · 9e78c73d
Paul B Mahol authored Jul 08, 2019

9e78c73d
avfilter/vf_tinterlace: re-enable lowpass option · dc481105
Paul B Mahol authored Jul 08, 2019

dc481105
avfilter/af_aiir: implement mix option · 2a801e88
Paul B Mahol authored Jul 08, 2019

2a801e88
avfilter/af_biquads: clip gain picked from command to sane values · 034a9d25
Paul B Mahol authored Jul 08, 2019

034a9d25
avfilter/af_biquads: implement mix option to all filters · 7b2d39fc
Paul B Mahol authored Jul 08, 2019

7b2d39fc

avcodec/ilbcdec: Simplify use of unsigned and fix more undefined overflows · 019d7290

Michael Niedermayer authored Jun 30, 2019

Fixes: signed integer overflow: 2147475672 + 8192 cannot be represented in type 'int'
Fixes: 15415/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5712074128228352

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

019d7290

avcodec/golomb: Correct the doxy about get_ue_golomb() and errors · 1bb3b3f1
Michael Niedermayer authored Jun 30, 2019
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
1bb3b3f1

avformat/utils: Check timebase before use in estimate_timings() · f57e97df

Michael Niedermayer authored Jun 29, 2019

Fixes: division by 0
Fixes: 15480/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5746727434321920

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

f57e97df

avcodec/hq_hqa: Use ff_set_dimensions() · a6229fcd

Michael Niedermayer authored Jun 29, 2019

Fixes: 15530/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQ_HQA_fuzzer-5637370344374272
Fixes: signed integer overflow: 65312 * 65312 cannot be represented in type 'int'

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a6229fcd

avcodec/rv10: Fix integer overflow in aspect ratio compare · 14fcf429

Michael Niedermayer authored Jun 28, 2019

Fixes: signed integer overflow: 2040 * 1187872 cannot be represented in type 'int'
Fixes: 15368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5681657136283648

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

14fcf429

avcodec/tta: Limit decoder to 16 channels · 17209e48

Michael Niedermayer authored Jun 28, 2019

libtta 2.3 has a limit of 6 channels, so 16 is substantially above the "official" already

Fixes: OOM
Fixes: 15249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5643988125614080

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

17209e48

avcodec/sanm: Optimize fill_frame() with av_memcpy_backptr() · 936ca7f1

Michael Niedermayer authored Jun 28, 2019

Fixes: Timeout (76 sec -> 24 sec)
Fixes: 15043/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-5699856238116864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

936ca7f1

avformat/vividas: Check for input length in get_v() · e69106e7

Michael Niedermayer authored Jun 26, 2019

Fixes: out of array read
Fixes: 15286/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5658245101780992

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

e69106e7

avcodec/4xm: Fix signed integer overflows in idct() · 2bbea155

Michael Niedermayer authored Jun 26, 2019

Fixes: signed integer overflow: 20242 * 121095 cannot be represented in type 'int'
Fixes: 15310/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5737051745419264

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

2bbea155

avcodec/qdm2: Check checksum_size for 0 · 7b2ebf89

Michael Niedermayer authored Jun 23, 2019

Fixes: Infinite loop
Fixes: 15337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5757428949319680

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

7b2ebf89

avcodec/qdm2: error out of qdm2_fft_decode_tones() before entering endless loop · 694be24b

Michael Niedermayer authored Jun 23, 2019

Fixes: signed integer overflow: 2147483646 + 2 cannot be represented in type 'int'
Fixes: infinite loop
Fixes: 15396/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5116605501014016

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

694be24b

avcodec/qdm2: Do not read out of array in fix_coding_method_array() · ae021c12

Michael Niedermayer authored Jun 23, 2019

Instead we ask for a sample, its unclear what to do in this case.

Fixes: index 30 out of bounds for type 'int8_t [30][64]'
Fixes: 15339/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5749441484554240

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

ae021c12

avcodec/simple_idct_template: Fix integer overflow in idctSparseColAdd() · 85cbd042

Michael Niedermayer authored Jun 25, 2019

Fixes: signed integer overflow: 1106434976 + 1041773512 cannot be represented in type 'int'
Fixes: 15421/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5669209314426880

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

85cbd042

avcodec/simple_idct_template: Fix integer overflow in idctSparseCol() · b5f2cfd2

Michael Niedermayer authored Jun 25, 2019

Fixes: signed integer overflow: -1027919784 + -1120041624 cannot be represented in type 'int'
Fixes: 15406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-5700646528876544

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

b5f2cfd2

avcodec/svq3: Use ff_set_dimension() · 7b114d76

Michael Niedermayer authored Jun 25, 2019

Fixes: OOM
Fixes: 15410/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-5659464805384192

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

7b114d76

avcodec/iff: Check ham vs bpp · f76d7352

Michael Niedermayer authored Jun 22, 2019

This checks the ham value much stricter and avoids hitting cases which cannot be reached
with data from the libavformat demuxer.

Fixes: out of array access
Fixes: 15320/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5080476840099840
Fixes: 15423/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5630765833912320

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

f76d7352

avcodec/ffwavesynth: use uint32_t to compute difference, it is enough · e9dd3c71

Michael Niedermayer authored Jun 21, 2019

Fixes: signed integer overflow: 6494225984479297536 - -6043795377581187040 cannot be represented in type 'long'
Fixes: 15285/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5632780307791872

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

e9dd3c71

avcodec/ffwavesynth: Simplify lcg_seek(), avoid negative case · 8c022099

Michael Niedermayer authored Jun 21, 2019

Fixes: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value to itself
Fixes: 15289/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5709034499342336

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

8c022099

avcodec/ffwavesynth: Fix backward lcg_seek() · cf2bd3ce
Michael Niedermayer authored Jun 21, 2019
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
cf2bd3ce

avcodec/flicvideo: Fix off by 1 error in flic_decode_frame_24BPP() · 37708cba

Michael Niedermayer authored Jun 21, 2019

Fixes: out of array access
Fixes: 15360/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5653837190266880
Fixes: 15412/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5740537648250880

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

37708cba

avcodec/vc1_block: Check for vlc error in vc1_decode_ac_coeff() · 79204a1f

Michael Niedermayer authored Jun 15, 2019

Fixes: index -1 out of bounds for type 'const uint8_t [185][2]'
Fixes: 15250/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-5648992869810176

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

79204a1f

avcodec/alac: Check lpc_quant · a6474b89

Michael Niedermayer authored Jun 18, 2019

lpc_quant of 0 produces undefined behavior, thus disallow this.
If valid samples use this then such a sample would be quite
usefull to confirm the correct&lossles handling of this.

Fixes: libavcodec/alac.c:218:25: runtime error: shift exponent -1 is negative
Fixes: 15273/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5656388535058432
Fixes: 15276/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5761238417539072
Fixes: 15315/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5767260766994432

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a6474b89

avcodec/dxv: Initialize tex_funct to NULL · e96b7a8b

Michael Niedermayer authored Jun 03, 2019

Fixes: Various anomalies
Fixes: 14493/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5071018000908288
Fixes: 14630/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5714888963391488

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

e96b7a8b

07 Jul, 2019 1 commit

vp9_metadata: Avoid allocations and copies of packet structures · 98b122cd

Andreas Rheinhardt authored Jun 19, 2019

This commit changes vp9_metadata to (a) use ff_bsf_get_packet_ref
instead of ff_bsf_get_packet (thereby avoiding one malloc and free per
filtered packet) and (b) to use only one packet structure at all,
thereby avoiding a call to av_packet_copy_props.

(b) has been made possible by the recent changes to ff_cbs_write_packet.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>

98b122cd