Generally, libavformat exports cover art pictures as video streams with
1 packet and AV_DISPOSITION_ATTACHED_PIC set. Only matroskadec exported
it as attachment with codec_id set to AV_CODEC_ID_MJPEG.

Obviously, this should be consistent, so change the Matroska demuxer to
export a AV_DISPOSITION_ATTACHED_PIC pseudo video stream.

Matroska muxing is probably incorrect too. I know that it can create
broken files with an audio track and just 1 video frame when e.g.
remuxing mp3 with APIC to mkv. But for now this commit does not change
anything about muxing, and also continues to write attachments with
AV_CODEC_ID_MJPEG should the muxer application have special knowledge
that the Matroska is broken in this way.
Signed-off-by: Anton Khirnov <anton@khirnov.net>

And use it in libavformat.

Based on a similar patch by Stefano Sabatini <stefasab@gmail.com>.

The strptime implementation is supposed to support whitespace and %T.

They are no longer initialized in ff_h264_decode_init() since 43fd3dd8,
so svq3 needs to initialize the manually.

Fixes svq3 decoding, broken since 43fd3dd8.

The previous documentation was very vague and almost misleading.
Signed-off-by: Martin Storsjö <martin@martin.st>

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>

The generic code copies the main context's private data to all the
others. However that is quite dangerous, as it might end up copying some
pointers that are or will become invalid.

Since everything we actually need will be copied later in
update_thread_context(), it's safest to zero the private data in
init_thread_copy(), so it works the same way as init for the main
context.

It will always be initialized when actually parsing the PPS.

There is no real advantage to initializing any of those in init,
assuming yuv420, before the real stream parameters are known.

This makes sure the various DSP contexts get properly initialized in
ff_h264_set_parameter_from_sps() whatever the value of
raw_bits_per_sample.

There is in general no reason for the currently active SPS to be the one
referenced by the PPS being parsed.

Bug-Id: CID 1292519
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

The way it is currently designed is fundamentally unsafe and cannot be
reasonably fixed without completely rewriting it.

Since we are not doing encoding, there is no point in ever touching the
separate encoding context. Always use the stream codec context.

Fixes writing attachments.

CC:libav-devel@libav.org

This is the same as is done for SPS.

This allows the callers to have a hint of the probable stream parameters
without actually decoding anything.

Additionally always set the software pixel format, so it's available
even if ff_get_format() is not called later. This will be useful for
exporting stream parameters from init().

Make sure we don't buffer up more than max_delay worth of data
before writing a PES packet, even if pes_payload_size is set to
a larger value.
Signed-off-by: Martin Storsjö <martin@martin.st>

And forward it to rtp and udp.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

It gets forwarded down to UDP.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Diego Biurrun <diego@biurrun.de>

The default value for unset is -1, not 0.

Problem introduced in 66028b7b

Bug-Id: 835

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Signed-off-by: Anton Khirnov <anton@khirnov.net>

Based on a patch by Rodger Combs.
Signed-off-by: Anton Khirnov <anton@khirnov.net>

This is to avoid conflicts with the upcoming QSV encoding support.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>