Commits · a035fd88ae7341a05c01f3b393921933e4ea9665 · Linshizhi / ffmpeg.wasm-core

12 May, 2020 14 commits

avcodec/iff: Test video_size being non zero · a035fd88

Michael Niedermayer authored May 11, 2020

Fixes: Out of array access
Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5658548592967680
Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5723561177382912

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a035fd88

avcodec/cdtoons: Check sprite_offset is within the packet · 4d701e92

Michael Niedermayer authored May 11, 2020

Fixes: out of array read
Fixes: 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CDTOONS_fuzzer-5754518731227136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

4d701e92

libavcodec/decode: Mark decode_simple_internal() as inline · 19738b1b

Michael Niedermayer authored May 11, 2020

This was suggested in
https://github.com/google/oss-fuzz/issues/3787
to reduce the grouping errors by oss-fuzz
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

19738b1b

avformat/hlsenc: free options fix memleak in hls_write_trailer · ba436c15
Steven Liu authored May 12, 2020
```
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
```
ba436c15
avformat/hlsenc: fix filename memleak in hls_write_packet · 76eaca43
Steven Liu authored May 12, 2020
```
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
```
76eaca43
avformat/hlsenc: move number out of hls_start · e684d07a
Steven Liu authored May 12, 2020
```
Signed-off-by: Steven Liu <liuqi05@kuaishou.com>
```
e684d07a
vp9dec: support exporting QP tables through the AVVideoEncParams API · ffae62d9
Anton Khirnov authored Mar 23, 2020

ffae62d9
vp9dec: factorise freeing per-tile allocated data · c90f57c6
Anton Khirnov authored Mar 30, 2020

c90f57c6
lavc: add a flag for exporting AVVideoEncParams from decoders · c5844096
Anton Khirnov authored Mar 10, 2020

c5844096
vf_showinfo: support AV_FRAME_DATA_VIDEO_ENC_PARAMS · b84a2b91
Anton Khirnov authored Mar 23, 2020

b84a2b91

libavutil: add API for exporting video frame quantizers · 991d4176

Juan De León authored Feb 29, 2020

This is intended to replace the deprecated the AV_FRAME_DATA_QP_TABLE*
API and extend it to a wider range of codecs.

In the future, it may also be extended to support other encoding
parameters such as motion vectors.

Additional changes by Anton Khirnov <anton@khirnov.net> with suggestions
by Lynne <dev@lynne.ee>.
Signed-off-by: Juan De León <juandl@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Anton Khirnov <anton@khirnov.net>

991d4176

doc/examples/muxing: convert to new encoding API · d8de9d46
Anton Khirnov authored Apr 11, 2020

d8de9d46
doc/examples/demuxing_decoding: convert to new decoding API · 3bfe2038
Anton Khirnov authored Apr 11, 2020

3bfe2038
doc/examples/demuxing_decoding: drop -refcount · e4edf220
Anton Khirnov authored Apr 11, 2020
```
Non-refcounted frames are deprecated and there is no good reason to use
them.
```
e4edf220

11 May, 2020 12 commits

avcodec/utvideodec: Fix integer overflow in decode_plane() · 876cfa67

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: 2147483594 + 142 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_UTVIDEO_fuzzer-5658568101724160

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

876cfa67

avcodec/ttadsp: Fix several integer overflows in tta_filter_process_c() · 86278851

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: 1931744255 + 252497024 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5763348114440192

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

86278851

avcodec/ralf: Fix integer overflow in decode_block() · 0c433084

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: 289082077 - -2003141111 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5196077752123392

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

0c433084

avcodec/nuv: widen buf_size type · 1ac106bf

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: 65312 * 65312 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5740176118906880

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

1ac106bf

libswscale: fix for floating point formats, require full chroma · fabeef22

Mark Reid authored May 10, 2020

upon more floating point testing, looks like I missed adding this bit.
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

fabeef22

test: Add codecview test · 5f359f2b
Michael Niedermayer authored Apr 18, 2020

5f359f2b
tests: Add pp7, spp tests based on pp test · b1e9764c
Michael Niedermayer authored Apr 18, 2020

b1e9764c
avfilter/vf_spp: Fix endian-dependance in add_block() · 52cc86ca
Michael Niedermayer authored Apr 18, 2020
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
52cc86ca
avfilter/vf_spp: Remove unused AVCodecContext · dde86d0d
Michael Niedermayer authored Apr 18, 2020
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
dde86d0d

Revert "hwcontext_vulkan: only use one semaphore per image" · 70d396c8

Lynne authored May 11, 2020

This reverts commit 97b526c1.
It broke the API, and assumed no other APIs used multiple semaphores.
This also disallowed certain optimizations to happen.

Dealing with APIs that give or expect single semaphores is easier when
we use per-image semaphores.

70d396c8

avformat/ivfenc: move bsf insertion to the init function · 29329052

James Almer authored May 10, 2020

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

29329052

avformat/ivfenc: add an AVOutputFormat.init() function · 8e12f09a
James Almer authored May 10, 2020
```
Signed-off-by: James Almer <jamrial@gmail.com>
```
8e12f09a

10 May, 2020 14 commits

avcodec/iff: Fix several integer overflows · 7a92147f

Michael Niedermayer authored May 10, 2020

Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int32_t' (aka 'int')
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5764066459254784

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

7a92147f

avcodec/g729postfilter: Clip gain before scaling with AGC_FAC1 · 82d4c7b9

Michael Niedermayer authored May 10, 2020

The fixed point integer reference specifies the multiplication used
to have 16bit input and clips so we need to clip the input
The floating point implementation does not seem to do that.

Fixes: signed integer overflow: 6317568 * 410 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G729_fuzzer-5700189272932352

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

82d4c7b9

avcodec/alac: Fix integer overflow with 24/20bps samples · 22e51e95

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: 1020048 * 4096 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5753877751660544

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

22e51e95

avcodec/adpcm: Clip predictor for IMA_APM · 8ee264e6

Michael Niedermayer authored May 10, 2020

Fixes: signed integer overflow: -2147483647 - 61436 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_APM_fuzzer-5092176004644864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

8ee264e6

hwcontext_vulkan: convert to general layout and transfer queue when exporting · fc99a247

Lynne authored May 10, 2020

The specs note that images should be in the GENERAL layout when exporting
for maximum compatibility.
CUDA exported images are handled differently, and the queue is the same,
so we don't need to do that there.

fc99a247

hwcontext_vulkan: create all images with concurrent sharing mode · 875c1707

Lynne authored May 10, 2020

As it turns out, we were already assuming and treating all images as if they had
concurrent access mode. This just changes the flag to CONCURRENT, which has less
restrictions than EXCLUSIVE, and fixed validation messages on machines with
multiple queues.
The validation layer didn't pick this up because the machine I was testing on
had only a single queue.

875c1707

hwcontext_vulkan: fix inverted condition when exporting images to drm_prime · 7c080dc1
Lynne authored May 10, 2020
```
Calling vkGetImageSubresourceLayout is only legal for linear and drm images.
```
7c080dc1
hwcontext_vulkan: update debugging layer name · acfef378
Lynne authored May 10, 2020

acfef378

hwcontext_vulkan: remove unused internal REQUIRED extension flag · 030a565b

Lynne authored May 10, 2020

This is a leftover from an old version which used the 1.0 Vulkan API
with the maintenance extensions being required.

030a565b

hwcontext_vulkan: expose enabled device and instance extensions · dccd07f6

Lynne authored May 10, 2020

This solves a huge oversight - it lets users reliably use their own
AVVulkanDeviceContext. Otherwise, the extensions supplied and enabled
are not discoverable by anything outside of hwcontext_vulkan.
Also clarifies that any user-supplied VkInstance must be at least 1.1.

dccd07f6

hwcontext_vulkan: let users enable device and instance extensions using options · 3c5e5a50

Lynne authored May 10, 2020

Also documents all options supported by the hwdevice.
This lets users enable all extensions they need without writing their own
instance initialization code.

3c5e5a50

avformat/hlsenc: Simplify setting base_output_dirname · 6db81e93
Andreas Rheinhardt authored May 08, 2020
```
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
```
6db81e93
avformat/hlsenc: Simplify setting basename with av_asprintf() · 21553d20
Andreas Rheinhardt authored Apr 08, 2020
```
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
```
21553d20
avformat/hlsenc: Simplify setting subtitle basename with av_asprintf · 6b44f683
Andreas Rheinhardt authored Apr 08, 2020
```
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
```
6b44f683