This macro unconditionally used out[-1], which causes an out of bounds
read, if out is the very beginning of the buffer.
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

More don't fit into the integer output.

Also use get_bits_long, since get_bits only supports reading up to 25
bits, while get_bits_long supports the full integer range.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

The type of last_frame_pb_count was chosen to be an int since overflow
is impossible (the spec says the maximum bits per frame is 6144 per
channel and the encoder checks for that).
Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
Reviewed-by: Paul B Mahol <onemda@gmail.com>

For people who cant read.
Signed-off-by: Paul B Mahol <onemda@gmail.com>

Signed-off-by: Paul B Mahol <onemda@gmail.com>

* commit '458e53f5':
  mpegvideo_enc: actually add the side data with vbv_delay to the packet
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'b0b133b8':
  hevcdsp: use a macro for .rodata section
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '81c95eb8':
  openh264: Directly include the deprecation guards header
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '34138ece':
  log: Use a do {} while (0) for tlog
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'febfb49a':
  matroskadec: Fix sample_aspect_ratio for stereo matroska content
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

The options were not actually hooked up.

* commit 'c34df422':
  sgienc: Make sure to initialize skipped header portions
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '16216b71':
  lavc: Drop exporting 2-pass encoding stats
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'be00ec83':
  lavc: Deprecate coder_type and its symbols
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

Signed-off-by: Paul B Mahol <onemda@gmail.com>

Signed-off-by: Paul B Mahol <onemda@gmail.com>

We need these if we have no strerror_r.

Descriptions are taken from doc/errno.txt except for ENOMEM.
Signed-off-by: Marton Balint <cus@passwd.hu>

Signed-off-by: Marton Balint <cus@passwd.hu>

Fixes ubsan warning
Fixes Mozilla bug 1230276
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

This also suppresses a ubsan warning
Fixes Mozilla bug 1230247
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

exp2 is faster.

It may be possible to optimize further; e.g the exponents seem to be
multiples of 0.25. This requires study though.
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

The change was not correct and broke H264

This reverts commit cd83f899c94f691b045697d12efa21f83eb2329f.

If that is the case, the loop setting predictor_state in
sonic_decode_frame causes out of bounds reads of int_samples, which has
only frame_size number of elements.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Reviewed-by: Hendrik Leppkes <h.leppkes@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

Reviewed-by: Hendrik Leppkes <h.leppkes@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

exp2 suffices here. Some trivial speedup is done in addition here by
reusing results.

This retains accuracy, and in particular results in identical values
with GNU libm + gcc/clang.

sample benchmark (Haswell, GNU/Linux):
proposed : 424160 decicycles in pow_table,     512 runs,      0 skips
exp2 only: 1262093 decicycles in pow_table,     512 runs,      0 skips
old      : 2849085 decicycles in pow_table,     512 runs,      0 skips
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

arc4random() was designed as a superior interface for system random
number generation, designed for OpenBSD and subsequently incorporated by
other BSD's, Mac OS X, and some non-standard libc's. It is thus an improvement to
use it whenever available.

As a side note, this may or may not get included in glibc, and there is
a proposal to create a posix_random family based on these ideas:
http://austingroupbugs.net/view.php?id=859.

Tested on Mac OS X.
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>

* commit 'f1ccd076':
  h264: do not call frame_start() for missing frames

Not merged, FFmpeg does a lot more in frame_start to setup missing frames
as well (like coloring them), and the overhead of the other setup is
minimal.
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'd6dc5d15':
  aacdec: fix aac_static_table_init() prototype
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '68e547ae':
  avpacket: use ERANGE instead of EOVERFLOW
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'd5f5c90b':
  rtsp: free opts dictionary on failure of getnameinfo
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '8df8f0c7':
  movenc-test: add a missing va_end call
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'b8b21dee':
  mxfenc: always assume long gop
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit 'e02de9df':
  lavc: export Dirac parsing API used by the ogg demuxer as public
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '8bcadaac':
  mpegenc: use the CPB props side data
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '5845a827':
  movenc: use the CPB props side data
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>

* commit '82590024':
  qsvenc: export CPB props side data
Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>