Commits · 7797fdfe6f33a7fc35ec147edcb7d1aac47b4a75 · Linshizhi / ffmpeg.wasm-core

21 Oct, 2019 21 commits

avformat/matroskaenc: Use ffio_free_dyn_buf · 7797fdfe

Andreas Rheinhardt authored Oct 16, 2019

instead of replicating its behaviour.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

7797fdfe

avformat/matroskaenc: Fix memleak upon failure · 982a98a0

Andreas Rheinhardt authored Oct 16, 2019

The Matroska muxer up until now leaked memory in two scenarios:

1. If an error happened during writing the trailer, as
mkv_write_trailer() returned early without cleaning up.
2. If mkv_write_header() indicated success despite an error in the
underlying AVIOContext. In this case avformat_write_header() returned
the IO error and according to the API the caller is not allowed to call
av_write_trailer(), so that no cleanup happened for the allocations made
in mkv_write_header().

This has been fixed by using a dedicated deinit function.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

982a98a0

avfilter/vsrc_mptestsrc: simplify the code and change the type of frame · 887db368
Limin Wang authored Oct 21, 2019
```
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
887db368

avcodec/atrac9dec: Set channels · e85eb7cb

Michael Niedermayer authored Oct 20, 2019

Fixes: null pointer dereference
Fixes: 18341/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5681203490848768

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Lynne <dev@lynne.ee>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

e85eb7cb

avfilter/vsrc_mptestsrc: add options to set the maximum number of frames · 6079bd5c
Limin Wang authored Oct 21, 2019
```
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
6079bd5c
avfilter/vf_unsharp: rename config_props -> config_input, link -> inlink · 7a477c4b
Limin Wang authored Oct 14, 2019
```
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
7a477c4b

avformat/oggenc: free buffered page lists while uninitializing the muxer · cecf29eb

James Almer authored Oct 21, 2019

If the trailer is never writen, there could be buffered pages that would leak.
Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

cecf29eb

avformat/flacenc: add a deinit function · aeb8b65c

James Almer authored Oct 21, 2019

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

aeb8b65c

avformat/mp3enc: add init and deinit functions · df57246a

James Almer authored Oct 21, 2019

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

df57246a

avformat/ttaenc: add a deinit function · b46cdd9d

James Almer authored Oct 21, 2019

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

b46cdd9d

avformat/avienc: add deinit function · a581bb66

James Almer authored Oct 19, 2019

Fixes ticket #8302
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

a581bb66

avformat: call AVOutputFormat->deinit() when freeing the context · 02cf2391

James Almer authored Oct 19, 2019

Despite the doxy stating that it's called when the muxer is destroyed,
this was not true in practice. It's only called by av_write_trailer()
and on init() failure.

An AVFormatContext may be closed without writing the trailer if errors
ocurred while muxing packets, so in order to prevent memory leaks, it
should effectively be called when freeing the muxer.
Signed-off-by: James Almer <jamrial@gmail.com>

02cf2391

x86/vf_transpose: fix cpuflags check · 27bae5aa
James Almer authored Oct 21, 2019
```
Signed-off-by: James Almer <jamrial@gmail.com>
```
27bae5aa
avfilter/vf_transpose: add x86 SIMD · ccd9bca1
Paul B Mahol authored Oct 21, 2019

ccd9bca1
avfilter/x86/vf_atadenoise: fix comment · f7f4691f
Paul B Mahol authored Oct 21, 2019

f7f4691f
avfilter/af_join: fix possible memory leaks · aa26f83b
Paul B Mahol authored Oct 21, 2019
```
Allocation of input frames is independent from
allocation of new input pads.
```
aa26f83b
avfilter/af_silencedetect: change mono default to integer literal · 9c317880
Limin Wang authored Oct 08, 2019
```
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Reviewed-by: Gyan Doshi <ffmpeg@gyani.pro>
```
9c317880

avfilter/af_silencedetect: use AV_OPT_TYPE_DURATION · 190f52ba

Limin Wang authored Oct 08, 2019

Reviewed-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>

190f52ba

avfilter: add bilateral filter · c6e01ebe
Paul B Mahol authored May 13, 2018
```
Signed-off-by: Paul B Mahol <onemda@gmail.com>
```
c6e01ebe
avfilter/vf_nlmeans: round values toward nearest integer · a174e5f8
Paul B Mahol authored Oct 20, 2019
```
Instead of rounding toward zero and thus producing
darker output.
```
a174e5f8

avfilter/af_silencedetect: document metadata · 0afc1fe1

Limin Wang authored Oct 08, 2019

Reviewed-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>

0afc1fe1

20 Oct, 2019 15 commits

avcodec/alsdec: Check that input space for header exists in read_diff_float_data() · 09581f79

Michael Niedermayer authored Oct 04, 2019

Fixes: Timeout (21sec -> 8sec)
Fixes: 17832/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5737092172218368

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

09581f79

avformat/pjsdec: Check duration for overflow · 1efaac69

Michael Niedermayer authored Oct 04, 2019

Fixes: signed integer overflow: -3 - 9223372036854775807 cannot be represented in type 'long'
Fixes: 17828/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5645915116797952

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

1efaac69

avcodec/agm: Check for reference frame earlier · 315a4459

Michael Niedermayer authored Oct 03, 2019

Fixes: Timeout (14sec - 120ms)
Fixes: 17824/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5639825457152000

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

315a4459

avcodec/ptx: Check that the input contains at least one line · a6ad3282

Michael Niedermayer authored Oct 02, 2019

Fixes: Timeout (19sec -> 44ms)
Fixes: 17816/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PTX_fuzzer-5704459950227456

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a6ad3282

avcodec/alac: Fix integer overflow in LPC · 44b73a05

Michael Niedermayer authored Sep 30, 2019

Fixes: signed integer overflow: 2147483628 + 128 cannot be represented in type 'int'
Fixes: 17783/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5146470595952640

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

44b73a05

avcodec/smacker: Fix integer overflows in pred[] in smka_decode_frame() · a76897e1

Michael Niedermayer authored Sep 30, 2019

Fixes: signed integer overflow: -2147481503 + -32732 cannot be represented in type 'int'
Fixes: 17782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5769672225456128

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

a76897e1

avcodec/aliaspixdec: Check input size against minimal picture size · 8c693104

Michael Niedermayer authored Sep 30, 2019

Fixes: Timeout (15sec -> 72ms)
Fixes: 17774/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALIAS_PIX_fuzzer-5193929107963904

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

8c693104

avcodec/ffwavesynth: Fix integer overflows in pink noise addition · 7916b686

Michael Niedermayer authored Sep 29, 2019

Fixes: signed integer overflow: -1795675744 + -1926578528 cannot be represented in type 'int'
Fixes: 17741/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5131336402075648

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

7916b686

avcodec/vc1_block: Fixes integer overflow in vc1_decode_i_block_adv() · 6fdeb208

Michael Niedermayer authored Sep 28, 2019

Fixes: signed integer overflow: 62220 * 262144 cannot be represented in type 'int'
Fixes: 17145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5667394743173120

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

6fdeb208

tools/target_dec_fuzzer: Adjust threshold for DXV · fe63ace9

Michael Niedermayer authored Sep 28, 2019

Fixes: TImeout (20sec -> 4sec)
Fixes: 17735/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5723368317255680

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

fe63ace9

avcodec/wmalosslessdec: Check block_align · c1c79927

Michael Niedermayer authored Oct 19, 2019

Fixes: NULL pointer dereference
Fixes: 18331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5652847445671936

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

c1c79927

avfilter/vf_tile: fix memory leak · 673fce6d
Paul B Mahol authored Oct 19, 2019
```
Fixes #8313
```
673fce6d
avfilter/vf_atadenoise: add support for commands · 357f11ec
Paul B Mahol authored Oct 20, 2019

357f11ec
avfilter/vf_shuffleframes: improve error message · 824b026d
Paul B Mahol authored Oct 20, 2019

824b026d

avformat/options: don't call avformat_free_context() within avformat_alloc_context() · 31aafdac

James Almer authored Oct 19, 2019

avformat_free_context() expects AVFormatContext->internal to not be NULL.
Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

31aafdac

19 Oct, 2019 4 commits
- avformat/nutenc: free all missing dynamic AVIOContext on header writing failure · 90e37ada
  James Almer authored Oct 19, 2019
```
Fixes part of ticket #8316
Signed-off-by: James Almer <jamrial@gmail.com>
```
  90e37ada
- avfilter/af_tremolo: fix heap-buffer overflow · 58bb9d3a
  Paul B Mahol authored Oct 19, 2019
```
Fixes #8317
```
  58bb9d3a
- avfilter/vf_fftdnoiz: round toward nearest integer · 26876fdb
  Paul B Mahol authored Oct 19, 2019
```
Instead of rounding toward zero and thus producing
darker output.
```
  26876fdb
- avfilter/vf_bm3d: round values toward nearest integer · a60232ab
  Paul B Mahol authored Oct 19, 2019
```
Instead of rounding toward zero and thus producing
darker output.
```
  a60232ab