According to the spec, the reference list for a slice should be
constructed by first generating an initial (what we now call "default")
reference list and then optionally applying modifications to it.

Our code has an optimization where the initial reference list is
constructed for the first inter slice and then rebuilt for other slices
if needed. This, however, adds complexity to the code, requires an extra
2.5kB array in the codec context and there is no reason to think that it
has any positive effect on performance. Therefore, simplify the code by
generating the reference list from scratch for each slice.

Currently, the frame stride is passed in bytes, while the MC buffer size
is in int16_t elements, This can be confusing, so pass both strides in
bytes.

This should allow for more efficient SIMD.

This should allow for more efficient SIMD.

This should allow for more efficient SIMD.

Keep the C versions as they are now, to allow the compiler to inline the
interpolation coefficients.

Avoid the warning `-Wempty-body`.

The end-marked was typoed in

f7edcac0

Bug-Id: 761

Unbreak make check.

This fixes builds with --disable-vda, which previously failed with
undefined references to CVImageBuffer* and CVPixelBuffer* functions.
Signed-off-by: Martin Storsjö <martin@martin.st>

While pr is a valid POSIX.1 command, its usage in configure
is a little borderline and is possible to replace it with
printf.

Bug-Id: 913
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

It amounts to about 1/2 of the warnings generated and does not help
spotting anything useful.

Avoid false positives while syncing.

Bug-Id: ffmpeg/4086
Bug-Id: 879
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

avio_tell returns an int64_t.

Bug-Id: CID 1339818

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Additional improvements by Michael Niedermayer <michaelni@gmx.at>.
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Fixes out of array reads.

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com>

Avoid some confusion when the information is not present.

Bug-Id: 902

Copy pointers to AVPicture after memory has been allocated.
Fixes NULL pointers in AVPicture after a17a7661.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Explain better which environment is discouraged and mention the
shortcuts names.

Originally based on the capture written by
Thilo Borgmann <thilo.borgmann@mail.de>.
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

Assume that the default C compiler and the default ObjC compiler match
(default for OSX).
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>

And make one more informative.

And forward the logging contexts when needed.

And properly report the error when it happens.

Signed-off-by: Martin Storsjö <martin@martin.st>

Silences warnings when using -Wshift-overflow (GCC 6+).
Found-by: James Almer <jamrial@gmail.com>

Use the result directly, removing an unneeded cast.