1. 03 Feb, 2017 3 commits
    • Diego Biurrun's avatar
      build: Ignore generated .version files · 740b0bf0
      Diego Biurrun authored
      740b0bf0
    • Martin Storsjö's avatar
      rtmp: Correctly handle the Window Acknowledgement Size packets · 15a92e0c
      Martin Storsjö authored
      This swaps which field is set when the Window Acknowledgement Size
      and Set Peer BW packets are received, renames the fields in
      order to clarify their role further and adds verbose comments
      explaining their respective roles and how well the code currently
      does what it is supposed to.
      
      The Set Peer BW packet tells the receiver of the packet (which
      can be either client or server) that it should not send more data
      if it already has sent more data than the specified number of bytes,
      without receiving acknowledgement for them. Actually checking this
      limit is currently not implemented.
      
      In order to be able to check that properly, one can send the
      Window Acknowledgement Size packet, which tells the receiver of the
      packet that it needs to send Acknowledgement packets
      (RTMP_PT_BYTES_READ) at least after receiving a given number of bytes
      since the last Acknowledgement.
      
      Therefore, when we receive a Window Acknowledgement Size packet,
      this sets the maximum number of bytes we can receive without sending
      an Acknowledgement; therefore when handling this packet we should set
      the receive_report_size field (previously client_report_size).
      Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
      15a92e0c
    • Martin Storsjö's avatar
      rtmp: Rename packet types to closer match the spec · a1a143ad
      Martin Storsjö authored
      Also rename comments and log messages accordingly,
      and add clarifying comments for some hardcoded values.
      
      The previous names were taken from older, reverse engineered
      references.
      
      These names match the official public rtmp specification, and
      matches the names used by wirecast in annotating captured
      streams. These names also avoid hardcoding the roles of server
      and client, since the handling of them is irrelevant of whether
      we act as server or client.
      
      The RTMP_PT_PING type maps to RTMP_PT_USER_CONTROL.
      
      The SERVER_BW and CLIENT_BW types are a bit more intertwined;
      RTMP_PT_SERVER_BW maps to RTMP_PT_WINDOW_ACK_SIZE and
      RTMP_PT_CLIENT_BW maps to RTMP_PT_SET_PEER_BW.
      Signed-off-by: 's avatarMartin Storsjö <martin@martin.st>
      a1a143ad
  2. 02 Feb, 2017 8 commits
  3. 01 Feb, 2017 4 commits
  4. 31 Jan, 2017 12 commits
  5. 30 Jan, 2017 13 commits