Commits · 72915ca8ba66f96717838439ee13cb3f70f9863f · Linshizhi / ffmpeg.wasm-core

11 Nov, 2019 5 commits

avformat/mp3dec: replace SAME_HEADER_MASK with MP3_MASK · 72915ca8

Limin Wang authored Nov 11, 2019

mp3 header bitstream syntax:
header()
{
    syncword   12bits bslsf
    id         1bit    bslsf
    layer      2bit    bslsf
    protection_bit 1bit bslsf
    bitrate_index 4bits bslsf
    sampling_frequency 2bits bslsf
    padding_bit  1bit bslsf
    private_bit 1bit bslsf
    mode 2bits bslsf
    mode_extension 2bits bslsf
    copyright 1bit bslsf
    original/home 1bit bslsf
    emphasis 2bits bslsf
}

if the header is masking with MP3_MASK(0xFFFE0CCF), below fields will be cleared:
protection_bit, bitrate_index, sampling_freqency, mode

with SAME_HEADER_MASK(0xFFFE0C00), extra below fields will be cleared which didn't make
sense:
mode_extension, copyright, original/home, emphasis

As the MP3_MASK is good for same mp3 header masking and is defined in the
header, so it's preferable to remove SAME_HEADER_MASK to keep the masking same.
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

72915ca8

avformat/mp3dec: cosmetics · 52914516

Limin Wang authored Nov 11, 2019

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

52914516

avcodec/dvdec: Don't use restrict directly to fix build on MSVC · b25b6432

Andreas Rheinhardt authored Nov 10, 2019

004ebd4b added a function with a parameter that was declared as restrict
and not av_restrict. This is not supported by MSVC as several FATE-boxes
that now fail to build show. So use av_restrict.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Tested-by: Matthias Troffaes <matthias.troffaes@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

b25b6432

tests/fate/filter-video: add test for colorlevels · 66ac7775

Limin Wang authored Oct 23, 2019

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

66ac7775

avcodec/librav1e: free the RaPacket after using it · 3a84081c

James Almer authored Nov 11, 2019

Fixes leaks.
Reviewed-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>

3a84081c

10 Nov, 2019 1 commit

avcodec: Add librav1e encoder · d8bf2445

Derek Buitenhuis authored May 29, 2019

Port to the new send/receive API by: James Almer <jamrial@gmail.com>.
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>

d8bf2445

09 Nov, 2019 33 commits

avcodec/wmaprodec: get frame during frame decode · 0f89a229

Michael Niedermayer authored Sep 25, 2019

Fixes: memleak
Fixes: 17615/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-5681306024804352

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegReviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

0f89a229

avcodec/interplayacm: Fix overflow of last unused value · 10eabb8e

Michael Niedermayer authored Oct 25, 2019

Fixes: signed integer overflow: -2147450880 - 65535 cannot be represented in type 'int'
Fixes: 18393/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_ACM_fuzzer-5667520110919680

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

10eabb8e

avcodec/adpcm: Fix undefined behavior with negative predictions in IMA OKI · 7786f6c3

Michael Niedermayer authored Oct 25, 2019

Fixes: left shift of negative value -30
Fixes: 18392/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_OKI_fuzzer-5631771831435264

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

7786f6c3

avcodec/cook: Move up and extend block_align check · 1c63edcd

Michael Niedermayer authored Oct 24, 2019

Fixes: signed integer overflow: 2046820356 * 8 cannot be represented in type 'int'
Fixes: 18391/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5631674666188800

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

1c63edcd

avcodec/sbcdec: Fix integer overflows in sbc_synthesize_four() · 00e469fb

Michael Niedermayer authored Oct 21, 2019

Fixes: signed integer overflow: 1494495519 + 1494495519 cannot be represented in type 'int'
Fixes: 18347/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5711714661695488

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

00e469fb

avcodec/twinvq: Check block_align · 97f778e9

Michael Niedermayer authored Oct 22, 2019

Fixes: signed integer overflow: 538976288 * 8 cannot be represented in type 'int'
Fixes: 18348/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_METASOUND_fuzzer-6681325716635648

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

97f778e9

avcodec/cook: Enlarge gain table · 50001cd4

Michael Niedermayer authored Oct 23, 2019

Fixes: index 25 out of bounds for type 'float [23]'
Fixes: 18355/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5641398941908992

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

50001cd4

avcodec/cook: Check samples_per_channel earlier · 57750bb6

Michael Niedermayer authored Oct 23, 2019

Fixes: division by zero
Fixes: 18362/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5653727679086592

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

57750bb6

avcodec/atrac3plus: Check split point in fill mode 3 · de5102fd

Michael Niedermayer authored Oct 22, 2019

Fixes: index 32 out of bounds for type 'int [32]'
Fixes: 18350/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3P_fuzzer-5643794862571520

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

de5102fd

avcodec/wmavoice: Check sample_rate · 55c97a76

Michael Niedermayer authored Oct 23, 2019

Fixes: left shift of 538976288 by 8 places cannot be represented in type 'int'
Fixes: 18376/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-5741645391200256

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

55c97a76

avcodec/xsubdec: fix overflow in alpha handling · 9ea99739

Michael Niedermayer authored Oct 23, 2019

Fixes: left shift of 255 by 24 places cannot be represented in type 'int'
Fixes: 18368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XSUB_fuzzer-5702665442426880

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

9ea99739

avcodec/iff: Check available space before entering loop in... · 32b3c8ce

Michael Niedermayer authored Oct 23, 2019

avcodec/iff: Check available space before entering loop in decode_long_vertical_delta2() / decode_long_vertical_delta()

Fixes: Timeout (31sec -> 41ms)
Fixes: 18380/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5645210121404416

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

32b3c8ce

avcodec/apedec: Fix integer overflow in filter_3800() · 1c038c5c

Michael Niedermayer authored Oct 20, 2019

Fixes: signed integer overflow: 2117181180 + 60483298 cannot be represented in type 'int'
Fixes: 18344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5685327791915008

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

1c038c5c

avcodec/atrac3plusdec: add FF_CODEC_CAP_INIT_CLEANUP · be789992

Michael Niedermayer authored Oct 19, 2019

Fixes: memleaks
Fixes: 18332/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3P_fuzzer-5655654374572032

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

be789992

avutil/lfg: Document the AVLFG struct · d6fea2ef
Michael Niedermayer authored Oct 20, 2019
```
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
d6fea2ef

avcodec/decode: Also consider channels in max_samples check · 20fad712

Michael Niedermayer authored Oct 18, 2019

Fixes: Timeout (109sec -> 0.6sec)
Fixes: 18309/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_ACM_fuzzer-6226598168100864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

20fad712

avcodec/rasc: Check input size in decode_fint() · 17603094

Michael Niedermayer authored Oct 17, 2019

Fixes: Timeout (11sec -> 42ms)
Fixes: 18287/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-5637866331308032

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

17603094

avcodec/ffv1dec: Use a different error message for the slice level CRC · df498cf5
Michael Niedermayer authored Oct 17, 2019
```
This way they can be told apart easily
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
df498cf5

avcodec/apedec: Fix undefined integer overflow in long_filter_ehigh_3830() · 1d1719a4

Michael Niedermayer authored Oct 17, 2019

Fixes: signed integer overflow: -1094995529 * 2 cannot be represented in type 'int'
Fixes: 18281/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5692589180715008

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

1d1719a4

avformat/flvenc: Check pts for mpeg4/h264 (which need the value) · 14d3384c
Michael Niedermayer authored Oct 15, 2019
```
Fixes: Ticket8152
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
14d3384c

avcodec/dstdec: Check that AC probabilities are within range · 0c3e1b39

Michael Niedermayer authored Oct 15, 2019

ISO/IEC 14496-3:2005(E): "Each entry of P_one[ ][ ] is in the range of 1 to
128, corresponding to a probability of 1/256 to 128/256 of the next error bit (bit E, See Figure 10.5)..."

Fixes: Timeout (42sec ->1sec)
Fixes: 18181/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5736646250594304

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

0c3e1b39

avcodec/dstdec: Check read_table() for failure · 03ea8d8c

Michael Niedermayer authored Oct 15, 2019

Fixes: Timeout (too long -> 42sec)
Fixes: 18181/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5736646250594304

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

03ea8d8c

avcodec/vc1_block: Check input in the block decode loops · 2a878596

Michael Niedermayer authored Oct 12, 2019

Fixes: Timeout (196sec -> 2sec)
Fixes: 18026/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5640941108461568

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

2a878596

avcodec/vc1_block: Check for end of bitstream at the top of vc1_decode_i_blocks_adv() · 947732c5

Michael Niedermayer authored Sep 28, 2019

Fixes: Timeout (147sec -> 2sec)
Fixes: 17704/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5723851098423296

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

947732c5

tools/target_dec_fuzzer: Adjust threshold for smacker · de1d3b09

Michael Niedermayer authored Oct 10, 2019

Fixes: Timeout (65sec -> 0.5sec)
Fixes: 18072/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5722709366931456

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

de1d3b09

avcodec/hqx: Check the input data against the image size · 07519f36

Michael Niedermayer authored Jul 20, 2019

Fixes: Timeout (22 -> 100 ms)
Fixes: 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992
Fixes: 17896/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5679312077848576

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

07519f36

avcodec/pafvideo: Only clear frame when it was written to · 859362a6

Michael Niedermayer authored Aug 06, 2019

This avoids unneeded operations and makes the code faster.

Fixes: Timeout
Fixes: 15724/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5750842205929472 (12sec -> 9sec)
Fixes: 17625/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5640515311108096 (16sec -> 4sec)

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

859362a6

avformat/vividas: Fix n_sb_blocks Check · 114ddf64

Michael Niedermayer authored Oct 14, 2019

Fixes: signed integer overflow: 1540265776 * 2 cannot be represented in type 'int'
Fixes: 18160/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758808818712576

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: Michael Niedermayer <michael@niedermayer.cc>

114ddf64

avcodec/snowenc: Set mb_num to avoid ratecontrol floating point divisions by 0.0 · 55279d69
Michael Niedermayer authored Oct 14, 2019
```
Fixes: Ticket7990
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
55279d69
avcodec/snowenc: Fix 2 undefined shifts · 8802e329
Michael Niedermayer authored Oct 14, 2019
```
Fixes: Ticket7990
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
```
8802e329

avformat/mlvdec:drop unnecessary check before ff_format_io_close · bb190ded

Steven Liu authored Nov 09, 2019

Reviewed-by: Linjie Fu <linjie.fu@intel.com>
Reviewed-by: Jun Zhao <barryjzhao@tencent.com>
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>

bb190ded

avcodec/libvpxenc,cosmetics: fix a typo · a605e9ad
James Zern authored Nov 09, 2019
```
predicition -> prediction
```
a605e9ad
avcodec/libvpxdec.c,cosmetics: bpp -> bpc · a6be42a7
James Zern authored Nov 06, 2019
```
Signed-off-by: James Zern <jzern@google.com>
```
a6be42a7

08 Nov, 2019 1 commit
- avfilter/Makefile: add missing framesync dependency to bm3d & mix filters · 007e0334
  Lou Logan authored Nov 06, 2019
```
Signed-off-by: Lou Logan <lou@lrcd.com>
```
  007e0334