Skip to content

F
ffmpeg.wasm-core
Switch branch/tag
  1. 13 Aug, 2019 1 commit
    • Chip Kerchner's avatar
      lsws/ppc/yuv2rgb_altivec: Replace vec_lvsl/vec_perm with vec_xl · 3a557c5d
      Chip Kerchner authored 
      gcc 6.x and 7.x generate wrong code for little endian machines
for the vec_lvsl/vec_perm instruction combos in some cases.
The bug was fixed in version 8.x
If these instructions are replaced with vec_xl, the problem goes
away for all versions of the compilers.

Fixes ticket #7124.
      3a557c5d
  3. 12 Aug, 2019 4 commits
  5. 11 Aug, 2019 25 commits
  7. 10 Aug, 2019 7 commits
  9. 09 Aug, 2019 2 commits
    • Olivier Maignial's avatar
      avformat/rtpdec_mpeg4: Fix integer parameters size check in SDP fmtp line · c29d81e7
      Olivier Maignial authored 
      === PROBLEM ===

I was trying to record h264 + aac streams from an RTSP server to mp4 file. using this command line:
    ffmpeg -v verbose -y -i "rtsp://<ip>/my_resources" -codec copy -bsf:a aac_adtstoasc test.mp4

FFmpeg then fail to record audio and output this logs:
    [rtsp @ 0xcda1f0] The profile-level-id field size is invalid (40)
    [rtsp @ 0xcda1f0] Error parsing AU headers
    ...
    [rtsp @ 0xcda1f0] Could not find codec parameters for stream 1 (Audio: aac, 48000 Hz, 1 channels): unspecified sample format

In SDP provided by my RTSP server I had this fmtp line:
    a=fmtp:98 streamType=5; profile-level-id=40; mode=AAC-hbr; config=1188; sizeLength=13; indexLength=3; indexDeltaLength=3;

In FFmpeg code, I found a check introduced by commit 24130234. It disallows values greater than 32 for fmtp line parameters.
RFC-4566 (SDP: Session Description Protocol) do not give any limit of size on interger parameters given in an fmtp line.

However, In RFC-6416 (RTP Payload Format for MPEG-4 Audio/Visual Streams) give examples of "profile-level-id" values for AAC, up to 55.

=== FIX ===

As each parameter may have its own min and max values
I propose to introduce a range for each parameter.
For this patch I used RFC-3640 and ISO/IEC 14496-1 as reference for validity ranges.

This patch fix my problem and I now can record my RTSP AAC stream to mp4.
It has passed the full fate tests suite sucessfully.
Signed-off-by: 's avatarOlivier Maignial <olivier.maignial@smile.fr>
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
      c29d81e7
    • Andriy Gelman's avatar
      tools/zmqsend: Avoid mem copy past the end of input buffer · 90e965be
      Andriy Gelman authored 
      This patch avoids a read past the end of the input buffer in memcpy since the size
of the received zmq message is recv_buf_size - 1.
Reviewed-by: 's avatarPaul B Mahol <onemda@gmail.com>
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
      90e965be
  11. 08 Aug, 2019 1 commit