Commit dd5c2fe1 authored by Michael Niedermayer's avatar Michael Niedermayer

avcodec: Read errno before av_log() as the callback from av_log() might affect errno

Signed-off-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
parent 2fc970a6
...@@ -68,10 +68,11 @@ av_cold int ff_xvid_rate_control_init(MpegEncContext *s) ...@@ -68,10 +68,11 @@ av_cold int ff_xvid_rate_control_init(MpegEncContext *s)
(rce->header_bits + rce->mv_bits + 7) / 8); (rce->header_bits + rce->mv_bits + 7) / 8);
if (write(fd, tmp, strlen(tmp)) < 0) { if (write(fd, tmp, strlen(tmp)) < 0) {
int ret = AVERROR(errno);
av_log(NULL, AV_LOG_ERROR, "Error %s writing 2pass logfile\n", strerror(errno)); av_log(NULL, AV_LOG_ERROR, "Error %s writing 2pass logfile\n", strerror(errno));
av_free(tmp_name); av_free(tmp_name);
close(fd); close(fd);
return AVERROR(errno); return ret;
} }
} }
......
...@@ -1664,9 +1664,9 @@ int attribute_align_arg avcodec_open2(AVCodecContext *avctx, const AVCodec *code ...@@ -1664,9 +1664,9 @@ int attribute_align_arg avcodec_open2(AVCodecContext *avctx, const AVCodec *code
#if CONFIG_ICONV #if CONFIG_ICONV
iconv_t cd = iconv_open("UTF-8", avctx->sub_charenc); iconv_t cd = iconv_open("UTF-8", avctx->sub_charenc);
if (cd == (iconv_t)-1) { if (cd == (iconv_t)-1) {
ret = AVERROR(errno);
av_log(avctx, AV_LOG_ERROR, "Unable to open iconv context " av_log(avctx, AV_LOG_ERROR, "Unable to open iconv context "
"with input character encoding \"%s\"\n", avctx->sub_charenc); "with input character encoding \"%s\"\n", avctx->sub_charenc);
ret = AVERROR(errno);
goto free_and_end; goto free_and_end;
} }
iconv_close(cd); iconv_close(cd);
...@@ -2649,10 +2649,10 @@ static int recode_subtitle(AVCodecContext *avctx, ...@@ -2649,10 +2649,10 @@ static int recode_subtitle(AVCodecContext *avctx,
if (iconv(cd, &inb, &inl, &outb, &outl) == (size_t)-1 || if (iconv(cd, &inb, &inl, &outb, &outl) == (size_t)-1 ||
iconv(cd, NULL, NULL, &outb, &outl) == (size_t)-1 || iconv(cd, NULL, NULL, &outb, &outl) == (size_t)-1 ||
outl >= outpkt->size || inl != 0) { outl >= outpkt->size || inl != 0) {
ret = FFMIN(AVERROR(errno), -1);
av_log(avctx, AV_LOG_ERROR, "Unable to recode subtitle event \"%s\" " av_log(avctx, AV_LOG_ERROR, "Unable to recode subtitle event \"%s\" "
"from %s to UTF-8\n", inpkt->data, avctx->sub_charenc); "from %s to UTF-8\n", inpkt->data, avctx->sub_charenc);
av_free_packet(&tmp); av_free_packet(&tmp);
ret = AVERROR(errno);
goto end; goto end;
} }
outpkt->size -= outl; outpkt->size -= outl;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment