Skip to content

F
ffmpeg.wasm-core
Commit d9ebb00d authored by Anton Khirnov's avatar Anton Khirnov
Browse files
Options

svq3: remove a pointless if() 

The H264 context is always uninitialized at this point.
parent 2491f9ee
Hide whitespace changes
Inline Side-by-side
Showing with 120 additions and 122 deletions
libavcodec/svq3.c
View file @ d9ebb00d
...@@ -856,147 +856,145 @@ static av_cold int svq3_decode_init(AVCodecContext *avctx) ...@@ -856,147 +856,145 @@ static av_cold int svq3_decode_init(AVCodecContext *avctx)
h->is_complex = 1; h->is_complex = 1;
avctx->pix_fmt = avctx->codec->pix_fmts[0]; avctx->pix_fmt = avctx->codec->pix_fmts[0];
if (!s->context_initialized) { h->chroma_qp[0] = h->chroma_qp[1] = 4;
h->chroma_qp[0] = h->chroma_qp[1] = 4;
svq3->halfpel_flag = 1;
svq3->halfpel_flag = 1; svq3->thirdpel_flag = 1;
svq3->thirdpel_flag = 1; svq3->unknown_flag = 0;
svq3->unknown_flag = 0;
/* prowl for the "SEQH" marker in the extradata */
/* prowl for the "SEQH" marker in the extradata */ extradata = (unsigned char *)avctx->extradata;
extradata = (unsigned char *)avctx->extradata; extradata_end = avctx->extradata + avctx->extradata_size;
extradata_end = avctx->extradata + avctx->extradata_size; if (extradata) {
if (extradata) { for (m = 0; m + 8 < avctx->extradata_size; m++) {
for (m = 0; m + 8 < avctx->extradata_size; m++) { if (!memcmp(extradata, "SEQH", 4)) {
if (!memcmp(extradata, "SEQH", 4)) { marker_found = 1;
marker_found = 1; break;
break;
}
extradata++;
} }
extradata++;
} }
}
/* if a match was found, parse the extra data */ /* if a match was found, parse the extra data */
if (marker_found) { if (marker_found) {
GetBitContext gb; GetBitContext gb;
int frame_size_code; int frame_size_code;
size = AV_RB32(&extradata[4]); size = AV_RB32(&extradata[4]);
if (size > extradata_end - extradata - 8) if (size > extradata_end - extradata - 8)
return AVERROR_INVALIDDATA; return AVERROR_INVALIDDATA;
init_get_bits(&gb, extradata + 8, size * 8); init_get_bits(&gb, extradata + 8, size * 8);
/* 'frame size code' and optional 'width, height' */ /* 'frame size code' and optional 'width, height' */
frame_size_code = get_bits(&gb, 3); frame_size_code = get_bits(&gb, 3);
switch (frame_size_code) { switch (frame_size_code) {
case 0: case 0:
avctx->width = 160; avctx->width = 160;
avctx->height = 120; avctx->height = 120;
break; break;
case 1: case 1:
avctx->width = 128; avctx->width = 128;
avctx->height = 96; avctx->height = 96;
break; break;
case 2: case 2:
avctx->width = 176; avctx->width = 176;
avctx->height = 144; avctx->height = 144;
break; break;
case 3: case 3:
avctx->width = 352; avctx->width = 352;
avctx->height = 288; avctx->height = 288;
break; break;
case 4: case 4:
avctx->width = 704; avctx->width = 704;
avctx->height = 576; avctx->height = 576;
break; break;
case 5: case 5:
avctx->width = 240; avctx->width = 240;
avctx->height = 180; avctx->height = 180;
break; break;
case 6: case 6:
avctx->width = 320; avctx->width = 320;
avctx->height = 240; avctx->height = 240;
break; break;
case 7: case 7:
avctx->width = get_bits(&gb, 12); avctx->width = get_bits(&gb, 12);
avctx->height = get_bits(&gb, 12); avctx->height = get_bits(&gb, 12);
break; break;
} }
svq3->halfpel_flag = get_bits1(&gb); svq3->halfpel_flag = get_bits1(&gb);
svq3->thirdpel_flag = get_bits1(&gb); svq3->thirdpel_flag = get_bits1(&gb);
/* unknown fields */ /* unknown fields */
skip_bits1(&gb); skip_bits1(&gb);
skip_bits1(&gb); skip_bits1(&gb);
skip_bits1(&gb); skip_bits1(&gb);
skip_bits1(&gb); skip_bits1(&gb);
s->low_delay = get_bits1(&gb); s->low_delay = get_bits1(&gb);
/* unknown field */ /* unknown field */
skip_bits1(&gb); skip_bits1(&gb);
while (get_bits1(&gb)) while (get_bits1(&gb))
skip_bits(&gb, 8); skip_bits(&gb, 8);
svq3->unknown_flag = get_bits1(&gb); svq3->unknown_flag = get_bits1(&gb);
avctx->has_b_frames = !s->low_delay; avctx->has_b_frames = !s->low_delay;
if (svq3->unknown_flag) { if (svq3->unknown_flag) {
#if CONFIG_ZLIB #if CONFIG_ZLIB
unsigned watermark_width = svq3_get_ue_golomb(&gb); unsigned watermark_width = svq3_get_ue_golomb(&gb);
unsigned watermark_height = svq3_get_ue_golomb(&gb); unsigned watermark_height = svq3_get_ue_golomb(&gb);
int u1 = svq3_get_ue_golomb(&gb); int u1 = svq3_get_ue_golomb(&gb);
int u2 = get_bits(&gb, 8); int u2 = get_bits(&gb, 8);
int u3 = get_bits(&gb, 2); int u3 = get_bits(&gb, 2);
int u4 = svq3_get_ue_golomb(&gb); int u4 = svq3_get_ue_golomb(&gb);
unsigned long buf_len = watermark_width * unsigned long buf_len = watermark_width *
watermark_height * 4; watermark_height * 4;
int offset = get_bits_count(&gb) + 7 >> 3; int offset = get_bits_count(&gb) + 7 >> 3;
uint8_t *buf; uint8_t *buf;
if ((uint64_t)watermark_width * 4 > UINT_MAX / watermark_height) if ((uint64_t)watermark_width * 4 > UINT_MAX / watermark_height)
return -1; return -1;
buf = av_malloc(buf_len); buf = av_malloc(buf_len);
av_log(avctx, AV_LOG_DEBUG, "watermark size: %dx%d\n", av_log(avctx, AV_LOG_DEBUG, "watermark size: %dx%d\n",
watermark_width, watermark_height); watermark_width, watermark_height);
av_log(avctx, AV_LOG_DEBUG, av_log(avctx, AV_LOG_DEBUG,
"u1: %x u2: %x u3: %x compressed data size: %d offset: %d\n", "u1: %x u2: %x u3: %x compressed data size: %d offset: %d\n",
u1, u2, u3, u4, offset); u1, u2, u3, u4, offset);
if (uncompress(buf, &buf_len, extradata + 8 + offset, if (uncompress(buf, &buf_len, extradata + 8 + offset,
size - offset) != Z_OK) { size - offset) != Z_OK) {
av_log(avctx, AV_LOG_ERROR,
"could not uncompress watermark logo\n");
av_free(buf);
return -1;
}
svq3->watermark_key = ff_svq1_packet_checksum(buf, buf_len, 0);
svq3->watermark_key = svq3->watermark_key << 16 |
svq3->watermark_key;
av_log(avctx, AV_LOG_DEBUG,
"watermark key %#x\n", svq3->watermark_key);
av_free(buf);
#else
av_log(avctx, AV_LOG_ERROR, av_log(avctx, AV_LOG_ERROR,
"this svq3 file contains watermark which need zlib support compiled in\n"); "could not uncompress watermark logo\n");
av_free(buf);
return -1; return -1;
#endif
} }
svq3->watermark_key = ff_svq1_packet_checksum(buf, buf_len, 0);
svq3->watermark_key = svq3->watermark_key << 16 |
svq3->watermark_key;
av_log(avctx, AV_LOG_DEBUG,
"watermark key %#x\n", svq3->watermark_key);
av_free(buf);
#else
av_log(avctx, AV_LOG_ERROR,
"this svq3 file contains watermark which need zlib support compiled in\n");
return -1;
#endif
} }
}
s->width = avctx->width; s->width = avctx->width;
s->height = avctx->height; s->height = avctx->height;
if (ff_MPV_common_init(s) < 0) if (ff_MPV_common_init(s) < 0)
return -1; return -1;
h->b_stride = 4 * s->mb_width; h->b_stride = 4 * s->mb_width;
if (ff_h264_alloc_tables(h) < 0) { if (ff_h264_alloc_tables(h) < 0) {
av_log(avctx, AV_LOG_ERROR, "svq3 memory allocation failed\n"); av_log(avctx, AV_LOG_ERROR, "svq3 memory allocation failed\n");
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
}
} }
return 0; return 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment