Commit cdafcf83 authored by Michael Niedermayer's avatar Michael Niedermayer

Merge commit '8d617b11'

* commit '8d617b11':
  id3v2: pad the APIC packets as required by lavc.
  dfa: check for invalid access in decode_wdlt().

Conflicts:
	libavformat/id3v2.c
Merged-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
parents ab298937 8d617b11
...@@ -261,6 +261,8 @@ static int decode_wdlt(GetByteContext *gb, uint8_t *frame, int width, int height ...@@ -261,6 +261,8 @@ static int decode_wdlt(GetByteContext *gb, uint8_t *frame, int width, int height
segments = bytestream2_get_le16(gb); segments = bytestream2_get_le16(gb);
} }
line_ptr = frame; line_ptr = frame;
if (frame_end - frame < width)
return AVERROR_INVALIDDATA;
frame += width; frame += width;
y++; y++;
while (segments--) { while (segments--) {
......
...@@ -490,9 +490,9 @@ static void read_apic(AVFormatContext *s, AVIOContext *pb, int taglen, char *tag ...@@ -490,9 +490,9 @@ static void read_apic(AVFormatContext *s, AVIOContext *pb, int taglen, char *tag
} }
apic->buf = av_buffer_alloc(taglen + FF_INPUT_BUFFER_PADDING_SIZE); apic->buf = av_buffer_alloc(taglen + FF_INPUT_BUFFER_PADDING_SIZE);
apic->buf->size -= FF_INPUT_BUFFER_PADDING_SIZE;
if (!apic->buf || !taglen || avio_read(pb, apic->buf->data, taglen) != taglen) if (!apic->buf || !taglen || avio_read(pb, apic->buf->data, taglen) != taglen)
goto fail; goto fail;
memset(apic->buf->data + taglen, 0, FF_INPUT_BUFFER_PADDING_SIZE);
new_extra->tag = "APIC"; new_extra->tag = "APIC";
new_extra->data = apic; new_extra->data = apic;
...@@ -848,7 +848,7 @@ int ff_id3v2_parse_apic(AVFormatContext *s, ID3v2ExtraMeta **extra_meta) ...@@ -848,7 +848,7 @@ int ff_id3v2_parse_apic(AVFormatContext *s, ID3v2ExtraMeta **extra_meta)
av_init_packet(&st->attached_pic); av_init_packet(&st->attached_pic);
st->attached_pic.buf = apic->buf; st->attached_pic.buf = apic->buf;
st->attached_pic.data = apic->buf->data; st->attached_pic.data = apic->buf->data;
st->attached_pic.size = apic->buf->size; st->attached_pic.size = apic->buf->size - FF_INPUT_BUFFER_PADDING_SIZE;
st->attached_pic.stream_index = st->index; st->attached_pic.stream_index = st->index;
st->attached_pic.flags |= AV_PKT_FLAG_KEY; st->attached_pic.flags |= AV_PKT_FLAG_KEY;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment