Commit c8241e73 authored by Mark Thompson's avatar Mark Thompson

vaapi_encode: Refactor initialisation

This allows better checking of capabilities and will make it easier
to add more functionality later.

It also commonises some duplicated code around rate control setup
and adds more comments explaining the internals.

(cherry picked from commit 80a5d051)
parent 06d73d00
This diff is collapsed.
...@@ -48,15 +48,6 @@ enum { ...@@ -48,15 +48,6 @@ enum {
PICTURE_TYPE_B = 3, PICTURE_TYPE_B = 3,
}; };
enum {
// All encode operations are done independently.
ISSUE_MODE_SERIALISE_EVERYTHING = 0,
// Overlap as many operations as possible.
ISSUE_MODE_MAXIMISE_THROUGHPUT,
// Overlap operations only when satisfying parallel dependencies.
ISSUE_MODE_MINIMISE_LATENCY,
};
typedef struct VAAPIEncodeSlice { typedef struct VAAPIEncodeSlice {
void *priv_data; void *priv_data;
void *codec_slice_params; void *codec_slice_params;
...@@ -102,43 +93,65 @@ typedef struct VAAPIEncodeContext { ...@@ -102,43 +93,65 @@ typedef struct VAAPIEncodeContext {
// Codec-specific hooks. // Codec-specific hooks.
const struct VAAPIEncodeType *codec; const struct VAAPIEncodeType *codec;
// Encoding profile (VAProfileXXX).
VAProfile va_profile;
// Encoding entrypoint (usually VAEntryointEncSlice).
VAEntrypoint va_entrypoint;
// Surface colour/sampling format (usually VA_RT_FORMAT_YUV420).
unsigned int va_rt_format;
// Rate control mode.
unsigned int va_rc_mode;
// The required size of surfaces. This is probably the input
// size (AVCodecContext.width|height) aligned up to whatever
// block size is required by the codec.
int surface_width;
int surface_height;
// Everything above this point must be set before calling
// ff_vaapi_encode_init().
// Codec-specific state. // Codec-specific state.
void *priv_data; void *priv_data;
VAProfile va_profile; // Configuration attributes to use when creating va_config.
VAEntrypoint va_entrypoint; VAConfigAttrib config_attributes[MAX_CONFIG_ATTRIBUTES];
int nb_config_attributes;
VAConfigID va_config; VAConfigID va_config;
VAContextID va_context; VAContextID va_context;
int va_rc_mode;
AVBufferRef *device_ref; AVBufferRef *device_ref;
AVHWDeviceContext *device; AVHWDeviceContext *device;
AVVAAPIDeviceContext *hwctx; AVVAAPIDeviceContext *hwctx;
// The hardware frame context containing the input frames.
AVBufferRef *input_frames_ref; AVBufferRef *input_frames_ref;
AVHWFramesContext *input_frames; AVHWFramesContext *input_frames;
// Input size, set from input frames. // The hardware frame context containing the reconstructed frames.
int input_width;
int input_height;
// Aligned size, set by codec init, becomes hwframe size.
int aligned_width;
int aligned_height;
int nb_recon_frames;
AVBufferRef *recon_frames_ref; AVBufferRef *recon_frames_ref;
AVHWFramesContext *recon_frames; AVHWFramesContext *recon_frames;
// Pool of (reusable) bitstream output buffers.
AVBufferPool *output_buffer_pool; AVBufferPool *output_buffer_pool;
VAConfigAttrib config_attributes[MAX_CONFIG_ATTRIBUTES]; // Global parameters which will be applied at the start of the
int nb_config_attributes; // sequence (includes rate control parameters below).
VAEncMiscParameterBuffer *global_params[MAX_GLOBAL_PARAMS]; VAEncMiscParameterBuffer *global_params[MAX_GLOBAL_PARAMS];
size_t global_params_size[MAX_GLOBAL_PARAMS]; size_t global_params_size[MAX_GLOBAL_PARAMS];
int nb_global_params; int nb_global_params;
// Rate control parameters.
struct {
VAEncMiscParameterBuffer misc;
VAEncMiscParameterRateControl rc;
} rc_params;
struct {
VAEncMiscParameterBuffer misc;
VAEncMiscParameterHRD hrd;
} hrd_params;
// Per-sequence parameter structure (VAEncSequenceParameterBuffer*). // Per-sequence parameter structure (VAEncSequenceParameterBuffer*).
void *codec_sequence_params; void *codec_sequence_params;
...@@ -158,7 +171,15 @@ typedef struct VAAPIEncodeContext { ...@@ -158,7 +171,15 @@ typedef struct VAAPIEncodeContext {
// Next output order index (encode order). // Next output order index (encode order).
int64_t output_order; int64_t output_order;
int issue_mode; enum {
// All encode operations are done independently (synchronise
// immediately after every operation).
ISSUE_MODE_SERIALISE_EVERYTHING = 0,
// Overlap as many operations as possible.
ISSUE_MODE_MAXIMISE_THROUGHPUT,
// Overlap operations only when satisfying parallel dependencies.
ISSUE_MODE_MINIMISE_LATENCY,
} issue_mode;
// Timestamp handling. // Timestamp handling.
int64_t first_pts; int64_t first_pts;
...@@ -183,15 +204,20 @@ typedef struct VAAPIEncodeContext { ...@@ -183,15 +204,20 @@ typedef struct VAAPIEncodeContext {
typedef struct VAAPIEncodeType { typedef struct VAAPIEncodeType {
size_t priv_data_size; size_t priv_data_size;
int (*init)(AVCodecContext *avctx); // Perform any extra codec-specific configuration after the
int (*close)(AVCodecContext *avctx); // codec context is initialised (set up the private data and
// add any necessary global parameters).
int (*configure)(AVCodecContext *avctx);
// The size of the parameter structures:
// sizeof(VAEnc{type}ParameterBuffer{codec}).
size_t sequence_params_size; size_t sequence_params_size;
size_t picture_params_size; size_t picture_params_size;
size_t slice_params_size; size_t slice_params_size;
// Fill the parameter structures.
int (*init_sequence_params)(AVCodecContext *avctx); int (*init_sequence_params)(AVCodecContext *avctx);
int (*init_picture_params)(AVCodecContext *avctx, int (*init_picture_params)(AVCodecContext *avctx,
VAAPIEncodePicture *pic); VAAPIEncodePicture *pic);
...@@ -199,10 +225,13 @@ typedef struct VAAPIEncodeType { ...@@ -199,10 +225,13 @@ typedef struct VAAPIEncodeType {
VAAPIEncodePicture *pic, VAAPIEncodePicture *pic,
VAAPIEncodeSlice *slice); VAAPIEncodeSlice *slice);
// The type used by the packed header: this should look like
// VAEncPackedHeader{something}.
int sequence_header_type; int sequence_header_type;
int picture_header_type; int picture_header_type;
int slice_header_type; int slice_header_type;
// Write the packed header data to the provided buffer.
int (*write_sequence_header)(AVCodecContext *avctx, int (*write_sequence_header)(AVCodecContext *avctx,
char *data, size_t *data_len); char *data, size_t *data_len);
int (*write_picture_header)(AVCodecContext *avctx, int (*write_picture_header)(AVCodecContext *avctx,
...@@ -213,10 +242,18 @@ typedef struct VAAPIEncodeType { ...@@ -213,10 +242,18 @@ typedef struct VAAPIEncodeType {
VAAPIEncodeSlice *slice, VAAPIEncodeSlice *slice,
char *data, size_t *data_len); char *data, size_t *data_len);
// Fill an extra parameter structure, which will then be
// passed to vaRenderPicture(). Will be called repeatedly
// with increasing index argument until AVERROR_EOF is
// returned.
int (*write_extra_buffer)(AVCodecContext *avctx, int (*write_extra_buffer)(AVCodecContext *avctx,
VAAPIEncodePicture *pic, VAAPIEncodePicture *pic,
int index, int *type, int index, int *type,
char *data, size_t *data_len); char *data, size_t *data_len);
// Write an extra packed header. Will be called repeatedly
// with increasing index argument until AVERROR_EOF is
// returned.
int (*write_extra_header)(AVCodecContext *avctx, int (*write_extra_header)(AVCodecContext *avctx,
VAAPIEncodePicture *pic, VAAPIEncodePicture *pic,
int index, int *type, int index, int *type,
...@@ -227,8 +264,7 @@ typedef struct VAAPIEncodeType { ...@@ -227,8 +264,7 @@ typedef struct VAAPIEncodeType {
int ff_vaapi_encode2(AVCodecContext *avctx, AVPacket *pkt, int ff_vaapi_encode2(AVCodecContext *avctx, AVPacket *pkt,
const AVFrame *input_image, int *got_packet); const AVFrame *input_image, int *got_packet);
int ff_vaapi_encode_init(AVCodecContext *avctx, int ff_vaapi_encode_init(AVCodecContext *avctx);
const VAAPIEncodeType *type);
int ff_vaapi_encode_close(AVCodecContext *avctx); int ff_vaapi_encode_close(AVCodecContext *avctx);
#endif /* AVCODEC_VAAPI_ENCODE_H */ #endif /* AVCODEC_VAAPI_ENCODE_H */
This diff is collapsed.
This diff is collapsed.
...@@ -277,8 +277,8 @@ static int vaapi_encode_mjpeg_init_picture_params(AVCodecContext *avctx, ...@@ -277,8 +277,8 @@ static int vaapi_encode_mjpeg_init_picture_params(AVCodecContext *avctx,
vpic->reconstructed_picture = pic->recon_surface; vpic->reconstructed_picture = pic->recon_surface;
vpic->coded_buf = pic->output_buffer; vpic->coded_buf = pic->output_buffer;
vpic->picture_width = ctx->input_width; vpic->picture_width = avctx->width;
vpic->picture_height = ctx->input_height; vpic->picture_height = avctx->height;
vpic->pic_flags.bits.profile = 0; vpic->pic_flags.bits.profile = 0;
vpic->pic_flags.bits.progressive = 0; vpic->pic_flags.bits.progressive = 0;
...@@ -333,31 +333,10 @@ static int vaapi_encode_mjpeg_init_slice_params(AVCodecContext *avctx, ...@@ -333,31 +333,10 @@ static int vaapi_encode_mjpeg_init_slice_params(AVCodecContext *avctx,
return 0; return 0;
} }
static av_cold int vaapi_encode_mjpeg_init_internal(AVCodecContext *avctx) static av_cold int vaapi_encode_mjpeg_configure(AVCodecContext *avctx)
{ {
static const VAConfigAttrib default_config_attributes[] = {
{ .type = VAConfigAttribRTFormat,
.value = VA_RT_FORMAT_YUV420 },
{ .type = VAConfigAttribEncPackedHeaders,
.value = VA_ENC_PACKED_HEADER_SEQUENCE },
};
VAAPIEncodeContext *ctx = avctx->priv_data; VAAPIEncodeContext *ctx = avctx->priv_data;
VAAPIEncodeMJPEGContext *priv = ctx->priv_data; VAAPIEncodeMJPEGContext *priv = ctx->priv_data;
int i;
ctx->va_profile = VAProfileJPEGBaseline;
ctx->va_entrypoint = VAEntrypointEncPicture;
ctx->input_width = avctx->width;
ctx->input_height = avctx->height;
ctx->aligned_width = FFALIGN(ctx->input_width, 8);
ctx->aligned_height = FFALIGN(ctx->input_height, 8);
for (i = 0; i < FF_ARRAY_ELEMS(default_config_attributes); i++) {
ctx->config_attributes[ctx->nb_config_attributes++] =
default_config_attributes[i];
}
priv->quality = avctx->global_quality; priv->quality = avctx->global_quality;
if (priv->quality < 1 || priv->quality > 100) { if (priv->quality < 1 || priv->quality > 100) {
...@@ -374,7 +353,7 @@ static av_cold int vaapi_encode_mjpeg_init_internal(AVCodecContext *avctx) ...@@ -374,7 +353,7 @@ static av_cold int vaapi_encode_mjpeg_init_internal(AVCodecContext *avctx)
static VAAPIEncodeType vaapi_encode_type_mjpeg = { static VAAPIEncodeType vaapi_encode_type_mjpeg = {
.priv_data_size = sizeof(VAAPIEncodeMJPEGContext), .priv_data_size = sizeof(VAAPIEncodeMJPEGContext),
.init = &vaapi_encode_mjpeg_init_internal, .configure = &vaapi_encode_mjpeg_configure,
.picture_params_size = sizeof(VAEncPictureParameterBufferJPEG), .picture_params_size = sizeof(VAEncPictureParameterBufferJPEG),
.init_picture_params = &vaapi_encode_mjpeg_init_picture_params, .init_picture_params = &vaapi_encode_mjpeg_init_picture_params,
...@@ -390,7 +369,21 @@ static VAAPIEncodeType vaapi_encode_type_mjpeg = { ...@@ -390,7 +369,21 @@ static VAAPIEncodeType vaapi_encode_type_mjpeg = {
static av_cold int vaapi_encode_mjpeg_init(AVCodecContext *avctx) static av_cold int vaapi_encode_mjpeg_init(AVCodecContext *avctx)
{ {
return ff_vaapi_encode_init(avctx, &vaapi_encode_type_mjpeg); VAAPIEncodeContext *ctx = avctx->priv_data;
ctx->codec = &vaapi_encode_type_mjpeg;
ctx->va_profile = VAProfileJPEGBaseline;
ctx->va_entrypoint = VAEntrypointEncPicture;
ctx->va_rt_format = VA_RT_FORMAT_YUV420;
ctx->va_rc_mode = VA_RC_CQP;
ctx->surface_width = FFALIGN(avctx->width, 8);
ctx->surface_height = FFALIGN(avctx->height, 8);
return ff_vaapi_encode_init(avctx);
} }
static const AVCodecDefault vaapi_encode_mjpeg_defaults[] = { static const AVCodecDefault vaapi_encode_mjpeg_defaults[] = {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment