Commit bf238a6a authored by Jun Zhao's avatar Jun Zhao Committed by Mark Thompson

vf_hwupload: Add missing return value check

Add missing return value checks to suppress build warning and
remove noop ff_formats_unref() calling.

Note: most filters using ff_formats_ref() didn't have a suitable
error handling, it's a potential memory leak issue.
Signed-off-by: 's avatarJun Zhao <jun.zhao@intel.com>
Signed-off-by: 's avatarMark Thompson <sw@jkqxz.net>
parent ff17c76e
......@@ -74,17 +74,15 @@ static int hwupload_query_formats(AVFilterContext *avctx)
if (input_pix_fmts) {
for (i = 0; input_pix_fmts[i] != AV_PIX_FMT_NONE; i++) {
err = ff_add_format(&input_formats, input_pix_fmts[i]);
if (err < 0) {
ff_formats_unref(&input_formats);
if (err < 0)
goto fail;
}
}
}
ff_formats_ref(input_formats, &avctx->inputs[0]->out_formats);
ff_formats_ref(ff_make_format_list(output_pix_fmts),
&avctx->outputs[0]->in_formats);
if ((err = ff_formats_ref(input_formats, &avctx->inputs[0]->out_formats)) < 0 ||
(err = ff_formats_ref(ff_make_format_list(output_pix_fmts),
&avctx->outputs[0]->in_formats)) < 0)
goto fail;
av_hwframe_constraints_free(&constraints);
return 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment