Commit b021eba8 authored by Michael Niedermayer's avatar Michael Niedermayer

avcodec/apedec: Fix undefined integer overflow with 24bit

Fixes: signed integer overflow: 8683744 * 256 cannot be represented in type 'int'
Fixes: 23527/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5679885932822528

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 9f7b252cdf2d0e0f79d16dc7cd575d1884239863)
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
parent 093c2dd6
...@@ -1573,7 +1573,7 @@ static int ape_decode_frame(AVCodecContext *avctx, void *data, ...@@ -1573,7 +1573,7 @@ static int ape_decode_frame(AVCodecContext *avctx, void *data,
for (ch = 0; ch < s->channels; ch++) { for (ch = 0; ch < s->channels; ch++) {
sample24 = (int32_t *)frame->data[ch]; sample24 = (int32_t *)frame->data[ch];
for (i = 0; i < blockstodecode; i++) for (i = 0; i < blockstodecode; i++)
*sample24++ = s->decoded[ch][i] * 256; *sample24++ = s->decoded[ch][i] * 256U;
} }
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment