Commit a3a85721 authored by Justin Ruggles's avatar Justin Ruggles

g722dec: check output buffer size before decoding

parent 4e419737
...@@ -85,11 +85,17 @@ static int g722_decode_frame(AVCodecContext *avctx, void *data, ...@@ -85,11 +85,17 @@ static int g722_decode_frame(AVCodecContext *avctx, void *data,
{ {
G722Context *c = avctx->priv_data; G722Context *c = avctx->priv_data;
int16_t *out_buf = data; int16_t *out_buf = data;
int j, out_len = 0; int j, out_len;
const int skip = 8 - avctx->bits_per_coded_sample; const int skip = 8 - avctx->bits_per_coded_sample;
const int16_t *quantizer_table = low_inv_quants[skip]; const int16_t *quantizer_table = low_inv_quants[skip];
GetBitContext gb; GetBitContext gb;
out_len = avpkt->size * 2 * av_get_bytes_per_sample(avctx->sample_fmt);
if (*data_size < out_len) {
av_log(avctx, AV_LOG_ERROR, "Output buffer is too small\n");
return AVERROR(EINVAL);
}
init_get_bits(&gb, avpkt->data, avpkt->size * 8); init_get_bits(&gb, avpkt->data, avpkt->size * 8);
for (j = 0; j < avpkt->size; j++) { for (j = 0; j < avpkt->size; j++) {
...@@ -114,15 +120,15 @@ static int g722_decode_frame(AVCodecContext *avctx, void *data, ...@@ -114,15 +120,15 @@ static int g722_decode_frame(AVCodecContext *avctx, void *data,
c->prev_samples[c->prev_samples_pos++] = rlow - rhigh; c->prev_samples[c->prev_samples_pos++] = rlow - rhigh;
ff_g722_apply_qmf(c->prev_samples + c->prev_samples_pos - 24, ff_g722_apply_qmf(c->prev_samples + c->prev_samples_pos - 24,
&xout1, &xout2); &xout1, &xout2);
out_buf[out_len++] = av_clip_int16(xout1 >> 12); *out_buf++ = av_clip_int16(xout1 >> 12);
out_buf[out_len++] = av_clip_int16(xout2 >> 12); *out_buf++ = av_clip_int16(xout2 >> 12);
if (c->prev_samples_pos >= PREV_SAMPLES_BUF_SIZE) { if (c->prev_samples_pos >= PREV_SAMPLES_BUF_SIZE) {
memmove(c->prev_samples, c->prev_samples + c->prev_samples_pos - 22, memmove(c->prev_samples, c->prev_samples + c->prev_samples_pos - 22,
22 * sizeof(c->prev_samples[0])); 22 * sizeof(c->prev_samples[0]));
c->prev_samples_pos = 22; c->prev_samples_pos = 22;
} }
} }
*data_size = out_len << 1; *data_size = out_len;
return avpkt->size; return avpkt->size;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment