Commit 97c00eda authored by Michael Niedermayer's avatar Michael Niedermayer

avcodec/mlpdsp: Fix signed integer overflow, 2nd try

The outputted bits should match what is used in the lossless check

Fixes: runtime error: signed integer overflow: -538697856 * 256 cannot be represented in type 'int'
Fixes: 4326/clusterfuzz-testcase-minimized-5689449645080576

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
parent 883de7e8
...@@ -117,7 +117,7 @@ int32_t ff_mlp_pack_output(int32_t lossless_check_data, ...@@ -117,7 +117,7 @@ int32_t ff_mlp_pack_output(int32_t lossless_check_data,
(1U << output_shift[mat_ch]); (1U << output_shift[mat_ch]);
lossless_check_data ^= (sample & 0xffffff) << mat_ch; lossless_check_data ^= (sample & 0xffffff) << mat_ch;
if (is32) if (is32)
*data_32++ = sample * 256; *data_32++ = sample * 256U;
else else
*data_16++ = sample >> 8; *data_16++ = sample >> 8;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment