Commit 845bb401 authored by Ronald S. Bultje's avatar Ronald S. Bultje

http: move chunk handling from http_read_stream() to http_buf_read().

parent 2a05c8f8
...@@ -1168,6 +1168,34 @@ static int http_buf_read(URLContext *h, uint8_t *buf, int size) ...@@ -1168,6 +1168,34 @@ static int http_buf_read(URLContext *h, uint8_t *buf, int size)
{ {
HTTPContext *s = h->priv_data; HTTPContext *s = h->priv_data;
int len; int len;
if (s->chunksize != UINT64_MAX) {
if (!s->chunksize) {
char line[32];
int err;
do {
if ((err = http_get_line(s, line, sizeof(line))) < 0)
return err;
} while (!*line); /* skip CR LF from last chunk */
s->chunksize = strtoull(line, NULL, 16);
av_log(h, AV_LOG_TRACE,
"Chunked encoding data size: %"PRIu64"'\n",
s->chunksize);
if (!s->chunksize)
return 0;
else if (s->chunksize == UINT64_MAX) {
av_log(h, AV_LOG_ERROR, "Invalid chunk size %"PRIu64"\n",
s->chunksize);
return AVERROR(EINVAL);
}
}
size = FFMIN(size, s->chunksize);
}
/* read bytes from input buffer first */ /* read bytes from input buffer first */
len = s->buf_end - s->buf_ptr; len = s->buf_end - s->buf_ptr;
if (len > 0) { if (len > 0) {
...@@ -1190,8 +1218,10 @@ static int http_buf_read(URLContext *h, uint8_t *buf, int size) ...@@ -1190,8 +1218,10 @@ static int http_buf_read(URLContext *h, uint8_t *buf, int size)
} }
if (len > 0) { if (len > 0) {
s->off += len; s->off += len;
if (s->chunksize > 0) if (s->chunksize > 0) {
av_assert0(s->chunksize >= len);
s->chunksize -= len; s->chunksize -= len;
}
} }
return len; return len;
} }
...@@ -1246,31 +1276,6 @@ static int http_read_stream(URLContext *h, uint8_t *buf, int size) ...@@ -1246,31 +1276,6 @@ static int http_read_stream(URLContext *h, uint8_t *buf, int size)
return err; return err;
} }
if (s->chunksize != UINT64_MAX) {
if (!s->chunksize) {
char line[32];
do {
if ((err = http_get_line(s, line, sizeof(line))) < 0)
return err;
} while (!*line); /* skip CR LF from last chunk */
s->chunksize = strtoull(line, NULL, 16);
av_log(h, AV_LOG_TRACE,
"Chunked encoding data size: %"PRIu64"'\n",
s->chunksize);
if (!s->chunksize)
return 0;
else if (s->chunksize == UINT64_MAX) {
av_log(h, AV_LOG_ERROR, "Invalid chunk size %"PRIu64"\n",
s->chunksize);
return AVERROR(EINVAL);
}
}
size = FFMIN(size, s->chunksize);
}
#if CONFIG_ZLIB #if CONFIG_ZLIB
if (s->compressed) if (s->compressed)
return http_buf_read_compressed(h, buf, size); return http_buf_read_compressed(h, buf, size);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment