Commit 84556ef0 authored by Gyan Doshi's avatar Gyan Doshi Committed by Michael Niedermayer

lavu/timecode: clarify error msg for timecode_rate

The user-supplied value for timecode_rate in drawtext is rounded
to nearest integer. So, a supplied value of 0.49 or lower is rounded to 0.
This throws a misleading error message which says "Timecode frame rate must be
specified". Changed message to account for values under one.

Also noted supported framerates for drop TC.
Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
parent 1b323c3f
...@@ -7365,7 +7365,9 @@ format. It can be used with or without text parameter. @var{timecode_rate} ...@@ -7365,7 +7365,9 @@ format. It can be used with or without text parameter. @var{timecode_rate}
option must be specified. option must be specified.
@item timecode_rate, rate, r @item timecode_rate, rate, r
Set the timecode frame rate (timecode only). Set the timecode frame rate (timecode only). Value will be rounded to nearest
integer. Minimum value is "1".
Drop-frame timecode is supported for frame rates 30 & 60.
@item tc24hmax @item tc24hmax
If set to 1, the output of the timecode option will wrap around at 24 hours. If set to 1, the output of the timecode option will wrap around at 24 hours.
......
...@@ -155,7 +155,7 @@ static int check_fps(int fps) ...@@ -155,7 +155,7 @@ static int check_fps(int fps)
static int check_timecode(void *log_ctx, AVTimecode *tc) static int check_timecode(void *log_ctx, AVTimecode *tc)
{ {
if ((int)tc->fps <= 0) { if ((int)tc->fps <= 0) {
av_log(log_ctx, AV_LOG_ERROR, "Timecode frame rate must be specified\n"); av_log(log_ctx, AV_LOG_ERROR, "Valid timecode frame rate must be specified. Minimum value is 1\n");
return AVERROR(EINVAL); return AVERROR(EINVAL);
} }
if ((tc->flags & AV_TIMECODE_FLAG_DROPFRAME) && tc->fps != 30 && tc->fps != 60) { if ((tc->flags & AV_TIMECODE_FLAG_DROPFRAME) && tc->fps != 30 && tc->fps != 60) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment