Commit 7fdebb11 authored by Clément Bœsch's avatar Clément Bœsch

lavfi/astreamsync: switch to an AVOptions-based system.

parent 2fb8ca7d
...@@ -999,7 +999,11 @@ will create 5 copies of the input audio. ...@@ -999,7 +999,11 @@ will create 5 copies of the input audio.
Forward two audio streams and control the order the buffers are forwarded. Forward two audio streams and control the order the buffers are forwarded.
The argument to the filter is an expression deciding which stream should be The filter accepts the following options:
@table @option
@item expr, e
Set the expression deciding which stream should be
forwarded next: if the result is negative, the first stream is forwarded; if forwarded next: if the result is negative, the first stream is forwarded; if
the result is positive or zero, the second stream is forwarded. It can use the result is positive or zero, the second stream is forwarded. It can use
the following variables: the following variables:
...@@ -1015,8 +1019,11 @@ current timestamp of each stream ...@@ -1015,8 +1019,11 @@ current timestamp of each stream
The default value is @code{t1-t2}, which means to always forward the stream The default value is @code{t1-t2}, which means to always forward the stream
that has a smaller timestamp. that has a smaller timestamp.
@end table
@subsection Examples
Example: stress-test @code{amerge} by randomly sending buffers on the wrong Stress-test @code{amerge} by randomly sending buffers on the wrong
input, while avoiding too much of a desynchronization: input, while avoiding too much of a desynchronization:
@example @example
amovie=file.ogg [a] ; amovie=file.mp3 [b] ; amovie=file.ogg [a] ; amovie=file.mp3 [b] ;
......
...@@ -24,6 +24,7 @@ ...@@ -24,6 +24,7 @@
*/ */
#include "libavutil/eval.h" #include "libavutil/eval.h"
#include "libavutil/opt.h"
#include "avfilter.h" #include "avfilter.h"
#include "audio.h" #include "audio.h"
#include "internal.h" #include "internal.h"
...@@ -45,7 +46,9 @@ enum var_name { ...@@ -45,7 +46,9 @@ enum var_name {
}; };
typedef struct { typedef struct {
const AVClass *class;
AVExpr *expr; AVExpr *expr;
char *expr_str;
double var_values[VAR_NB]; double var_values[VAR_NB];
struct buf_queue { struct buf_queue {
AVFrame *buf[QUEUE_SIZE]; AVFrame *buf[QUEUE_SIZE];
...@@ -58,18 +61,25 @@ typedef struct { ...@@ -58,18 +61,25 @@ typedef struct {
int eof; /* bitmask, one bit for each stream */ int eof; /* bitmask, one bit for each stream */
} AStreamSyncContext; } AStreamSyncContext;
static const char *default_expr = "t1-t2"; #define OFFSET(x) offsetof(AStreamSyncContext, x)
#define FLAGS AV_OPT_FLAG_AUDIO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
static const AVOption astreamsync_options[] = {
{ "expr", "set stream selection expression", OFFSET(expr_str), AV_OPT_TYPE_STRING, { .str = "t1-t2" }, .flags = FLAGS },
{ "e", "set stream selection expression", OFFSET(expr_str), AV_OPT_TYPE_STRING, { .str = "t1-t2" }, .flags = FLAGS },
{ NULL }
};
AVFILTER_DEFINE_CLASS(astreamsync);
static av_cold int init(AVFilterContext *ctx, const char *args0) static av_cold int init(AVFilterContext *ctx, const char *args0)
{ {
AStreamSyncContext *as = ctx->priv; AStreamSyncContext *as = ctx->priv;
const char *expr = args0 ? args0 : default_expr;
int r, i; int r, i;
r = av_expr_parse(&as->expr, expr, var_names, r = av_expr_parse(&as->expr, as->expr_str, var_names,
NULL, NULL, NULL, NULL, 0, ctx); NULL, NULL, NULL, NULL, 0, ctx);
if (r < 0) { if (r < 0) {
av_log(ctx, AV_LOG_ERROR, "Error in expression \"%s\"\n", expr); av_log(ctx, AV_LOG_ERROR, "Error in expression \"%s\"\n", as->expr_str);
return r; return r;
} }
for (i = 0; i < 42; i++) for (i = 0; i < 42; i++)
...@@ -226,4 +236,5 @@ AVFilter avfilter_af_astreamsync = { ...@@ -226,4 +236,5 @@ AVFilter avfilter_af_astreamsync = {
.query_formats = query_formats, .query_formats = query_formats,
.inputs = astreamsync_inputs, .inputs = astreamsync_inputs,
.outputs = astreamsync_outputs, .outputs = astreamsync_outputs,
.priv_class = &astreamsync_class,
}; };
...@@ -679,7 +679,6 @@ static const char *const filters_left_to_update[] = { ...@@ -679,7 +679,6 @@ static const char *const filters_left_to_update[] = {
"anullsrc", "anullsrc",
"aresample", "aresample",
"asetnsamples", "asetnsamples",
"astreamsync",
"atempo", "atempo",
"bbox", "bbox",
"buffer", "buffer",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment