* DV handling was streamlined for both muxing/demuxing and

     decoding. All muxing/demuxing functionality is now available
     in libavformat/dv.[ch].

   * dv1394.c and avidec.c were hooked up with general DV demuxer.

   * DVAUDIO is dead! Long live pcm_s16le!

   * DV audio is now always recognized -- which means we can
     now hear all those ducks quaking in pond.dv.

Originally committed as revision 2319 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavcodec/allcodecs.c

@@ -103,7 +103,6 @@ void avcodec_register_all(void)
     register_avcodec(&mpeg_xvmc_decoder);
 #endif
     register_avcodec(&dvvideo_decoder);
-    register_avcodec(&dvaudio_decoder);
     register_avcodec(&mjpeg_decoder);
     register_avcodec(&mjpegb_decoder);
     register_avcodec(&mp2_decoder);

libavcodec/avcodec.h

@@ -1388,7 +1388,6 @@ extern AVCodec rv10_decoder;
 extern AVCodec svq1_decoder;
 extern AVCodec svq3_decoder;
 extern AVCodec dvvideo_decoder;
-extern AVCodec dvaudio_decoder;
 extern AVCodec wmav1_decoder;
 extern AVCodec wmav2_decoder;
 extern AVCodec mjpeg_decoder;

libavcodec/dvdata.h

@@ -22,10 +22,33 @@
  * Constants for DV codec.
  */
 
+/* 
+ * DVprofile is used to express the differences between various 
+ * DV flavors. For now it's primarily used for differentiating
+ * 525/60 and 625/50, but the plans are to use it for various
+ * DV specs as well (e.g. SMPTE314M vs. IEC 61834).
+ */
+typedef struct DVprofile {
+    int              dsf;                 /* value of the dsf in the DV header */
+    int              frame_size;          /* total size of one frame in bytes */
+    int              difseg_size;         /* number of DIF segments */
+    int              frame_rate;      
+    int              frame_rate_base;
+    int              ltc_divisor;         /* FPS from the LTS standpoint */
+    int              height;              /* picture height in pixels */
+    int              width;               /* picture width in pixels */
+    const uint16_t  *video_place;         /* positions of all DV macro blocks */
+    enum PixelFormat pix_fmt;             /* picture pixel format */
+    
+    int              audio_stride;        /* size of audio_shuffle table */
+    int              audio_min_samples[3];/* min ammount of audio samples */
+                                          /* for 48Khz, 44.1Khz and 32Khz */
+    int              audio_samples_dist[5];/* how many samples are supposed to be */
+                                         /* in each frame in a 5 frames window */
+    const uint16_t (*audio_shuffle)[9];  /* PCM shuffling table */
+} DVprofile;
+
 #define NB_DV_VLC 409
-#define AAUX_AS_OFFSET  (80*6 + 80*16*3 + 3)
-#define AAUX_ASC_OFFSET (80*6 + 80*16*4 + 3)
-#define VAUX_TC61_OFFSET (80*5 + 48 + 5)
 
 static const uint16_t dv_vlc_bits[409] = {
  0x0000, 0x0002, 0x0007, 0x0008, 0x0009, 0x0014, 0x0015, 0x0016,
@@ -283,7 +306,7 @@ static const uint8_t dv_248_areas[64] = {
     1,2,2,3,3,3,3,3,
 };
 
-static uint8_t dv_quant_shifts[22][4] = {
+static const uint8_t dv_quant_shifts[22][4] = {
   { 3,3,4,4 }, 
   { 3,3,4,4 }, 
   { 2,3,3,4 }, 
@@ -1240,7 +1263,7 @@ static const uint16_t dv_place_411[1350] = {
  0x0834, 0x2320, 0x2f44, 0x3810, 0x1658,
 };
 
-static const uint16_t dv_place_audio60[10][9] = {
+static const uint16_t dv_audio_shuffle525[10][9] = {
   {  0, 30, 60, 20, 50, 80, 10, 40, 70 }, /* 1st channel */
   {  6, 36, 66, 26, 56, 86, 16, 46, 76 },
   { 12, 42, 72,  2, 32, 62, 22, 52, 82 },
@@ -1254,7 +1277,7 @@ static const uint16_t dv_place_audio60[10][9] = {
   { 25, 55, 85, 15, 45, 75,  5, 35, 65 },
 };
 
-static const uint16_t dv_place_audio50[12][9] = {
+static const uint16_t dv_audio_shuffle625[12][9] = {
   {   0,  36,  72,  26,  62,  98,  16,  52,  88}, /* 1st channel */
   {   6,  42,  78,  32,  68, 104,  22,  58,  94},
   {  12,  48,  84,   2,  38,  74,  28,  64, 100},
@@ -1274,7 +1297,74 @@ static const int dv_audio_frequency[3] = {
     48000, 44100, 32000,
 };
     
-static const int dv_audio_min_samples[2][3] = {
-    { 1580, 1452, 1053 }, /* 60 fields */
-    { 1896, 1742, 1264 }, /* 50 fileds */
+static const DVprofile dv_profiles[] = {
+    { .dsf = 0,
+      .frame_size = 120000,        /* IEC 61834, SMPTE-314M - 525/60 (NTSC) */
+      .difseg_size = 10,
+      .frame_rate = 30000,
+      .ltc_divisor = 30,
+      .frame_rate_base = 1001,
+      .height = 480,
+      .width = 720,
+      .video_place = dv_place_411,
+      .pix_fmt = PIX_FMT_YUV411P,
+      .audio_stride = 90,
+      .audio_min_samples = { 1580, 1452, 1053 }, /* for 48, 44.1 and 32Khz */
+      .audio_samples_dist = { 1602, 1601, 1602, 1601, 1602 },
+      .audio_shuffle = dv_audio_shuffle525,
+    }, 
+    { .dsf = 1,
+      .frame_size = 144000,        /* IEC 61834 - 625/50 (PAL) */
+      .difseg_size = 12,
+      .frame_rate = 25,
+      .frame_rate_base = 1,
+      .ltc_divisor = 25,
+      .height = 576,
+      .width = 720,
+      .video_place = dv_place_420,
+      .pix_fmt = PIX_FMT_YUV420P,
+      .audio_stride = 108,
+      .audio_min_samples = { 1896, 1742, 1264 }, /* for 48, 44.1 and 32Khz */
+      .audio_samples_dist = { 1920, 1920, 1920, 1920, 1920 },
+      .audio_shuffle = dv_audio_shuffle625,
+    },
+    { .dsf = 1,
+      .frame_size = 144000,        /* SMPTE-314M - 625/50 (PAL) */
+      .difseg_size = 12,
+      .frame_rate = 25,
+      .frame_rate_base = 1,
+      .ltc_divisor = 25,
+      .height = 576,
+      .width = 720,
+      .video_place = dv_place_411P,
+      .pix_fmt = PIX_FMT_YUV411P,
+      .audio_stride = 108,
+      .audio_min_samples = { 1896, 1742, 1264 }, /* for 48, 44.1 and 32Khz */
+      .audio_samples_dist = { 1920, 1920, 1920, 1920, 1920 },
+      .audio_shuffle = dv_audio_shuffle625,
+     }
 };
+
+static inline const DVprofile* dv_frame_profile(uint8_t* frame)
+{
+    if ((frame[3] & 0x80) == 0) {      /* DSF flag */
+        return &dv_profiles[0];
+    }
+    else if ((frame[5] & 0x07) == 0) { /* APT flag */
+        return &dv_profiles[1];
+    }
+    else 
+        return &dv_profiles[2];
+}
+
+static inline const DVprofile* dv_codec_profile(AVCodecContext* codec)
+{
+    if (codec->width != 720) {
+        return NULL;
+    } 
+    else if (codec->height == 480) {
+        return &dv_profiles[0];
+    } 
+    else 
+        return &dv_profiles[1];
+}

libavformat/Makefile

@@ -13,7 +13,7 @@ PPOBJS=
 
 # mux and demuxes
 OBJS+=mpeg.o mpegts.o mpegtsenc.o ffm.o crc.o img.o raw.o rm.o \
-      avienc.o avidec.o wav.o swf.o au.o gif.o mov.o mpjpeg.o dvcore.o dv.o \
+      avienc.o avidec.o wav.o swf.o au.o gif.o mov.o mpjpeg.o dv.o \
       yuv4mpeg.o 4xm.o flvenc.o flvdec.o movenc.o psxstr.o idroq.o ipmovie.o \
       nut.o wc3movie.o mp3.o
 

libavformat/avidec.c

@@ -18,21 +18,10 @@
  */
 #include "avformat.h"
 #include "avi.h"
+#include "dv.h"
 
 //#define DEBUG
 
-static const struct AVI1Handler {
-   enum CodecID vcid;
-   enum CodecID acid;
-   uint32_t tag;
-} AVI1Handlers[] = {
-  { CODEC_ID_DVVIDEO, CODEC_ID_DVAUDIO, MKTAG('d', 'v', 's', 'd') },
-  { CODEC_ID_DVVIDEO, CODEC_ID_DVAUDIO, MKTAG('d', 'v', 'h', 'd') },
-  { CODEC_ID_DVVIDEO, CODEC_ID_DVAUDIO, MKTAG('d', 'v', 's', 'l') },
-  /* This is supposed to be the last one */
-  { CODEC_ID_NONE, CODEC_ID_NONE, 0 },
-};
-
 typedef struct AVIIndex {
     unsigned char tag[4];
     unsigned int flags, pos, len;
@@ -42,12 +31,9 @@ typedef struct AVIIndex {
 typedef struct {
     int64_t  riff_end;
     int64_t  movi_end;
-    int     type;
-    uint8_t *buf;
-    int      buf_size;
-    int      stream_index;
     offset_t movi_list;
     AVIIndex *first, *last;
+    void* dv_demux;
 } AVIContext;
 
 #ifdef DEBUG
@@ -97,11 +83,6 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
     stream_index = -1;
     codec_type = -1;
     frame_period = 0;
-    avi->type = 2;
-    avi->buf = av_malloc(1);
-    if (!avi->buf)
-        return -1;
-    avi->buf_size = 1;
     for(;;) {
         if (url_feof(pb))
             goto fail;
@@ -134,7 +115,7 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
 	    url_fskip(pb, 4 * 4);
             n = get_le32(pb);
             for(i=0;i<n;i++) {
-                st = av_new_stream(s, 0);
+                st = av_new_stream(s, i);
                 if (!st)
                     goto fail;
 	    }
@@ -144,24 +125,36 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
             /* stream header */
             stream_index++;
             tag1 = get_le32(pb);
+            handler = get_le32(pb); /* codec tag */
             switch(tag1) {
             case MKTAG('i', 'a', 'v', 's'):
 	    case MKTAG('i', 'v', 'a', 's'):
+                /* 
+	         * After some consideration -- I don't think we 
+	         * have to support anything but DV in a type1 AVIs.
+	         */
 	        if (s->nb_streams != 1)
 		    goto fail;
-		avi->type = 1;
-		avi->stream_index = 0;
+	        
+		if (handler != MKTAG('d', 'v', 's', 'd') &&
+	            handler != MKTAG('d', 'v', 'h', 'd') &&
+		    handler != MKTAG('d', 'v', 's', 'l'))
+	           goto fail;
+
+	        avi->dv_demux = dv_init_demux(s, stream_index, stream_index + 1);
+		if (!avi->dv_demux)
+		    goto fail;
+	        stream_index++;
 	    case MKTAG('v', 'i', 'd', 's'):
                 codec_type = CODEC_TYPE_VIDEO;
 
                 if (stream_index >= s->nb_streams) {
-                    url_fskip(pb, size - 4);
+                    url_fskip(pb, size - 8);
                     break;
                 } 
 
                 st = s->streams[stream_index];
 
-                handler = get_le32(pb); /* codec tag */
                 get_le32(pb); /* flags */
                 get_le16(pb); /* priority */
                 get_le16(pb); /* language */
@@ -186,29 +179,6 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
                     st->codec.frame_rate_base * AV_TIME_BASE / 
                     st->codec.frame_rate;
                 
-                if (avi->type == 1) {
-                    AVStream *st;
-
-                    st = av_new_stream(s, 0);
-                    if (!st)
-		        goto fail;
-                    
-		    stream_index++;
-		    
-		    for (i=0; AVI1Handlers[i].tag != 0; ++i)
-		       if (AVI1Handlers[i].tag == handler)
-		           break;
-
-		    if (AVI1Handlers[i].tag != 0) {
-		        s->streams[0]->codec.codec_type = CODEC_TYPE_VIDEO;
-                        s->streams[0]->codec.codec_id   = AVI1Handlers[i].vcid;
-		        s->streams[1]->codec.codec_type = CODEC_TYPE_AUDIO;
-                        s->streams[1]->codec.codec_id   = AVI1Handlers[i].acid;
-		    } else {
-		        goto fail;
-                    }
-		}
-		
 		url_fskip(pb, size - 9 * 4);
                 break;
             case MKTAG('a', 'u', 'd', 's'):
@@ -218,12 +188,11 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
                     codec_type = CODEC_TYPE_AUDIO;
 
                     if (stream_index >= s->nb_streams) {
-                        url_fskip(pb, size - 4);
+                        url_fskip(pb, size - 8);
                         break;
                     } 
                     st = s->streams[stream_index];
 
-                    get_le32(pb); /* tag */
                     get_le32(pb); /* flags */
                     get_le16(pb); /* priority */
                     get_le16(pb); /* language */
@@ -244,7 +213,7 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
             break;
         case MKTAG('s', 't', 'r', 'f'):
             /* stream header */
-            if (stream_index >= s->nb_streams || avi->type == 1) {
+            if (stream_index >= s->nb_streams || avi->dv_demux) {
                 url_fskip(pb, size);
             } else {
                 st = s->streams[stream_index];
@@ -305,7 +274,6 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
     /* check stream number */
     if (stream_index != s->nb_streams - 1) {
     fail:
-        av_free(avi->buf);
         for(i=0;i<s->nb_streams;i++) {
             av_freep(&s->streams[i]->codec.extradata);
             av_freep(&s->streams[i]);
@@ -316,29 +284,19 @@ static int avi_read_header(AVFormatContext *s, AVFormatParameters *ap)
     return 0;
 }
 
-static void __destruct_pkt(struct AVPacket *pkt)
-{
-    pkt->data = NULL; pkt->size = 0;
-    return;
-}
-
 static int avi_read_packet(AVFormatContext *s, AVPacket *pkt)
 {
     AVIContext *avi = s->priv_data;
     ByteIOContext *pb = &s->pb;
     int n, d[8], size, i;
+    void* dstr;
 
     memset(d, -1, sizeof(int)*8);
    
-    if (avi->type == 1 && avi->stream_index) {
-        /* duplicate DV packet */
-        av_init_packet(pkt);
-        pkt->data = avi->buf;
-        pkt->size = avi->buf_size;
-        pkt->destruct = __destruct_pkt;
-        pkt->stream_index = avi->stream_index;
-        avi->stream_index = !avi->stream_index;
-        return 0;
+    if (avi->dv_demux) {
+        size = dv_get_packet(avi->dv_demux, pkt);
+	if (size >= 0)
+	    return size;
     }
         
     for(i=url_ftell(pb); !url_feof(pb); i++) {
@@ -387,26 +345,24 @@ static int avi_read_packet(AVFormatContext *s, AVPacket *pkt)
             && n < s->nb_streams
             && i + size <= avi->movi_end) {
         
-            if (avi->type == 1) {
-                uint8_t *tbuf = av_realloc(avi->buf, size + FF_INPUT_BUFFER_PADDING_SIZE);
-                if (!tbuf)
-                    return -1;
-                avi->buf = tbuf;
-                avi->buf_size = size;
-                av_init_packet(pkt);
-                pkt->data = avi->buf;
-                pkt->size = avi->buf_size;
-                pkt->destruct = __destruct_pkt;
-                avi->stream_index = n;
-            } else {
             av_new_packet(pkt, size);
-            }
             get_buffer(pb, pkt->data, size);
-            if (size & 1)
+            if (size & 1) {
                 get_byte(pb);
+		size++;
+	    }
+	
+	    if (avi->dv_demux) {
+	        dstr = pkt->destruct;
+	        size = dv_produce_packet(avi->dv_demux, pkt,
+		                         pkt->data, pkt->size);
+		pkt->destruct = dstr;
+	    } else {
                 pkt->stream_index = n;
-            pkt->flags |= PKT_FLAG_KEY; // FIXME: We really should read index for that
-            return 0;
+                pkt->flags |= PKT_FLAG_KEY; // FIXME: We really should read 
+		                            //        index for that
+	    }
+            return size;
         }
     }
     return -1;
@@ -416,7 +372,6 @@ static int avi_read_close(AVFormatContext *s)
 {
     int i;
     AVIContext *avi = s->priv_data;
-    av_free(avi->buf);
 
     for(i=0;i<s->nb_streams;i++) {
         AVStream *st = s->streams[i];
@@ -424,6 +379,9 @@ static int avi_read_close(AVFormatContext *s)
         av_free(st->codec.extradata);
     }
 
+    if (avi->dv_demux)
+        av_free(avi->dv_demux);
+
     return 0;
 }
 

libavformat/dv.h

+/* 
+ * General DV muxer/demuxer 
+ * Copyright (c) 2003 Roman Shaposhnick
+ *
+ * Many thanks to Dan Dennedy <dan@dennedy.org> for providing wealth
+ * of DV technical info.
+ *
+ * Raw DV format
+ * Copyright (c) 2002 Fabrice Bellard.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+ 
+void* dv_init_demux(AVFormatContext *s, int vid, int aid);
+int dv_get_packet(void*, AVPacket *);
+int dv_produce_packet(void*, AVPacket*, uint8_t*, int);
+
+void* dv_init_mux(AVFormatContext* s);
+int dv_assemble_frame(void *c, AVStream*, const uint8_t*, int, uint8_t**);
+void dv_delete_mux(void*);

libavformat/dv1394.c

@@ -31,13 +31,11 @@
 #undef DV1394_DEBUG
 
 #include "dv1394.h"
+#include "dv.h"
 
 struct dv1394_data {
     int fd;
     int channel;
-    int width, height;
-    int frame_rate;
-    int frame_size;
     int format;
 
     void *ring; /* Ring buffer */
@@ -45,9 +43,9 @@ struct dv1394_data {
     int avail;  /* Number of frames available for reading */
     int done;   /* Number of completed frames */
 
-    int stream; /* Current stream. 0 - video, 1 - audio */
     int64_t pts;  /* Current timestamp */
-    AVStream *vst, *ast;
+
+    void* dv_demux; /* Generic DV muxing/demuxing context */
 };
 
 /* 
@@ -69,7 +67,6 @@ static int dv1394_reset(struct dv1394_data *dv)
         return -1;
 
     dv->avail  = dv->done = 0;
-    dv->stream = 0;
     return 0;
 }
 
@@ -88,14 +85,9 @@ static int dv1394_read_header(AVFormatContext * context, AVFormatParameters * ap
     struct dv1394_data *dv = context->priv_data;
     const char *video_device;
 
-    dv->vst = av_new_stream(context, 0);
-    if (!dv->vst)
-        return -ENOMEM;
-    dv->ast = av_new_stream(context, 1);
-    if (!dv->ast) {
-        av_free(dv->vst);
-        return -ENOMEM;
-    }
+    dv->dv_demux = dv_init_demux(context, 0, 1);
+    if (!dv->dv_demux)
+        goto failed;
 
     if (ap->standard && !strcasecmp(ap->standard, "pal"))
 	dv->format = DV1394_PAL;
@@ -107,17 +99,6 @@ static int dv1394_read_header(AVFormatContext * context, AVFormatParameters * ap
     else
         dv->channel = DV1394_DEFAULT_CHANNEL;
 
-    dv->width = DV1394_WIDTH;
-    if (dv->format == DV1394_NTSC) {
-	dv->height = DV1394_NTSC_HEIGHT;
-        dv->frame_size = DV1394_NTSC_FRAME_SIZE;
-        dv->frame_rate = 30;
-    } else {
-	dv->height = DV1394_PAL_HEIGHT;
-        dv->frame_size = DV1394_PAL_FRAME_SIZE;
-        dv->frame_rate = 25;
-    }
-
     /* Open and initialize DV1394 device */
     video_device = ap->device;
     if (!video_device)
@@ -140,21 +121,6 @@ static int dv1394_read_header(AVFormatContext * context, AVFormatParameters * ap
         goto failed;
     }
 
-    dv->stream = 0;
-
-    dv->vst->codec.codec_type = CODEC_TYPE_VIDEO;
-    dv->vst->codec.codec_id   = CODEC_ID_DVVIDEO;
-    dv->vst->codec.width      = dv->width;
-    dv->vst->codec.height     = dv->height;
-    dv->vst->codec.frame_rate = dv->frame_rate;
-    dv->vst->codec.frame_rate_base = 1;
-    dv->vst->codec.bit_rate   = 25000000;  /* Consumer DV is 25Mbps */
-
-    dv->ast->codec.codec_type = CODEC_TYPE_AUDIO;
-    dv->ast->codec.codec_id   = CODEC_ID_DVAUDIO;
-    dv->ast->codec.channels   = 2;
-    dv->ast->codec.sample_rate= 48000;
-
     av_set_pts_info(context, 48, 1, 1000000);
 
     if (dv1394_start(dv) < 0)
@@ -164,55 +130,17 @@ static int dv1394_read_header(AVFormatContext * context, AVFormatParameters * ap
 
 failed:
     close(dv->fd);
-    av_free(dv->vst);
-    av_free(dv->ast);
     return -EIO;
 }
 
-static void __destruct_pkt(struct AVPacket *pkt)
-{
-    pkt->data = NULL; pkt->size = 0;
-    return;
-}
-
-static inline int __get_frame(struct dv1394_data *dv, AVPacket *pkt)
-{
-    char *ptr = dv->ring + (dv->index * DV1394_PAL_FRAME_SIZE);
-
-    if (dv->stream) {
-        dv->index = (dv->index + 1) % DV1394_RING_FRAMES;
-        dv->done++; dv->avail--;
-    } else {
-        dv->pts = av_gettime() & ((1LL << 48) - 1);
-    }
-
-    dv->format = ((ptr[3] & 0x80) == 0) ? DV1394_NTSC : DV1394_PAL;
-    if (dv->format == DV1394_NTSC) {
-        dv->frame_size = DV1394_NTSC_FRAME_SIZE;
-        dv->vst->codec.height = dv->height = DV1394_NTSC_HEIGHT;
-        dv->vst->codec.frame_rate = dv->frame_rate = 30;
-    } else {
-        dv->frame_size = DV1394_PAL_FRAME_SIZE;
-        dv->vst->codec.height = dv->height = DV1394_PAL_HEIGHT;
-        dv->vst->codec.frame_rate = dv->frame_rate = 25;
-    }
-	
-    av_init_packet(pkt);
-    pkt->destruct = __destruct_pkt;
-    pkt->data     = ptr;
-    pkt->size     = dv->frame_size;
-    pkt->pts      = dv->pts;
-    pkt->stream_index = dv->stream;
-    pkt->flags   |= PKT_FLAG_KEY;
-
-    dv->stream ^= 1;
-
-    return dv->frame_size;
-}
-
 static int dv1394_read_packet(AVFormatContext *context, AVPacket *pkt)
 {
     struct dv1394_data *dv = context->priv_data;
+    int size;
+
+    size = dv_get_packet(dv->dv_demux, pkt);
+    if (size > 0)
+        goto out;
 
     if (!dv->avail) {
         struct dv1394_status s;
@@ -276,7 +204,16 @@ restart_poll:
             dv->done);
 #endif
 
-    return __get_frame(dv, pkt);
+    size = dv_produce_packet(dv->dv_demux, pkt, 
+                             dv->ring + (dv->index * DV1394_PAL_FRAME_SIZE), 
+			     DV1394_PAL_FRAME_SIZE);
+    dv->index = (dv->index + 1) % DV1394_RING_FRAMES;
+    dv->done++; dv->avail--;
+    dv->pts = av_gettime() & ((1LL << 48) - 1);
+    
+out:
+    pkt->pts = dv->pts;
+    return size;
 }
 
 static int dv1394_close(AVFormatContext * context)
@@ -292,6 +229,7 @@ static int dv1394_close(AVFormatContext * context)
         perror("Failed to munmap DV1394 ring buffer");
 
     close(dv->fd);
+    av_free(dv->dv_demux);
 
     return 0;
 }