avformat/yuv4mpegdec: better error logging

724e6b3d · Gyan Doshi · 609dfb40 · 724e6b3d
Commit 724e6b3d authored Jan 26, 2020 by Gyan Doshi
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 4 deletions

yuv4mpegdec.c libavformat/yuv4mpegdec.c +8 -4

No files found.
--- a/libavformat/yuv4mpegdec.c
+++ b/libavformat/yuv4mpegdec.c
@@ -53,10 +53,14 @@ static int yuv4_read_header(AVFormatContext *s)
            break;
        }
    }
-    if (i == MAX_YUV4_HEADER)
+    if (i == MAX_YUV4_HEADER) {
-        return -1;
+        av_log(s, AV_LOG_ERROR, "Header too large.\n");
-    if (strncmp(header, Y4M_MAGIC, strlen(Y4M_MAGIC)))
+        return AVERROR(EINVAL);
-        return -1;
+    }
+    if (strncmp(header, Y4M_MAGIC, strlen(Y4M_MAGIC))) {
+        av_log(s, AV_LOG_ERROR, "Invalid magic number for yuv4mpeg.\n");
+        return AVERROR(EINVAL);
+    }
    header_end = &header[i + 1]; // Include space
    for (tokstart = &header[strlen(Y4M_MAGIC) + 1];