Commit 6cd06bd2 authored by Stefano Sabatini's avatar Stefano Sabatini

ffprobe: simplify/fix logic for the -show_format_entry option

Do not skip chapter header/footer printing, which breaks the parsing for
most writers.
parent a0fd3221
...@@ -178,6 +178,8 @@ struct WriterContext { ...@@ -178,6 +178,8 @@ struct WriterContext {
unsigned int nb_item; ///< number of the item printed in the given section, starting at 0 unsigned int nb_item; ///< number of the item printed in the given section, starting at 0
unsigned int nb_section; ///< number of the section printed in the given section sequence, starting at 0 unsigned int nb_section; ///< number of the section printed in the given section sequence, starting at 0
unsigned int nb_chapter; ///< number of the chapter, starting at 0 unsigned int nb_chapter; ///< number of the chapter, starting at 0
int is_fmt_chapter; ///< tells if the current chapter is "format", required by the print_format_entry option
}; };
static const char *writer_get_name(void *p) static const char *writer_get_name(void *p)
...@@ -252,6 +254,8 @@ static inline void writer_print_chapter_header(WriterContext *wctx, ...@@ -252,6 +254,8 @@ static inline void writer_print_chapter_header(WriterContext *wctx,
if (wctx->writer->print_chapter_header) if (wctx->writer->print_chapter_header)
wctx->writer->print_chapter_header(wctx, chapter); wctx->writer->print_chapter_header(wctx, chapter);
wctx->nb_section = 0; wctx->nb_section = 0;
wctx->is_fmt_chapter = !strcmp(chapter, "format");
} }
static inline void writer_print_chapter_footer(WriterContext *wctx, static inline void writer_print_chapter_footer(WriterContext *wctx,
...@@ -265,27 +269,23 @@ static inline void writer_print_chapter_footer(WriterContext *wctx, ...@@ -265,27 +269,23 @@ static inline void writer_print_chapter_footer(WriterContext *wctx,
static inline void writer_print_section_header(WriterContext *wctx, static inline void writer_print_section_header(WriterContext *wctx,
const char *section) const char *section)
{ {
if (!fmt_entries_to_show || (section && av_dict_get(fmt_entries_to_show, section, NULL, 0))) {
if (wctx->writer->print_section_header) if (wctx->writer->print_section_header)
wctx->writer->print_section_header(wctx, section); wctx->writer->print_section_header(wctx, section);
wctx->nb_item = 0; wctx->nb_item = 0;
}
} }
static inline void writer_print_section_footer(WriterContext *wctx, static inline void writer_print_section_footer(WriterContext *wctx,
const char *section) const char *section)
{ {
if (!fmt_entries_to_show || (section && av_dict_get(fmt_entries_to_show, section, NULL, 0))) {
if (wctx->writer->print_section_footer) if (wctx->writer->print_section_footer)
wctx->writer->print_section_footer(wctx, section); wctx->writer->print_section_footer(wctx, section);
wctx->nb_section++; wctx->nb_section++;
}
} }
static inline void writer_print_integer(WriterContext *wctx, static inline void writer_print_integer(WriterContext *wctx,
const char *key, long long int val) const char *key, long long int val)
{ {
if (!fmt_entries_to_show || (key && av_dict_get(fmt_entries_to_show, key, NULL, 0))) { if (!wctx->is_fmt_chapter || !fmt_entries_to_show || av_dict_get(fmt_entries_to_show, key, NULL, 0)) {
wctx->writer->print_integer(wctx, key, val); wctx->writer->print_integer(wctx, key, val);
wctx->nb_item++; wctx->nb_item++;
} }
...@@ -296,7 +296,7 @@ static inline void writer_print_string(WriterContext *wctx, ...@@ -296,7 +296,7 @@ static inline void writer_print_string(WriterContext *wctx,
{ {
if (opt && !(wctx->writer->flags & WRITER_FLAG_DISPLAY_OPTIONAL_FIELDS)) if (opt && !(wctx->writer->flags & WRITER_FLAG_DISPLAY_OPTIONAL_FIELDS))
return; return;
if (!fmt_entries_to_show || (key && av_dict_get(fmt_entries_to_show, key, NULL, 0))) { if (!wctx->is_fmt_chapter || !fmt_entries_to_show || av_dict_get(fmt_entries_to_show, key, NULL, 0)) {
wctx->writer->print_string(wctx, key, val); wctx->writer->print_string(wctx, key, val);
wctx->nb_item++; wctx->nb_item++;
} }
...@@ -307,7 +307,7 @@ static void writer_print_time(WriterContext *wctx, const char *key, ...@@ -307,7 +307,7 @@ static void writer_print_time(WriterContext *wctx, const char *key,
{ {
char buf[128]; char buf[128];
if (!fmt_entries_to_show || (key && av_dict_get(fmt_entries_to_show, key, NULL, 0))) { if (!wctx->is_fmt_chapter || !fmt_entries_to_show || av_dict_get(fmt_entries_to_show, key, NULL, 0)) {
if (ts == AV_NOPTS_VALUE) { if (ts == AV_NOPTS_VALUE) {
writer_print_string(wctx, key, "N/A", 1); writer_print_string(wctx, key, "N/A", 1);
} else { } else {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment