Commit 5f5b78ac authored by Luca Barbato's avatar Luca Barbato

xcbgrab: Free the host string after checking the connection

Prevent an use after free in the error message.

Bug-Id: CID 1274040
CC: libav-stable@libav.org
parent 0025f740
......@@ -607,14 +607,17 @@ static av_cold int xcbgrab_read_header(AVFormatContext *s)
c->conn = xcb_connect(host, &screen_num);
if (opts)
av_free(host);
if ((ret = xcb_connection_has_error(c->conn))) {
av_log(s, AV_LOG_ERROR, "Cannot open display %s, error %d.\n",
s->filename[0] ? host : "default", ret);
if (opts)
av_freep(&host);
return AVERROR(EIO);
}
if (opts)
av_freep(&host);
setup = xcb_get_setup(c->conn);
c->screen = get_screen(setup, screen_num);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment