Commit 4420b414 authored by Michael Niedermayer's avatar Michael Niedermayer

huffyuvdec: check for and propagate failures from inside generate_joint_tables()

Signed-off-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
parent f67a0d11
...@@ -107,11 +107,13 @@ static int read_len_table(uint8_t *dst, GetBitContext *gb) ...@@ -107,11 +107,13 @@ static int read_len_table(uint8_t *dst, GetBitContext *gb)
return 0; return 0;
} }
static void generate_joint_tables(HYuvContext *s) static int generate_joint_tables(HYuvContext *s)
{ {
uint16_t symbols[1 << VLC_BITS]; uint16_t symbols[1 << VLC_BITS];
uint16_t bits[1 << VLC_BITS]; uint16_t bits[1 << VLC_BITS];
uint8_t len[1 << VLC_BITS]; uint8_t len[1 << VLC_BITS];
int ret;
if (s->bitstream_bpp < 24) { if (s->bitstream_bpp < 24) {
int p, i, y, u; int p, i, y, u;
for (p = 0; p < 3; p++) { for (p = 0; p < 3; p++) {
...@@ -133,8 +135,9 @@ static void generate_joint_tables(HYuvContext *s) ...@@ -133,8 +135,9 @@ static void generate_joint_tables(HYuvContext *s)
} }
} }
ff_free_vlc(&s->vlc[3 + p]); ff_free_vlc(&s->vlc[3 + p]);
ff_init_vlc_sparse(&s->vlc[3 + p], VLC_BITS, i, len, 1, 1, if ((ret = ff_init_vlc_sparse(&s->vlc[3 + p], VLC_BITS, i, len, 1, 1,
bits, 2, 2, symbols, 2, 2, 0); bits, 2, 2, symbols, 2, 2, 0)) < 0)
return ret;
} }
} else { } else {
uint8_t (*map)[4] = (uint8_t(*)[4])s->pix_bgr_map; uint8_t (*map)[4] = (uint8_t(*)[4])s->pix_bgr_map;
...@@ -176,8 +179,10 @@ static void generate_joint_tables(HYuvContext *s) ...@@ -176,8 +179,10 @@ static void generate_joint_tables(HYuvContext *s)
} }
} }
ff_free_vlc(&s->vlc[3]); ff_free_vlc(&s->vlc[3]);
init_vlc(&s->vlc[3], VLC_BITS, i, len, 1, 1, bits, 2, 2, 0); if ((ret = init_vlc(&s->vlc[3], VLC_BITS, i, len, 1, 1, bits, 2, 2, 0)) < 0)
return ret;
} }
return 0;
} }
static int read_huffman_tables(HYuvContext *s, const uint8_t *src, int length) static int read_huffman_tables(HYuvContext *s, const uint8_t *src, int length)
...@@ -200,7 +205,8 @@ static int read_huffman_tables(HYuvContext *s, const uint8_t *src, int length) ...@@ -200,7 +205,8 @@ static int read_huffman_tables(HYuvContext *s, const uint8_t *src, int length)
return ret; return ret;
} }
generate_joint_tables(s); if ((ret = generate_joint_tables(s)) < 0)
return ret;
return (get_bits_count(&gb) + 7) / 8; return (get_bits_count(&gb) + 7) / 8;
} }
...@@ -238,7 +244,8 @@ static int read_old_huffman_tables(HYuvContext *s) ...@@ -238,7 +244,8 @@ static int read_old_huffman_tables(HYuvContext *s)
return ret; return ret;
} }
generate_joint_tables(s); if ((ret = generate_joint_tables(s)) < 0)
return ret;
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment