Commit 2a741bae authored by Michael Niedermayer's avatar Michael Niedermayer

Merge commit 'b3f04657'

* commit 'b3f04657':
  segment: Fix the failure paths

Conflicts:
	libavformat/segment.c
Merged-by: 's avatarMichael Niedermayer <michaelni@gmx.at>
parents 86e7d20a b3f04657
...@@ -574,6 +574,13 @@ static int select_reference_stream(AVFormatContext *s) ...@@ -574,6 +574,13 @@ static int select_reference_stream(AVFormatContext *s)
return 0; return 0;
} }
static void seg_free_context(SegmentContext *seg)
{
avio_closep(&seg->list_pb);
avformat_free_context(seg->avf);
seg->avf = NULL;
}
static int seg_write_header(AVFormatContext *s) static int seg_write_header(AVFormatContext *s)
{ {
SegmentContext *seg = s->priv_data; SegmentContext *seg = s->priv_data;
...@@ -705,12 +712,9 @@ static int seg_write_header(AVFormatContext *s) ...@@ -705,12 +712,9 @@ static int seg_write_header(AVFormatContext *s)
fail: fail:
av_dict_free(&options); av_dict_free(&options);
if (ret) { if (ret < 0)
if (seg->list) seg_free_context(seg);
avio_close(seg->list_pb);
if (seg->avf)
avformat_free_context(seg->avf);
}
return ret; return ret;
} }
...@@ -725,6 +729,9 @@ static int seg_write_packet(AVFormatContext *s, AVPacket *pkt) ...@@ -725,6 +729,9 @@ static int seg_write_packet(AVFormatContext *s, AVPacket *pkt)
int64_t usecs; int64_t usecs;
int64_t wrapped_val; int64_t wrapped_val;
if (!seg->avf)
return AVERROR(EINVAL);
if (seg->times) { if (seg->times) {
end_pts = seg->segment_count < seg->nb_times ? end_pts = seg->segment_count < seg->nb_times ?
seg->times[seg->segment_count] : INT64_MAX; seg->times[seg->segment_count] : INT64_MAX;
...@@ -815,6 +822,9 @@ fail: ...@@ -815,6 +822,9 @@ fail:
seg->segment_frame_count++; seg->segment_frame_count++;
} }
if (ret < 0)
seg_free_context(seg);
return ret; return ret;
} }
...@@ -823,8 +833,11 @@ static int seg_write_trailer(struct AVFormatContext *s) ...@@ -823,8 +833,11 @@ static int seg_write_trailer(struct AVFormatContext *s)
SegmentContext *seg = s->priv_data; SegmentContext *seg = s->priv_data;
AVFormatContext *oc = seg->avf; AVFormatContext *oc = seg->avf;
SegmentListEntry *cur, *next; SegmentListEntry *cur, *next;
int ret = 0;
if (!oc)
goto fail;
int ret;
if (!seg->write_header_trailer) { if (!seg->write_header_trailer) {
if ((ret = segment_end(s, 0, 1)) < 0) if ((ret = segment_end(s, 0, 1)) < 0)
goto fail; goto fail;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment