Commit 07519f36 authored by Michael Niedermayer's avatar Michael Niedermayer

avcodec/hqx: Check the input data against the image size

Fixes: Timeout (22 -> 100 ms)
Fixes: 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992
Fixes: 17896/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5679312077848576

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
parent 859362a6
......@@ -471,6 +471,14 @@ static int hqx_decode_frame(AVCodecContext *avctx, void *data,
avctx->height = ctx->height;
avctx->bits_per_raw_sample = 10;
//The minimum size is 2bit per macroblock
// hqx_decode_422 & hqx_decode_444 have a unconditionally stored 4bits hqx_quants index
// hqx_decode_422a & hqx_decode_444a use cbp_vlc which has a minimum length of 2 bits for its VLCs
// The code rejects slices overlapping in their input data
if (avctx->coded_width / 16 * (avctx->coded_height / 16) *
(100 - avctx->discard_damaged_percentage) / 100 > 4LL * avpkt->size)
return AVERROR_INVALIDDATA;
switch (ctx->format) {
case HQX_422:
avctx->pix_fmt = AV_PIX_FMT_YUV422P16;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment