• Andreas Rheinhardt's avatar
    avformat/matroskaenc: Don't implicitly mark WebVTT in WebM as English · da4ba243
    Andreas Rheinhardt authored
    Writing the language of WebVTT in WebM proceeded differently than the
    language of all other tracks: In case no language was given, it does not
    write anything instead of "und" (for undefined). Because the default
    value of the Language element in WebM (that inherited it from Matroska)
    is "eng" (for English), any such track will actually be flagged as
    English.
    
    Doing it this way goes back to commit 509642b4 (the commit adding
    support for WebVTT) and no reason for this has been given in the commit
    message or in the discussion about this patch on the mailing list; the
    best I can think of is this: the WebM wiki contains "The srclang attribute
    is stored as the Language sub-element." Someone unfamiliar with default
    values in Matroska/WebM could interpret this as meaning that no Language
    element should be written if the language is unknown. And this is wrong
    and this commit changes it.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    da4ba243
matroskaenc.c 102 KB