• Andreas Rheinhardt's avatar
    avformat/utils: Preserve integrity of linked list · 90f647c2
    Andreas Rheinhardt authored
    1. Instead of relying on ff_packet_list_get to get the oldest element in
    an AVPacketList, ff_read_packet used its own ad-hoc code. Said code
    forgot to set the end of the list to NULL if the last element of the
    list has been removed, thereby leaving the list in an inconsistent state.
    2. Furthermore, if the list was not empty, the oldest element of the
    list would always be copied into another packet structure before it was
    known whether the oldest entry of the list would be removed. This makes
    the ownership confusing and potentially copies unnecessarily.
    
    Both of these issues have been fixed. ff_packet_list_get is used now.
    Signed-off-by: 's avatarAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
    Signed-off-by: 's avatarMichael Niedermayer <michael@niedermayer.cc>
    90f647c2
utils.c 200 KB