• dpranke@chromium.org's avatar
    Use author as determined from scm if we can not get it from rietveld · f6ddfa4b
    dpranke@chromium.org authored
    Until an issue is uploaded to Rietveld, we don't know the official
    email address to use for an owners check. There are three ways to fix
    this: we could attempt to log in to rietveld prior to doing the check
    and extract the address to use, or we could use ~/.last_codereview_email_address,
    or we can use the email address we can determine from the checkout.
    
    All three options have flaws; the first is particularly awkward since there
    doesn't seem to be a good way to fetch the email without posting an issue.
    The second is flawed if we use different addresses for different repos,
    and the third is flawed if the checkout's email address is different from
    the rietveld address, or if it is anonymous.
    
    However, since this is only being used for owners checks (in this case),
    anonymous checkouts probably don't matter, and hopefully the cases where
    the email addresses differ are rare.
    
    R=maruel@chromium.org
    BUG=118388, 150049
    
    
    Review URL: https://chromiumcodereview.appspot.com/12377023
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98
    f6ddfa4b
Name
Last commit
Last update
bootstrap Loading commit data...
git-templates Loading commit data...
git_utils Loading commit data...
support Loading commit data...
testing_support Loading commit data...
tests Loading commit data...
third_party Loading commit data...
zsh-goodies Loading commit data...
.gitignore Loading commit data...
LICENSE Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README Loading commit data...
README.codereview Loading commit data...
README.gclient Loading commit data...
README.git-cl Loading commit data...
README.testing Loading commit data...
WATCHLISTS Loading commit data...
apply_issue Loading commit data...
apply_issue.bat Loading commit data...
apply_issue.py Loading commit data...
breakpad.py Loading commit data...
cbuildbot Loading commit data...
checkout.py Loading commit data...
chrome-update-create-task.bat Loading commit data...
chrome-update.bat Loading commit data...
chrome-update.py Loading commit data...
chrome_set_ver Loading commit data...
codereview.settings Loading commit data...
commit_queue.py Loading commit data...
cpplint.bat Loading commit data...
cpplint.py Loading commit data...
cpplint_chromium.py Loading commit data...
create-chromium-git-src Loading commit data...
create-ntfs-junction.c Loading commit data...
create-ntfs-junction.exe Loading commit data...
cros Loading commit data...
cros_sdk Loading commit data...
crup-runner.sh Loading commit data...
drover Loading commit data...
drover.bat Loading commit data...
drover.py Loading commit data...
fix_encoding.py Loading commit data...
gcl Loading commit data...
gcl.bat Loading commit data...
gcl.py Loading commit data...
gclient Loading commit data...
gclient.bat Loading commit data...
gclient.py Loading commit data...
gclient_scm.py Loading commit data...
gclient_utils.py Loading commit data...
git-cl Loading commit data...
git-cl-upload-hook Loading commit data...
git-crsync Loading commit data...
git-crup Loading commit data...
git-gs Loading commit data...
git-lkgr Loading commit data...
git-runhooks Loading commit data...
git-try Loading commit data...
git-wktry Loading commit data...
git_cl.py Loading commit data...
git_try.py Loading commit data...
git_wktry.py Loading commit data...
hammer Loading commit data...
hammer.bat Loading commit data...
my_activity.py Loading commit data...
my_reviews.py Loading commit data...
ninja Loading commit data...
ninja-linux32 Loading commit data...
ninja-linux64 Loading commit data...
ninja-mac Loading commit data...
ninja.exe Loading commit data...
owners.py Loading commit data...
patch.py Loading commit data...
presubmit_canned_checks.py Loading commit data...
presubmit_support.py Loading commit data...
profile.xml Loading commit data...
pylint Loading commit data...
pylint.py Loading commit data...
pylintrc Loading commit data...
repo Loading commit data...
rietveld.py Loading commit data...
scm.py Loading commit data...
subprocess2.py Loading commit data...
trychange.py Loading commit data...
update_depot_tools Loading commit data...
update_depot_tools.bat Loading commit data...
watchlists.py Loading commit data...
weekly Loading commit data...
wtf Loading commit data...