• dpranke@chromium.org's avatar
    Change the OWNERS check to print files, not directories · 6b1e3ee9
    dpranke@chromium.org authored
    Currently, when we run the OWNERS check, we print the list of directories
    that contain the relevant OWNERS files for any modified files in a change
    still needing approval. 
    
    This has two problems:
    
    1) if we bubble all the way up to the top level OWNERS, we print "" instead of
    "src/" or something more useful (bug 157191)
    
    2) for OWNERS files that contain per-file set-noparent entries (like changes to IPC messages), this can be really confusing because an owner of other stuff in the directory might've approved things already.
    
    This change will now print the list of files in the CL that are still unapproved.
    This might be a lot more verbose (since you get N lines rather than 1 for N files in a given directory), but hopefully it'll be clearer in the two cases above.
    
    Also, this change takes care of some lingering clean-up in the code to rename some methods to be clearer.
    
    R=maruel@chromium.org
    BUG=157191
    
    
    
    
    Review URL: https://chromiumcodereview.appspot.com/12314044
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@184219 0039d316-1c4b-4281-b951-d872f2087c98
    6b1e3ee9
Name
Last commit
Last update
..
subversion_config Loading commit data...
abandon.sh Loading commit data...
basic.sh Loading commit data...
breakpad_unittest.py Loading commit data...
checkout_test.py Loading commit data...
fix_encoding_test.py Loading commit data...
gcl_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_smoketest.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
git_cl_test.py Loading commit data...
hooks.sh Loading commit data...
owners.sh Loading commit data...
owners_unittest.py Loading commit data...
patch.sh Loading commit data...
patch_test.py Loading commit data...
post-dcommit-hook-test.sh Loading commit data...
presubmit_unittest.py Loading commit data...
push-basic.sh Loading commit data...
push-from-logs.sh Loading commit data...
rename.sh Loading commit data...
rietveld_test.py Loading commit data...
sample_pre_commit_hook Loading commit data...
save-description-on-failure.sh Loading commit data...
scm_unittest.py Loading commit data...
submit-from-new-dir.sh Loading commit data...
submodule-merge-test.sh Loading commit data...
subprocess2_test.py Loading commit data...
test-lib.sh Loading commit data...
trychange_unittest.py Loading commit data...
upload-local-tracking-branch.sh Loading commit data...
upload-stale.sh Loading commit data...
upstream.sh Loading commit data...
watchlists_unittest.py Loading commit data...