• hinoka@chromium.org's avatar
    Git Cache speculative fix for windows · 4e2ad846
    hinoka@chromium.org authored
    Git cache sometimes fail on:
    Traceback (most recent call last):
      File "E:\b\depot_tools\\gclient.py", line 2064, in <module>
        sys.exit(Main(sys.argv[1:]))
      File "E:\b\depot_tools\\gclient.py", line 2052, in Main
        return dispatcher.execute(OptionParser(), argv)
      File "E:\b\depot_tools\subcommand.py", line 245, in execute
        return command(parser, args[1:])
      File "E:\b\depot_tools\\gclient.py", line 1830, in CMDsync
        ret = client.RunOnDeps('update', args)
      File "E:\b\depot_tools\\gclient.py", line 1342, in RunOnDeps
        work_queue.flush(revision_overrides, command, args, options=self._options)
      File "E:\b\depot_tools\gclient_utils.py", line 852, in flush
        self._run_one_task(self.queued.pop(i), args, kwargs)
      File "E:\b\depot_tools\gclient_utils.py", line 944, in _run_one_task
        task_item.run(*args, **kwargs)
      File "E:\b\depot_tools\\gclient.py", line 744, in run
        file_list)
      File "E:\b\depot_tools\gclient_scm.py", line 160, in RunCommand
        return getattr(self, command)(options, args, file_list)
      File "E:\b\depot_tools\gclient_scm.py", line 387, in update
        self._UpdateMirror(mirror, options)
      File "E:\b\depot_tools\gclient_scm.py", line 802, in _UpdateMirror
        ignore_lock=options.ignore_locks)
      File "E:\b\depot_tools\git_cache.py", line 409, in populate
        os.rename(tempdir, self.mirror_path)
    WindowsError: [Error 183] Cannot create a file when that file already exists
    
    It would appear that its being racy, but otherwise it doesn't make any sense.  A theory
    is that this could be running twice and stepping on each other.  Allowing this
    to pass on OSError allows us to test this theory.
    
    BUG=395333
    
    Review URL: https://codereview.chromium.org/408653002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@284272 0039d316-1c4b-4281-b951-d872f2087c98
    4e2ad846
Name
Last commit
Last update
bootstrap Loading commit data...
git-templates Loading commit data...
git_utils Loading commit data...
man Loading commit data...
recipes Loading commit data...
support Loading commit data...
testing_support Loading commit data...
tests Loading commit data...
third_party Loading commit data...
win_toolchain Loading commit data...
zsh-goodies Loading commit data...
.gitignore Loading commit data...
LICENSE Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README Loading commit data...
README.codereview Loading commit data...
README.gclient Loading commit data...
README.git-cl Loading commit data...
README.testing Loading commit data...
WATCHLISTS Loading commit data...
annotated_gclient.py Loading commit data...
apply_issue Loading commit data...
apply_issue.bat Loading commit data...
apply_issue.py Loading commit data...
breakpad.py Loading commit data...
cbuildbot Loading commit data...
checkout.py Loading commit data...
chrome-update-create-task.bat Loading commit data...
chrome-update.bat Loading commit data...
chrome-update.py Loading commit data...
chrome_set_ver Loading commit data...
clang-format Loading commit data...
clang-format.bat Loading commit data...
clang_format.py Loading commit data...
codereview.settings Loading commit data...
commit_queue.py Loading commit data...
cpplint.bat Loading commit data...
cpplint.py Loading commit data...
cpplint_chromium.py Loading commit data...
create-chromium-git-src Loading commit data...
create-ntfs-junction.c Loading commit data...
create-ntfs-junction.exe Loading commit data...
cros Loading commit data...
cros_sdk Loading commit data...
download_from_google_storage Loading commit data...
download_from_google_storage.bat Loading commit data...
download_from_google_storage.py Loading commit data...
drover Loading commit data...
drover.bat Loading commit data...
drover.py Loading commit data...
fetch Loading commit data...
fetch.bat Loading commit data...
fetch.py Loading commit data...
fix_encoding.py Loading commit data...
gcl Loading commit data...
gcl.bat Loading commit data...
gcl.py Loading commit data...
gclient Loading commit data...
gclient-new-workdir.py Loading commit data...
gclient.bat Loading commit data...
gclient.py Loading commit data...
gclient_completion.sh Loading commit data...
gclient_scm.py Loading commit data...
gclient_utils.py Loading commit data...
gerrit_util.py Loading commit data...
git-cache Loading commit data...
git-cl Loading commit data...
git-cl-upload-hook Loading commit data...
git-crsync Loading commit data...
git-crup Loading commit data...
git-freeze Loading commit data...
git-gs Loading commit data...
git-lkgr Loading commit data...
git-map Loading commit data...
git-map-branches Loading commit data...
git-mark-merge-base Loading commit data...
git-nav-downstream Loading commit data...
git-nav-upstream Loading commit data...
git-new-branch Loading commit data...
git-number Loading commit data...
git-rebase-update Loading commit data...
git-rename-branch Loading commit data...
git-reparent-branch Loading commit data...
git-runhooks Loading commit data...
git-squash-branch Loading commit data...
git-thaw Loading commit data...
git-try Loading commit data...
git-upstream-diff Loading commit data...
git_cache.py Loading commit data...
git_cl.py Loading commit data...
git_common.py Loading commit data...
git_freezer.py Loading commit data...
git_map.py Loading commit data...
git_map_branches.py Loading commit data...
git_mark_merge_base.py Loading commit data...
git_nav_downstream.py Loading commit data...
git_new_branch.py Loading commit data...
git_number.py Loading commit data...
git_rebase_update.py Loading commit data...
git_rename_branch.py Loading commit data...
git_reparent_branch.py Loading commit data...
git_squash_branch.py Loading commit data...
git_try.py Loading commit data...
git_upstream_diff.py Loading commit data...
gn Loading commit data...
gn.bat Loading commit data...
gn.py Loading commit data...
hammer Loading commit data...
hammer.bat Loading commit data...
my_activity.py Loading commit data...
my_reviews.py Loading commit data...
ninja Loading commit data...
ninja-linux32 Loading commit data...
ninja-linux64 Loading commit data...
ninja-mac Loading commit data...
ninja.exe Loading commit data...
owners.py Loading commit data...
owners_finder.py Loading commit data...
patch.py Loading commit data...
presubmit_canned_checks.py Loading commit data...
presubmit_support.py Loading commit data...
profile.xml Loading commit data...
pylint Loading commit data...
pylint.py Loading commit data...
pylintrc Loading commit data...
python_git_runner.sh Loading commit data...
repo Loading commit data...
rietveld.py Loading commit data...
roll-dep Loading commit data...
roll-dep.bat Loading commit data...
roll_dep.py Loading commit data...
scm.py Loading commit data...
subcommand.py Loading commit data...
subprocess2.py Loading commit data...
trychange.py Loading commit data...
update_depot_tools Loading commit data...
update_depot_tools.bat Loading commit data...
upload_to_google_storage.py Loading commit data...
watchlists.py Loading commit data...
weekly Loading commit data...
wtf Loading commit data...