• gavinp@google.com's avatar
    Add explicit file rename/cp information to svn rietveld uploads · 3fda4cce
    gavinp@google.com authored
    Right now if you svn cp or svn mv before uploading to rietveld,
    there's no description in the patch at all of what was done; so you
    get a diff, but it's for who knows what revision of what prior file
    to some current version.
    
    For code reviews this kinda works (you ask the guy what it was), but for
    trying to apply patches (ala git patch) this fails badly.  This patch
    tries to add some metadata to the start of a rietveld patch that
    describes these changes: both to a human (who can read them)
    and to a potential clever future git-cl (which I'll do next).
    
    The metadata looks like this after checking out a test repo, and
    svn cp -r 1 foo nitz; svn cp bar quux; echo be good>>quux
    
      ### BEGIN SVN COPY METADATA
      #$ svn cp -r 1 foo nitz ### WARNING: note non-trunk copy
      #$ cp bar quux
      ### END SVN COPY METADATA
      Index: nitz
      Index: quux
      ===================================================================
      --- quux	(revision 0)
      +++ quux	(working copy)
      @@ -1,2 +1,3 @@
       hi mom
       hi sister
      +be good
    
    I did a test, and this looks like it works in svn 1.4.4 as well.
    
    BUG=none
    TEST=none
    Review URL: http://codereview.chromium.org/2824035
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@51121 0039d316-1c4b-4281-b951-d872f2087c98
    3fda4cce
Name
Last commit
Last update
bootstrap Loading commit data...
tests Loading commit data...
third_party Loading commit data...
zsh-goodies Loading commit data...
.gitignore Loading commit data...
LICENSE Loading commit data...
PRESUBMIT.py Loading commit data...
README Loading commit data...
README.gclient Loading commit data...
WATCHLISTS Loading commit data...
breakpad.py Loading commit data...
chrome-update-create-task.bat Loading commit data...
chrome-update.bat Loading commit data...
chrome-update.py Loading commit data...
codereview.settings Loading commit data...
cpplint.bat Loading commit data...
cpplint.py Loading commit data...
create-chromium-git-src Loading commit data...
drover Loading commit data...
drover.bat Loading commit data...
drover.py Loading commit data...
gcl Loading commit data...
gcl.bat Loading commit data...
gcl.py Loading commit data...
gclient Loading commit data...
gclient.bat Loading commit data...
gclient.py Loading commit data...
gclient_scm.py Loading commit data...
gclient_utils.py Loading commit data...
git-cl Loading commit data...
git-cl-upload-hook Loading commit data...
git-gs Loading commit data...
git-try Loading commit data...
git_cl_hooks.py Loading commit data...
hammer Loading commit data...
hammer.bat Loading commit data...
presubmit_canned_checks.py Loading commit data...
presubmit_support.py Loading commit data...
profile.xml Loading commit data...
pylintrc Loading commit data...
scm.py Loading commit data...
trychange.py Loading commit data...
watchlists.py Loading commit data...
weekly Loading commit data...
wtf Loading commit data...