• chase@chromium.org's avatar
    Call git diff --name-status with a relative path. · 37c629a3
    chase@chromium.org authored
    On a new Linux box, during git cl dcommit I observed
    the error:
    
      fatal: invalid diff option/value: -r
    
    This was caused by the git cl presubmit hooks running:
    
      git diff --name-status -r refs/remotes/origin/trunk.. /path/to/src
    
    By passing a relative path (given by git rev-parse
    --show-cdup) instead of an absolute path for
    /path/to/src, git diff --name-status does not print an
    error and returns the expected list of changed files.
    
    Also fix some broken scm and gclient_scm unit tests.
    
    BUG=none
    TEST=git presubmit hooks work from main working
    directory
    Review URL: http://codereview.chromium.org/438012
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32999 0039d316-1c4b-4281-b951-d872f2087c98
    37c629a3
Name
Last commit
Last update
..
pymox Loading commit data...
README.gclient_test Loading commit data...
__init__.py Loading commit data...
gcl_unittest.py Loading commit data...
gclient_scm_test.py Loading commit data...
gclient_test.py Loading commit data...
gclient_utils_test.py Loading commit data...
presubmit_unittest.py Loading commit data...
revert_unittest.py Loading commit data...
scm_unittest.py Loading commit data...
super_mox.py Loading commit data...
trychange_unittest.py Loading commit data...
watchlists_unittest.py Loading commit data...