• Andrii Shyshkalov's avatar
    Revert "Show GIT_TRACE for git command in bot_update.py" · 25b1da95
    Andrii Shyshkalov authored
    This reverts commit 6e215cef.
    
    Reason for revert: seems to have broken bot_update 
    https://ci.chromium.org/swarming/task/39ff1814b3bb5b10?server=chromium-swarm.appspot.com
    
    Original change's description:
    > Show GIT_TRACE for git command in bot_update.py
    > 
    > GIT_TRACE=true tells us which internal git command is slow.
    > https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables
    > 
    > I got following results in my local repository.
    > Let me confirm the bots show similar behavior.
    > 
    > C:\src\chromium\src>set GIT_TRACE=true
    > 
    > C:\src\chromium\src>git rebase-update
    > 21:32:36.519698 git.c:576               trace: exec: 'git-rebase-update'
    > 21:32:36.519698 run-command.c:626       trace: run_command: 'git-rebase-update'
    > 21:32:38.889848 git.c:344               trace: built-in: git 'fetch' '--multiple' 'origin'
    > 21:32:38.893846 run-command.c:626       trace: run_command: 'fetch' '--append' 'origin'
    > Fetching origin
    > 21:32:38.911858 git.c:344               trace: built-in: git 'fetch' '--append' 'origin'
    > 21:32:38.983909 run-command.c:626       trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:32:39.002923 git.c:576               trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:32:39.003923 run-command.c:626       trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:32:43.782266 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > 21:32:43.827301 run-command.c:626       trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
    > remote: Counting objects: 74400, done
    > remote: Finding sources: 100% (19/19)
    > 21:35:49.348951 run-command.c:626       trace: run_command: 'unpack-objects' '--pack_header=2,19'
    > 21:35:49.368985 git.c:344               trace: built-in: git 'unpack-objects' '--pack_header=2,19'
    > remote: Total 19 (delta 1), reused 18 (delta 1)
    > Unpacking objects: 100% (19/19), done.
    > 21:35:49.597328 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > 21:35:49.612375 git.c:344               trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > From https://chromium.googlesource.com/chromium/src
    >    e8994685157b..fd56d3ad0528  master     -> origin/master
    > 21:35:50.281845 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
    > 21:35:50.287848 run-command.c:1484      run_processes_parallel: done
    > 21:35:50.309865 run-command.c:626       trace: run_command: 'gc' '--auto'
    > 21:35:50.328880 git.c:344               trace: built-in: git 'gc' '--auto'
    > 21:35:50.453967 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
    > 21:35:50.460971 run-command.c:1484      run_processes_parallel: done
    > 21:35:50.460971 run-command.c:626       trace: run_command: 'gc' '--auto'
    > 21:35:50.480985 git.c:344               trace: built-in: git 'gc' '--auto'
    > Rebasing: direct_goma
    > Rebasing: python_pool
    > 
    > C:\src\chromium\src>git fetch
    > 21:36:23.409703 git.c:344               trace: built-in: git 'fetch'
    > 21:36:23.486758 run-command.c:626       trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:36:23.506772 git.c:576               trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:36:23.506772 run-command.c:626       trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git'
    > 21:36:28.542596 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > 21:36:28.578620 run-command.c:626       trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
    > 21:36:28.601635 git.c:344               trace: built-in: git 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/'
    > remote: Counting objects: 67598, done
    > remote: Finding sources: 100% (28/28)
    > 21:39:29.787441 run-command.c:626       trace: run_command: 'unpack-objects' '--pack_header=2,28'
    > 21:39:29.812462 git.c:344               trace: built-in: git 'unpack-objects' '--pack_header=2,28'
    > remote: Total 28 (delta 2), reused 20 (delta 2)
    > Unpacking objects: 100% (28/28), done.
    > 21:39:30.083690 run-command.c:626       trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > 21:39:30.108704 git.c:344               trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
    > From https://chromium.googlesource.com/chromium/src
    >    fd56d3ad0528..fbcc09282dc8  master     -> origin/master
    > 21:39:30.788186 run-command.c:1452      run_processes_parallel: preparing to run up to 1 tasks
    > 21:39:30.795191 run-command.c:1484      run_processes_parallel: done
    > 21:39:30.813200 run-command.c:626       trace: run_command: 'gc' '--auto'
    > 21:39:30.836212 git.c:344               trace: built-in: git 'gc' '--auto'
    > 
    > 
    > Bug:749709
    > Change-Id: I5b94549c42271885365c2354dc3f58399d6aebe0
    > Reviewed-on: https://chromium-review.googlesource.com/786691
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > Commit-Queue: Takuto Ikuta <tikuta@google.com>
    
    TBR=hinoka@chromium.org,agable@chromium.org,tandrii@chromium.org,tikuta@google.com
    
    Change-Id: I970ddac1fd21e904c69dc18e48169d49293b1800
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 749709
    Reviewed-on: https://chromium-review.googlesource.com/786413Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    25b1da95
Name
Last commit
Last update
bootstrap/win Loading commit data...
fetch_configs Loading commit data...
git-templates Loading commit data...
infra Loading commit data...
man Loading commit data...
recipes Loading commit data...
support Loading commit data...
testing_support Loading commit data...
tests Loading commit data...
third_party Loading commit data...
win_toolchain Loading commit data...
zsh-goodies Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.style.yapf Loading commit data...
LICENSE Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.gclient.md Loading commit data...
README.git-cl.md Loading commit data...
README.md Loading commit data...
README.testing Loading commit data...
WATCHLISTS Loading commit data...
annotated_gclient.py Loading commit data...
appengine_mapper.py Loading commit data...
apply_issue Loading commit data...
apply_issue.bat Loading commit data...
apply_issue.py Loading commit data...
auth.py Loading commit data...
autoninja Loading commit data...
autoninja.bat Loading commit data...
autoninja.py Loading commit data...
breakpad.py Loading commit data...
buildbucket.py Loading commit data...
cbuildbot Loading commit data...
checkout.py Loading commit data...
chrome_set_ver Loading commit data...
cipd Loading commit data...
cipd.bat Loading commit data...
cipd.ps1 Loading commit data...
cipd_bin_setup.bat Loading commit data...
cipd_bin_setup.sh Loading commit data...
cipd_client_version Loading commit data...
cipd_manifest.txt Loading commit data...
cit Loading commit data...
cit.bat Loading commit data...
cit.py Loading commit data...
clang-format Loading commit data...
clang-format.bat Loading commit data...
clang_format.py Loading commit data...
clang_format_merge_driver Loading commit data...
clang_format_merge_driver.bat Loading commit data...
clang_format_merge_driver.py Loading commit data...
codereview.settings Loading commit data...
compile_single_file Loading commit data...
compile_single_file.bat Loading commit data...
compile_single_file.py Loading commit data...
cpplint.bat Loading commit data...
cpplint.py Loading commit data...
cpplint_chromium.py Loading commit data...
cros Loading commit data...
cros_sdk Loading commit data...
dart_format.py Loading commit data...
depot-tools-auth Loading commit data...
depot-tools-auth.bat Loading commit data...
depot-tools-auth.py Loading commit data...
download_from_google_storage Loading commit data...
download_from_google_storage.bat Loading commit data...
download_from_google_storage.py Loading commit data...
ensure_bootstrap Loading commit data...
fetch Loading commit data...
fetch.bat Loading commit data...
fetch.py Loading commit data...
fix_encoding.py Loading commit data...
gclient Loading commit data...
gclient-new-workdir.py Loading commit data...
gclient.bat Loading commit data...
gclient.py Loading commit data...
gclient_completion.sh Loading commit data...
gclient_eval.py Loading commit data...
gclient_scm.py Loading commit data...
gclient_utils.py Loading commit data...
gerrit_client.py Loading commit data...
gerrit_util.py Loading commit data...
git-cache Loading commit data...
git-cl Loading commit data...
git-crrev-parse Loading commit data...
git-crsync Loading commit data...
git-drover Loading commit data...
git-find-releases Loading commit data...
git-footers Loading commit data...
git-freeze Loading commit data...
git-gs Loading commit data...
git-hyper-blame Loading commit data...
git-map Loading commit data...
git-map-branches Loading commit data...
git-mark-merge-base Loading commit data...
git-nav-downstream Loading commit data...
git-nav-upstream Loading commit data...
git-new-branch Loading commit data...
git-number Loading commit data...
git-rebase-update Loading commit data...
git-rename-branch Loading commit data...
git-reparent-branch Loading commit data...
git-retry Loading commit data...
git-runhooks Loading commit data...
git-squash-branch Loading commit data...
git-thaw Loading commit data...
git-upstream-diff Loading commit data...
git_cache.py Loading commit data...
git_cl.py Loading commit data...
git_cl_completion.sh Loading commit data...
git_common.py Loading commit data...
git_dates.py Loading commit data...
git_drover.py Loading commit data...
git_find_releases.py Loading commit data...
git_footers.py Loading commit data...
git_freezer.py Loading commit data...
git_hyper_blame.py Loading commit data...
git_map.py Loading commit data...
git_map_branches.py Loading commit data...
git_mark_merge_base.py Loading commit data...
git_nav_downstream.py Loading commit data...
git_new_branch.py Loading commit data...
git_number.py Loading commit data...
git_rebase_update.py Loading commit data...
git_rename_branch.py Loading commit data...
git_reparent_branch.py Loading commit data...
git_retry.py Loading commit data...
git_squash_branch.py Loading commit data...
git_upstream_diff.py Loading commit data...
gn Loading commit data...
gn.bat Loading commit data...
gn.py Loading commit data...
gsutil.py Loading commit data...
gsutil.vpython Loading commit data...
led Loading commit data...
led.bat Loading commit data...
mac_toolchain Loading commit data...
my_activity.py Loading commit data...
my_reviews.py Loading commit data...
ninja Loading commit data...
ninja-linux32 Loading commit data...
ninja-linux64 Loading commit data...
ninja-mac Loading commit data...
ninja.exe Loading commit data...
owners.py Loading commit data...
owners_finder.py Loading commit data...
patch.py Loading commit data...
presubmit_canned_checks.py Loading commit data...
presubmit_support.py Loading commit data...
profile.xml Loading commit data...
pylint Loading commit data...
pylint.py Loading commit data...
pylintrc Loading commit data...
python_runner.sh Loading commit data...
repo Loading commit data...
rietveld.py Loading commit data...
roll-dep Loading commit data...
roll-dep-svn Loading commit data...
roll-dep-svn.bat Loading commit data...
roll-dep.bat Loading commit data...
roll_dep.py Loading commit data...
roll_dep_svn.py Loading commit data...
scm.py Loading commit data...
setup_color.py Loading commit data...
split_cl.py Loading commit data...
subcommand.py Loading commit data...
subprocess2.py Loading commit data...
update_depot_tools Loading commit data...
update_depot_tools.bat Loading commit data...
update_depot_tools_toggle.py Loading commit data...
upload_to_google_storage.py Loading commit data...
vpython Loading commit data...
vpython.bat Loading commit data...
watchlists.py Loading commit data...
weekly Loading commit data...
wtf Loading commit data...