Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 21 Feb, 2018 2 commits
  3. 20 Feb, 2018 2 commits
  5. 16 Feb, 2018 1 commit
    • Alexander Alekseev's avatar
      Override temporary directory before spawning subprocess. · 3ade6e12
      Alexander Alekseev authored 
      Python multiprocessing is using sockets to communicate. UNIX socket names are
bound by PATH_MAX which includes temporary directory name.

gsutil uses multiprocessing, which creates file sockets in the tmpdir.
On some testing configurations, the tmpdir is set to a very long path, which
causes gsutil to fail with AF_UNIX path too long errors.

To prevent multiprocess failures, this CL overrides temporary directory
dictated by the environment to /tmp.

Bug: 812581
Change-Id: Idcd99d13b2e20b3095111fa26ec4e242848c8848
Reviewed-on: https://chromium-review.googlesource.com/923170Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
      3ade6e12
  7. 13 Feb, 2018 3 commits
    • Bruce Dawson's avatar
      Fix autoninja && chrome on failed builds · 46541b49
      Bruce Dawson authored 
      A handy usage pattern for autoninja.bat that I was not aware of is to go

    autoninja -C out\Default chrome && chrome

This will build chrome and then run it, but only run it if the build
succeeds. The addition of post_build_ninja_summary.py broke this by
losing the error code. This change fixes it by using black magic to
set an error code in the failure case.

Bug: chromium:787983
Change-Id: Ib87fd1799816e19d56de76e08e0f9688be903d80
Reviewed-on: https://chromium-review.googlesource.com/916705Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      46541b49
    • Bruce Dawson's avatar
      Update post_build_ninja_summary.py for Linux · e186e50d
      Bruce Dawson authored 
      post_build_ninja_summary.py gives a summary of a ninja build. It can be
run standalone or it can be run automatically by autoninja. This CL
updates the Python script and the autoninja bash script to make this
work on Linux. This includes removing a zero-value assert, and ensuring
that .so files get categorized as such.

Change-Id: I2d59ab129f5ce70117beeb119719f8432bfbab7c
Reviewed-on: https://chromium-review.googlesource.com/915053Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      e186e50d
    • Aaron Gable's avatar
      gclient: diff against hash in DEPS · 1853f66e
      Aaron Gable authored 
      When someone runs "gclient diff", they expect to be diffing their
local state against the state of a clean gclient checkout.

Up until now, "gclient diff" has been doing... not that. It's been
assuming that the sha1 in DEPS is approximately the head of the
remote's master branch, finding the merge-base between the local
content and that remote master, and diffing against that merge-base.
This makes basically no sense in the context of gclient. With
gclient, we already know exactly what should be checked out: it's
whatever is in DEPS.

This CL updates the behavior of "gclient diff" to do the right thing.

Bug: 731701
Change-Id: I23a43cbc0d6bc7772495097ff615d4d070f5ad19
Reviewed-on: https://chromium-review.googlesource.com/914717Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      1853f66e
  9. 12 Feb, 2018 4 commits
  11. 09 Feb, 2018 3 commits
    • Aaron Gable's avatar
      Remove similarity support from git-cl · 13101a6e
      Aaron Gable authored 
      The purpose of this CL is to remove confusion around whether or
not git-cl support the similarity flags when talking to Gerrit.
It does not. However, because Rietveld support has not been
fully ripped out of git-cl, this change does modify some of the
Rietveld-specific code to remove similarity support from everywhere.

Bug: 800902
Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a
Reviewed-on: https://chromium-review.googlesource.com/912389Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      13101a6e
    • Bruce Dawson's avatar
      Script to summarize performance of ninja builds · ffc0c7c6
      Bruce Dawson authored 
      post_build_ninja_summary.py analyzes the .ninja_log file in an output
directory to summarize build performance. It lists the most expensive
build steps, and build-step types, printing both their elapsed time and,
more importantly, their "weighted" time which is a measure of their
contribution to the total build time.

For each time segment within the build the running build steps
accumulate weighted time that is proportional to the elapsed time
divided by the number of tasks running. If a thousand compilation steps
are running in parallel then they will each be "charged" for 1/1,000th
of the elapsed time. If a single link step is running alone then it is
charged with all of the elapsed time.

Bug: chromium:787983
Change-Id: Id5aea715f798a16415dd0365a27f0051202668e5
Reviewed-on: https://chromium-review.googlesource.com/871988Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: 's avatarErik Staab <estaab@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      ffc0c7c6
    • Torne (Richard Coles)'s avatar
      Don't fetch tags when using --no-history. · 08ca04b2
      Torne (Richard Coles) authored 
      After the initial gclient sync, "fetch --no-history" was adding a
fetchspec to the config for the main repository that causes all tags to
be downloaded in future. This means that after fetching a repository
with no history, the very next git pull (or other remote update
operation) will download all the tags, including all the history
referred to by those tags, leaving you with an almost-complete checkout
of the top-level repository that takes up much more space.

Fix this by skipping the "git config" command that requests the tags
when using no-history.

Change-Id: Ia31baa6a90df014ebc1e8c2ed6e05de3ad27d415
Reviewed-on: https://chromium-review.googlesource.com/909653Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
      08ca04b2
  13. 08 Feb, 2018 4 commits
  15. 07 Feb, 2018 8 commits
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 2cd0d80e
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/baa8aadd3db91c4870bcc82c1091f25944dfdc96 scheduler recipe_module: remove deprecated method. (tandrii@chromium.org)
  https://crrev.com/745f389a0d8fe49cc34f96704e5ad3dc0df406ec Don't block on OWNERS approval of README.recipes.md. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ab818dbebce2c51f00752059e1e754fc8950bcb
Reviewed-on: https://chromium-review.googlesource.com/907131
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: 's avatarRecipe Roller <recipe-roller@chromium.org>
      2cd0d80e
    • Edward Lemur's avatar
      Skip files owned by reviewers when quering for missing owners. · 707d70b9
      Edward Lemur authored 
      Bug: 728298
Change-Id: If813ff41b1668a2cab6c26b65e424fbe574e629c
Reviewed-on: https://chromium-review.googlesource.com/899086
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      707d70b9
    • Robert Iannucci's avatar
      [vpython] Roll vpython to unblock CrOS. · 4a92cc9a
      Robert Iannucci authored 
      This is already rolled to all buildbot machines; was waiting to roll
vpython in depot_tools last, but it appears that their builds may
actually depend on the version here.

f88d8d9aa [buildbucket] cancel swarming tasks when deleting builds
0c7d29eb5 Roll recipe dependencies (trivial).
58cd44f90 Roll luci-go.
b3dbb75ba Roll recipe dependencies (trivial).
57743d010 Revert "Remove temporary code used to add https to hosts"
4592a0a20 [buildbucket] refactor task cancelation
76f45a19b Roll recipe dependencies (trivial).
b2fb6be8e [som] Fix some FE unit tests.
57f45c589 [som] Update RELNOTES.md
c7bc0b942 Roll recipe dependencies (trivial).
f91ebe64a SoM: Add autosuggested labels back.
b2de6ae83 [Findit] Translate test failure to event schema
52adb6e67 Roll recipe dependencies (trivial).
efa035c1d [Monorail] Follow-up fix for presubmit browser compat fix
bf5820217 [prpc,luci-auth] Set builds to use static linking.
959f0f9bc SoM: Update ChOpsUI version.
91e92e1e6 Roll luci-go.
ebc1baca9 Roll recipe dependencies (trivial).
47b35eab2 In set review request, use patch set number
886cc525e [buildbucket] no kitchen output file => Infra failure
d73861ca3 [Predator] Increase soft memory for uma sampling profiler.
cd84bd1c5 [buildbucket] refactor build_run_result loading
011e82c92 [Monorail] Fix two issues introduced by presubmit Safari/IE fix
a004798d1 [luci-migration] Surface Infra Failures information.
3a20d2ded Roll recipe dependencies (trivial).
7d82e1b8b Roll recipe dependencies (trivial).
a2eb2e90f [Findit] Flake Analyzer - Run more try jobs.
9a3bd613e Roll recipe dependencies (trivial).
42f912526 Roll recipe dependencies (trivial).
66acb1cd1 Update path in example input in GitFileIsolator test
18b65029f Add a note to the GitRef comment in Tricium AnalyzeRequest
78bd9ceaf [Tricium] Proofread and reformat comments
11d51e0f0 Remove temporary code used to add https to hosts
b6876f848 Fix two minor spelling issues in isolate.go
9aeb8d71f Roll recipe dependencies (trivial).
fffcbaf25 Roll recipe dependencies (trivial).
2d91b6863 [Findit] Instrument bug filing to use CustomFields instead of labels
5a87eb159 Roll luci-go and luci/gae.
37175a98c Roll recipe dependencies (trivial).
965cb361b Revert "Use git.exe and python.exe from %PATH% on Windows"
3ca5b0adb Roll luci-go DEPS
0ae3fcdc2 [test-results] Parse build_id form parameters from uploads.
dd5056295 Roll recipe dependencies (trivial).
896ada564 Roll recipe dependencies (trivial).
71ed7ee94 [som] Add monitoring metrics for alert *groups*
549b91906 Make submodules respect 'condition' for inclusion.
f39b717ce Roll recipe dependencies (trivial).
19eb6271e Roll recipe dependencies (trivial).
75aa8fc6a [Findit] Move swarming related logic only for flake analyzer to a separate module.
6429566ed [Findit] Translate models to BQ schema for test flake & compile failure
8d1731533 Roll recipe dependencies (trivial).
7c8adc760 Roll recipe dependencies (trivial).
a1844f202 [Monorail] Refine the order that we peel off autolinking trailing delimeters.
5409e9f46 Roll recipe dependencies (trivial).
c69c8d781 bot_setup: do not initialize swarming client on multibots
66388a79d Roll recipe dependencies (trivial).
61163aa41 Roll recipe dependencies (trivial).
4c5009d2a Roll recipe dependencies (trivial).
03f5cac69 Use system python for preallocated Swarming bots.
3d0fe245d Roll recipe dependencies (trivial).
0c35aa4a3 [Findit] miscellaneous bug fixes
1cb856336 Roll recipe dependencies (trivial).
f1e5e0076 [doc] Document permissions for cross-project joins
bb4241f99 [Monorail] Fix typo in SQL declarations.
b8e22ed36 Roll recipe dependencies (trivial).
7f8d1f1ab [buildbucket] make timing metrics cumulative
1d7d9ffa0 Roll recipe dependencies (trivial).
6afb9a8c8 Roll recipe dependencies (trivial).
bd4151e59 Roll recipe dependencies (trivial).
d450c3faf Roll recipe dependencies (trivial).
783bc9322 Roll recipe dependencies (trivial).
f2770a571 Roll recipe dependencies (trivial).
e9b8e600b Roll recipe dependencies (trivial).
03db6cde2 [Findit] move all gtest specific logic to services/gtest.py
c4884b963 Use GCE service account when fetching Swarming bot code.
a4f61f59e Roll recipe dependencies (trivial).
1ebe658ce Gen some ssh keys on cros container startup.
382263cf8 Roll recipe dependencies (trivial).
26b8b693e Point swarm*-c7 to chrome-swarming.appspot.com
d0b138cd0 [Predator] Strip parentheses in function name when matching with crash_state.
b35020f73 Allow force-version and migrate-to to accept versions greater than 9
2f0a1df32 Roll recipe dependencies (trivial).
5c77e779e Roll recipe dependencies (trivial).
6cb457523 [Monorail] Add instructions for running one unit test
64291222f Roll recipe dependencies (trivial).
e50870d52 [Monorail] Fix presubmit JS incompatibility
7d8342ee3 Roll luci-go DEPS.
afaeeb0fc [Tricium] Include notify: NONE when posting to Gerrit
a2985c216 [Findit] Refactoring BigQuery schema for analysis events
f8272181b [Monorail] Make autocomplete dropdown accessible for ChromeVox users.
d31763ca4 [Findit] Add bigquery helper that interacts with BQ REST API
d4dc0c29a mac_toolchain: add support for legacy Xcode 8.*
a304231ca Roll recipe dependencies (trivial).
6ec369965 Roll recipe dependencies (trivial).
4d60ec8f8 Roll recipe dependencies (trivial).
07e3fd5ed Roll recipe dependencies (trivial).
390212979 [Findit] Move gtest related logic to gtest.py (1/2)
d5e83d77d Roll recipe dependencies (trivial).
5df250555 Generalize android_docker image building for CrOS as well.
ed978bda5 [buildbucket] use swarming's timestamps
a14f4bfb9 Roll recipe dependencies (trivial).
68f043ea7 Roll recipe dependencies (trivial).
a926b8f75 [Monorail] Autolink text in bigger issues.
63a39573b [som] Update RELNOTES.md
3ae74f454 Roll recipe dependencies (trivial).
4d5af48ff Roll recipe dependencies (trivial).
9d0c9b8b3 Roll recipe dependencies (trivial).
cd4db1329 Add approval_id to FieldDef table.
3ad142a2c [som] Increase client RPC timeouts to 1 minute
eaaa18b94 Roll recipe dependencies (trivial).
09b3ab3ff Roll recipe dependencies (trivial).
64bcfd437 Roll recipe dependencies (trivial).
2faa1f2ac Roll recipe dependencies (trivial).
2e0feb96a Roll recipe dependencies (trivial).
86e40f0c0 Bootstrap gn with clang
9c305f17f [Findit] Ignore IntelliJ project files
17bd7606d [bbroll] Fix other link :)
94c06b37a Add IssueSnapshot table SQL schema and join tables
b0f8ad63f [Findit] Flake Analyzer - New DetermineApproximatePassRatePipeline
89dfd42af Roll recipe dependencies (trivial).
00ac3227d Roll recipe dependencies (trivial).
aab58f01d Roll recipe dependencies (trivial).
c643aedfe [bbroll] Fix canary links.
52f211da7 Monorail: Allow specifying one label in an email address for ticket alerts.
dd7df86a2 [bq events] Update docs with comments about SoM and test-results tables.


TBR=vadimsh@chromium.org

Bug: 808434
Change-Id: Id16a8758257ad0c531b0a590e923b3b4d3442397
Reviewed-on: https://chromium-review.googlesource.com/905830Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      4a92cc9a
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 6034966c
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3bc7426647d70d8ba58b895becc276ac3518917c scheduler recipe module: use classes instead of raw dicts. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I40e68ea96f302536e281d6f0462dd8cea52a8ff4
Reviewed-on: https://chromium-review.googlesource.com/905601
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: 's avatarRecipe Roller <recipe-roller@chromium.org>
      6034966c
    • Tom Anderson's avatar
      Add target_cpu and target_cpu_only to gclient base config · 2dd54735
      Tom Anderson authored 
      BUG=807986
R=dpranke

Change-Id: I6b7e94d489a228c5dde23a9b6c7d6f58ce73b180
Reviewed-on: https://chromium-review.googlesource.com/905285Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
      2dd54735
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 2b51c930
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b80999e32c0692d0ab2fe00722c2550f8b74c0ac raw_io: fix to use splitlines for add_output_log (tikuta@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia4b2f1c2d20e4e8f511cc12cc8fca9391382a42e
Reviewed-on: https://chromium-review.googlesource.com/905593Reviewed-by: 's avatarRecipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
      2b51c930
    • Andrii Shyshkalov's avatar
      Revert "bot_update: allow rebasing the patch onto an older revision." · 5eab58ee
      Andrii Shyshkalov authored 
      This reverts commit fa573785.

Reason for revert: broke CQ on branches.
Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/28220

Original change's description:
> bot_update: allow rebasing the patch onto an older revision.
>
> When applying a rebase, we normally go from an older base commit to a newer one.
>
> A ---- B ---- C ---- D -origin/master
>                \
>                 E -branch
>
> In this case, `git rebase D` would certainly work as expected. However,
> writing `git rebase B` would NOT get us to the following state:
>
> A ---- B ---- C ---- D -origin/master
>         \
>          E' -branch
>
> In fact, it would have no effect.
>
> This article http://matthew-brett.github.io/pydagogue/rebase_without_tears.html
> explains the general invocation as
> > `git rebase --onto <graft-point> <exclude-from> <include-from>`
> > If you don’t specify --onto, <graft-point> defaults to <exclude-from>
>
> So what's happening is, by writing `git rebase B` we're rebasing onto B,
> excluding commits that are in B. Commit C is not "in" B so it is kept and we're
> back to the starting point.
>
> So I suggest to change the invocation to `git rebase --onto B origin/master`,
> which rebases onto B, excluding commits that are in origin/master. This works
> more generally and allows rebasing "backwards".
>
> Bug: None
> Change-Id: I68e4d805811530b585550bc75099354fef4e9c15
> Reviewed-on: https://chromium-review.googlesource.com/904004
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>

TBR=iannucci@chromium.org,tandrii@chromium.org,oprypin@chromium.org

Change-Id: I7243641d84428bf4504ee798bf31ad0afbfd4865
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/905862
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      5eab58ee
    • Robert Iannucci's avatar
      [luci-auth] Add statically-linked luci-auth CLI tool. · f3b152d2
      Robert Iannucci authored 
      R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 809645
Change-Id: I21ad49fa03630955eca6ecd531445bc4acf0c0c6
Reviewed-on: https://chromium-review.googlesource.com/905822Reviewed-by: 's avatarVadim Shtayura <vadimsh@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      f3b152d2
  17. 06 Feb, 2018 7 commits
  19. 05 Feb, 2018 1 commit
  21. 02 Feb, 2018 3 commits
  23. 01 Feb, 2018 2 commits