Commits · fbb06aaab10757b082ca450da5ba146182eef622 · Linshizhi / Chromium_Depot_tools

11 Jun, 2018 5 commits

gclient: Use only recursedeps to decide whether to process a dependency. · fbb06aaa

Edward Lemur authored Jun 11, 2018

Bug: 839925
Change-Id: If86cfbdbea795b6da53dec1ea6e44c5af8a3b846
Reviewed-on: https://chromium-review.googlesource.com/1086270Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fbb06aaa

Improve post_build_ninja_summary.py's incremental build handling · 6be8afd5

Bruce Dawson authored Jun 11, 2018

post_build_ninja_summary.py detects a new incremental build by looking
for the end time stamps to go backwards. This means that repeated builds
that have a single long step will not be reliably detected and will, in
some cases, be missed entirely. This hits me sometimes when doing link
testing - delete an output DLL, rebuild, and the old results may be
displayed again.

This change updates the script to check for a different duration for an
existing record as well as an earlier end time should handle almost all
cases.

This also renames the targets local variable to avoid confusion due
to the targets member variable of the Targets class.

Bug: chromium:787983
Change-Id: I60a371df75d6cb7a55bd46b38156cb109feb8f15
Reviewed-on: https://chromium-review.googlesource.com/1061413
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

6be8afd5

Roll recipe dependencies (trivial). · 9f107316

recipe-roller authored Jun 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/11db7d01eaa21d7706966a532ee36bddc9000e9a recipe_engine: Remove Gitiles backend from fetch. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id160150697f6d1be129605c21ce1b22e8408510a
Reviewed-on: https://chromium-review.googlesource.com/1095835Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

9f107316

Add --log-file arg to post_build_ninja_summary.py · a10370c4

Daniel Bratell authored Jun 11, 2018

Sometimes the log files are not named .ninja_log and then it's
good if you can give the script the actual name and path.

Change-Id: I59e9812c81a83ffac3ecdc8b29887e99bf71b60f
Reviewed-on: https://chromium-review.googlesource.com/1012112Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>

a10370c4

Roll recipe dependencies (trivial). · d21878d7

recipe-roller authored Jun 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/40699af88c76d65ef1b3d364de221611603e2dc6 [cipd] Fix the cipd ensure output handling (phosek@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6a19c0a13fafdc06b572a4dfb7d403a13a1baee
Reviewed-on: https://chromium-review.googlesource.com/1094705
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

d21878d7

09 Jun, 2018 1 commit

Roll recipe dependencies (trivial). · c3e514ed

recipe-roller authored Jun 09, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b5ea6a8309ecc6cde288f1f97667e495e1d3466d [buildbucket] Make gitiles_commit singular (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie72c0068bbf88238b047453a0c63e3edd5584227
Reviewed-on: https://chromium-review.googlesource.com/1094039Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

c3e514ed

08 Jun, 2018 3 commits

Remove dbghelp.dll hack from packaging script · 3fb5aa7b

Bruce Dawson authored Jun 08, 2018

The script that packages the Visual Studio toolchain had special code to
handle grabbing dbghelp.dll from the VS install and copying it to the
Debuggers directories. This was necessary around VS 2017 RTM to handle
/debug:fastlink but it now causes failures due to mismatched DLLs
leading to a missing ordinal. The hack shouldn't be needed anymore
because we no longer depend on /debug:fastlink (lld!) and because the
Debuggers package is assumed to have been updated to handle VS 2017 by
now.

Bug: 846313
Change-Id: I2b5fd87aaa785ce24a0905d70e7e586ff4838b1c
Reviewed-on: https://chromium-review.googlesource.com/1086990Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

3fb5aa7b

Reland "Reland "Expand variables in gclient flattened output."" · e05f18d4

Edward Lemur authored Jun 08, 2018

This is a reland of ff622244
should_process was set to None in the previous attempt, so CIPD dependencies were not processed.
This CL fixed that.

Original change's description:
> Reland "Expand variables in gclient flattened output."
>
> This is a reland of a32f98e6
>
> Original change's description:
> > Expand variables in gclient flattened output.
> >
> > Bug: 848990
> > Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> > Reviewed-on: https://chromium-review.googlesource.com/1085996
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
>
> Tbr: agable@chromium.org
> Bug: 848990
> Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
> Reviewed-on: https://chromium-review.googlesource.com/1085975
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 848990
Change-Id: Ic804be1b84bf8402a741a4189b60372075dfb6f3
Reviewed-on: https://chromium-review.googlesource.com/1087368Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e05f18d4

Add an `--ignore-current` flag to `git cl owners` to start from scratch. · 8e6f58c7

Sidney San Martín authored Jun 08, 2018

Change-Id: Iee6d7cf87281d4ca0abf71a7109f678d5cbbc9f1
Reviewed-on: https://chromium-review.googlesource.com/1091801Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>

8e6f58c7

07 Jun, 2018 1 commit

gclient: Add a test to make sure we're syncing CIPD dependencies. · efe4f897

Edward Lemur authored Jun 07, 2018

Bug: 849374
Change-Id: I5654ed65843c6dae6b7dbee10a40aa35e16803dc
Reviewed-on: https://chromium-review.googlesource.com/1087390
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

efe4f897

06 Jun, 2018 1 commit

Roll mac_toolchain to 796d2b92c · e89dcf7d

Sergey Berezin authored Jun 06, 2018

Relevant changes:
  796d2b92c [mac_toolchain] Always run xcodebuild commands in the correct Xcode context
  42953a5b3 [mac_toolchain] Bug fixes for Xcode 10 and DevToolsSecurity

TBR=maruel@chromium.org

Bug: 849728, 846485
Change-Id: Ifbe6af428d609f4530ba6dcb19c16ebab9432af5
Reviewed-on: https://chromium-review.googlesource.com/1088231Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

e89dcf7d

05 Jun, 2018 4 commits

Revert "Reland "Expand variables in gclient flattened output."" · b9907703

John Budorick authored Jun 05, 2018

This reverts commit ff622244.

Reason for revert: spec revert for crbug.com/849374

Original change's description:
> Reland "Expand variables in gclient flattened output."
> 
> This is a reland of a32f98e6
> 
> Original change's description:
> > Expand variables in gclient flattened output.
> >
> > Bug: 848990
> > Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> > Reviewed-on: https://chromium-review.googlesource.com/1085996
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 
> Tbr: agable@chromium.org
> Bug: 848990
> Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
> Reviewed-on: https://chromium-review.googlesource.com/1085975
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I89ffb80893be72f60043e8a6e02f6c0fb6fe5cc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848990
Reviewed-on: https://chromium-review.googlesource.com/1086747Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

b9907703

Reland "Expand variables in gclient flattened output." · ff622244

Edward Lemur authored Jun 05, 2018

This is a reland of a32f98e6

Original change's description:
> Expand variables in gclient flattened output.
>
> Bug: 848990
> Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> Reviewed-on: https://chromium-review.googlesource.com/1085996
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Tbr: agable@chromium.org
Bug: 848990
Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
Reviewed-on: https://chromium-review.googlesource.com/1085975Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ff622244

Revert "Expand variables in gclient flattened output." · 01cb5105

Edward Lesmes authored Jun 05, 2018

This reverts commit a32f98e6.

Reason for revert:
Doesn't work when there are variables which definition includes other variables, e.g.:

'cros_download_vm': '"{cros_board}" == "amd64_generic"',

Original change's description:
> Expand variables in gclient flattened output.
> 
> Bug: 848990
> Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> Reviewed-on: https://chromium-review.googlesource.com/1085996
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I7e81000e92aa352e45b420845bb1dcc8572f1962
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848990
Reviewed-on: https://chromium-review.googlesource.com/1085974Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

01cb5105

Expand variables in gclient flattened output. · a32f98e6

Edward Lemur authored Jun 04, 2018

Bug: 848990
Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
Reviewed-on: https://chromium-review.googlesource.com/1085996Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a32f98e6

04 Jun, 2018 3 commits

[git-cl-try] Handle absence of builds · 23d75d2d

Nodir Turakulov authored Jun 04, 2018

If there are no builds in build search response, the response is {}.
Handle this case.

R=qyearsley

Bug: 849361
Change-Id: I9f0472e140698a1d1c5b98b301bc562ac457785b
Reviewed-on: https://chromium-review.googlesource.com/1085899Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

23d75d2d

Fix buildbucket bug filing instructions · 9ac59795

Nodir Turakulov authored Jun 04, 2018

Use Infra>Platform>Buildbucket component, not Infra-BuildBucket label.

R=qyearsley

Bug: 849361
Change-Id: I27706d93097a20c6927ffa5405550bb63aa519dd
Reviewed-on: https://chromium-review.googlesource.com/1085898Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

9ac59795

Include "fuchsia" as a known "deps_os" value · 518bb684

Sergiy Byelozyorov authored Jun 03, 2018

This fixes an issue where "--deps=all" syncs everything but fuchsia.

R=machenbach@chromium.org, tandrii@chromium.org, wez@chromium.org

Bug: 848676
Change-Id: I782184b615968140d0e9a0146169fa12a9ebe0c5
Reviewed-on: https://chromium-review.googlesource.com/1084211Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

518bb684

01 Jun, 2018 2 commits

[led] Roll to 7ba61969ccbe1f9679661555f72ca947da508a70 · 88087bad

smut authored Jun 01, 2018

Relevant changes:
7ba61969c Update Swarming clients to hit /_ah/api instead of /api
4d67b77ab [led] Allow `led get-swarm` to read tasks with isolated recipes.

Bug: 805543
Change-Id: Iffad3818591a61572d347af95b7072e0811619af
Reviewed-on: https://chromium-review.googlesource.com/1083619Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: smut <smut@google.com>

88087bad

Add ability to whitelist bot accounts as valid authors · 621fe6f9

Sergiy Byelozyorov authored May 26, 2018

Example usage: https://crrev.com/c/1074367

R=machenbach@chromium.org

Bug: 831171
Change-Id: Ic3deff5040a268e10161ccce635f06b7f8c08d36
Reviewed-on: https://chromium-review.googlesource.com/1074368Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

621fe6f9

31 May, 2018 2 commits

[presubmit] Add python formatting check · 0ae14e9a

Nodir Turakulov authored May 31, 2018

Add check_python parameter to CheckPatchFormatted to check that python
files are well formatted.

Change-Id: Ibd20d5ec9d1d5142a26f7f4cd5f05c51223da6ca
Reviewed-on: https://chromium-review.googlesource.com/1081342
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

0ae14e9a

Fix git cl format --python --full · af43f40e

Nodir Turakulov authored May 31, 2018

Make `git cl format --python -full --dry-run` return non-zero exit code if
files are not well formatted.

Make `git cl format --python -full --diff` print diff, rather than new file
contents.

Change-Id: I666d360051563898d3508d776817bf9a61433cb0
Reviewed-on: https://chromium-review.googlesource.com/1081340Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

af43f40e

29 May, 2018 1 commit

Update windows git to 2.17.1 · cf4aced3

Aaron Gable authored May 29, 2018

This is for security updates related to
CVE 2018-11235
CVE 2018-11234
https://public-inbox.org/git/xmqqy3g2flb6.fsf@gitster-ct.c.googlers.com/

Bug: 847597
Change-Id: I3b2d6b7bf9fe2d93bdc375903357f07f4fff8573
Reviewed-on: https://chromium-review.googlesource.com/1077307Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

cf4aced3

25 May, 2018 2 commits

Roll recipe dependencies (trivial). · f16fdf31

recipe-roller authored May 25, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/10f67fe223a7973a95bc5fff219d1a7a3d95a326 [recipe_modules] Create Tricium module (juliehockett@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8037b9c0bed59dc082de43fc3824ce6bb6842a1c
Reviewed-on: https://chromium-review.googlesource.com/1073197Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

f16fdf31

Roll recipe dependencies (trivial). · 4d2e8bff

recipe-roller authored May 25, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c51413ab9d4c5ed5c3db8117b80afe64e54016b4 [recipe_api] Add content type for source manifests (mknyszek@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I019b19c164ccf0507d6864d08fa6ed5887f34930
Reviewed-on: https://chromium-review.googlesource.com/1072326Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

4d2e8bff

24 May, 2018 8 commits

Remove cq_client from depot_tools · af2ffd93

Aaron Gable authored May 24, 2018

This library is no longer used by anything in depot_tools.

Bug: 770408
Change-Id: I8f0a99f73cf9c52731994c830085678ca652d2c4
Reviewed-on: https://chromium-review.googlesource.com/1072491Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

af2ffd93

Roll recipe dependencies (trivial). · b1a5e452

recipe-roller authored May 24, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/611cfbdc328b50144e2790ed1e4b9db24adb9eea [raw_io] Make it succeed even with read only files. (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I706661a48211e87e395d5cf148a4a02ba3ead613
Reviewed-on: https://chromium-review.googlesource.com/1072549Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

b1a5e452

Remove Rietveld-only apply_issue · b09e03ec

Aaron Gable authored May 23, 2018

This script only works (worked) for Rietveld issues, which
effectively no longer exist. It serves no purpose anymore.

Bug: 770408
Change-Id: Ic93ab3ce90d9c35b3bf5189e2beb4aa0c3983d44
Reviewed-on: https://chromium-review.googlesource.com/1070859Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

b09e03ec

Remove more Rietveld support from presubmit · 4b23a2c6

Aaron Gable authored May 24, 2018

This simplifies future removals of unnecessary code from git-cl.

Bug: 770408
Change-Id: I20329fb6d93b349bf2e9f4aebc795b3f7ef0b646
Reviewed-on: https://chromium-review.googlesource.com/1070588
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

4b23a2c6

Roll mac_toolchain to 478dc9dbb · 0115c356

Justin Cohen authored May 24, 2018

Relevant changes:
  [mac_toolchain] Always call runFirstLaunch for Xcode 9+.

Bug: 841910
TBR=iannucci@chromium.org
Change-Id: I3f4b8fb793e66315492f8e53832e0ac9d00ceb0c
Reviewed-on: https://chromium-review.googlesource.com/1072007
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

0115c356

Remove old git-cherry-pick-upload documentation · 48fe7029

Aaron Gable authored May 23, 2018

The command itself was removed in
https://chromium-review.googlesource.com/693339

Bug: 770408
Change-Id: Ie3006b75313715c395357efa6ffc67348e192c5c
Reviewed-on: https://chromium-review.googlesource.com/1070757Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

48fe7029

Revert recent gclient.py changes to fix Chrome releases. · 4e9b50ab

Michael Moss authored May 24, 2018

Reason for revert: This is breaking official release scripts, which have long
used "None" URL functionality to allow gclient commands to run against
"local" DEPS (buildspec) files. Please do not remove this behavior.

This reverts the following commits:
  ebdd0db4: "gclient: Remove URLs from hierarchy."
  54a5c2ba: "gclient: Refactor PrintRevInfo"
  083eb25f: "gclient: Don't allow URL to be None."

BUG=846194

TBR=agable@chromium.org,ehmaldonado@chromium.org

Change-Id: Ibdd5581889bd4afd86474199c7b64555f01bbbca
Reviewed-on: https://chromium-review.googlesource.com/1070893
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

4e9b50ab

gerrit/api.py: Add get_revision() helper. · 1f156687

Andrew Grieve authored May 24, 2018

Allows easily getting at more than just the commit message.
I intend to look at the author to whitelist bots from binary size
checks (initially).

Bug: 702625
Change-Id: I684fdfacc88635ec4849216c74183f63f9d54810
Reviewed-on: https://chromium-review.googlesource.com/1070483
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

1f156687

22 May, 2018 4 commits

gclient: Remove URLs from hierarchy. · ebdd0db4

Edward Lemur authored May 21, 2018

Bug: 839925
Change-Id: I66d0bd074433288e780e1bdde9ebfce4fa85db0f
Reviewed-on: https://chromium-review.googlesource.com/1067496Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ebdd0db4

gclient: Refactor PrintRevInfo · 54a5c2ba

Edward Lemur authored May 22, 2018

Bug: 839925
Change-Id: I9d1b2572676a7d61862382f6882622521d28ef97
Reviewed-on: https://chromium-review.googlesource.com/1068250Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

54a5c2ba

Print access errors using logging.error · 398fb44e

Ryan Harrison authored May 22, 2018

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1058722
changed the behaviour of reporting access errors to no longer
interleave them throughout the output, but instead batch them
together.

This CL had the side effect of changing the way the errors are printed
from using logging.error to print. This means that the errors are now
printing to stdout instead of stderr. This is causing personal scripts
I have for generating reports to fail, since they filtered out stderr.

Change-Id: I664f6166c55f8d20d3c35b63eda695335ab7f8a6
Reviewed-on: https://chromium-review.googlesource.com/1069213
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

398fb44e

roll-dep: Add tests. · 428e7c14

Edward Lemur authored May 22, 2018

Bug: 829134
Change-Id: Ifa4dc5572a17c9f2a3ab4bb04765106b1563ecae
Reviewed-on: https://chromium-review.googlesource.com/1065081Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

428e7c14

18 May, 2018 1 commit

gclient: Don't allow URL to be None. · 083eb25f

Edward Lemur authored May 17, 2018

Bug: 839925
Change-Id: I5a559db846ac19e3c61e77f3019c7d5362beccba
Reviewed-on: https://chromium-review.googlesource.com/1063029Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

083eb25f

17 May, 2018 2 commits

gclient: Actually fix roll-dep. · 8fe4d8cb

Edward Lemur authored May 17, 2018

Bug: 839925
Change-Id: I5cb6655309d6aa8dada7e6bd245d859593fb055f
Reviewed-on: https://chromium-review.googlesource.com/1064809
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

8fe4d8cb

gclient: Fix roll-dep. · b496b6a0

Edward Lemur authored May 17, 2018

Bug: 839925
Change-Id: I5a56ad03866bd0b8f7d43bb3a643372d7b66343c
Reviewed-on: https://chromium-review.googlesource.com/1064692Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b496b6a0