Commits · f819411f2a3c1eef1e8c5f67fee84314adae4f2f · Linshizhi / Chromium_Depot_tools

30 Nov, 2020 2 commits

[dirmd] Bump to 8d8dfbbee8184bf5f1c90c875e80d0dd58659f03 · f819411f

Edward Lesmes authored Nov 30, 2020

To pick https://chromium-review.googlesource.com/c/infra/infra/+/2521159

Change-Id: Icff019c71c87a3e1e288c4cc1c5ebace7a372b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2564645
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

f819411f

Reland "repo: auto-update depot_tools when used" · eb386eb3

Mike Frysinger authored Nov 30, 2020

This is a reland of 19512276.
It includes an update to .gitattributes for recipes.

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

eb386eb3

26 Nov, 2020 2 commits

Revert "repo: auto-update depot_tools when used" · dc7b108d

Andrii Shyshkalov authored Nov 26, 2020

This reverts commit 19512276.

Reason for revert: broke ART bots.
Bug: 1153114

Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

TBR=vapier@chromium.org,ehmaldonado@chromium.org,mmortensen@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,mmortensen@chromium.org

Change-Id: Ic0ac9155e3acde87966f518213a5a8440e167295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560955Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

dc7b108d

Roll out new goma client binary VERSION=209 · e62621d2

Yoshisato Yanagisawa authored Nov 26, 2020

Bug: b/173566348
Change-Id: I175386edb044197af00ee78f78003576d176873e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561706Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

e62621d2

25 Nov, 2020 5 commits

Roll recipe dependencies (trivial). · b9a5e83e

recipe-roller authored Nov 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fd7a6b318a4b22b708cf15784814e4f236005ff4
fd7a6b3 (qyearsley@chromium.org)
Expand and edit the recipe user guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48f7e55bd133813d7777f09f1840314532a3ac53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560670Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b9a5e83e

repo: auto-update depot_tools when used · 19512276

Mike Frysinger authored Nov 25, 2020

Since gclient automatically syncs this checkout when used,
have repo do the same for CrOS users.

Bug: 1148984
Test: ran and saw it auto-update when used externally
Test: ran and saw it not auto-update when used inside of a repo checkout
Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

19512276

Roll recipe dependencies (trivial). · 36f2a962

recipe-roller authored Nov 25, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/212297d9077c109c05255ce5d23120840c6f398a
  212297d (olivernewman@google.com)
      [file] Add include_log param to write_json() and read methods

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I53c72e02a4a04392c43e2d0a8609c177df01d7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560668Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

36f2a962

git cl comments: shorten long URLs if possible. · a3762a90

Andrii Shyshkalov authored Nov 25, 2020

R=ehmaldonado

Before:
  https://chromium-review.googlesource.com/c/2552792/3/cv/internal/gerrit/gerritfake/fake.go#321
After:
  https://crrev.com/c/2552792/3/cv/internal/gerrit/gerritfake/fake.go#321
Change-Id: Ie6044e2743c4359bc30c98d8915edd9119d4a386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556837
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>

a3762a90

gerrit_client: validate --param options · 8820ab85

Mike Frysinger authored Nov 25, 2020

Passing an invalid --param option in leads to a crash lower down in
the gerrit modules which can be hard to trace back to the original
error: the user forgot the "key" in the "key=value".

Change-Id: I6fe5fab0fad15cf8d25173e0f1c8ea130efc44ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2558651Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

8820ab85

24 Nov, 2020 4 commits

[owners] Add SuggestOwners to OwnersClient. · 295dd187

Edward Lesmes authored Nov 24, 2020

Gerrit API doesn't provide the score for
an owner of a path, so we can't use the
same algorithm when suggesting owners.

This change introduces a new algorithm to
select the smallest set of at least 2
owners that can approve the change.

Change-Id: If620073bdf63633f171c1480e345dbaf75e9f575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556479Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

295dd187

[owners] Sort owners by distance · 64e80769

Edward Lesmes authored Nov 24, 2020

Change-Id: Id10af7bb2fa821c369952402853fae5c847b2f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556478
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

64e80769

[owners] Add tests for GetFilesApprovalStatus · 4c5dd5d8

Edward Lesmes authored Nov 24, 2020

Change-Id: I28b061ceb44c032e2c9eb7da22750a7c25f50bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2556477
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

4c5dd5d8

Roll recipe dependencies (trivial). · b35dd76c

recipe-roller authored Nov 24, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6d51a052a45b041e4163a01f0b6f9035f4d07b2a
  6d51a05 (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3639a6a6b96cb121888fbb00512eb956ac245ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2557437Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b35dd76c

23 Nov, 2020 1 commit

[tryserver] Report affected files via property · 260eb0f6

Nodir Turakulov authored Nov 23, 2020

To enable aggregate analysis on changed files in BigQuery, conditionally
report them via an output property.

This CL causes a non-trivial roll only because of the sorting.

Recipe-Nontrivial-Roll: build
Bug: 1151655
Change-Id: Ie7a6c622196143c1aef07af9a9a356fb4202ea56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2553349Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

260eb0f6

20 Nov, 2020 4 commits

Replace non-inclusive terms · 9c0dc302

Josip Sokcevic authored Nov 20, 2020

Bug: 1118410, 1118413, 1118422, 1118424, 1118426
Bug: 1118428, 1118430, 1118434, 1118438, 1118442
Bug: 1118453, 1118454
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build
Change-Id: I43e6305f8c3136774f01b57f12bb442bcb863371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551388
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

9c0dc302

Improve the readability on variable name added in crrev/c/2528670 · 26ced490

Xinan Lin authored Nov 20, 2020

Bug: 1146487
Change-Id: I60476ac60ede4810f63403791386128508631db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551386
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Xinan Lin <linxinan@chromium.org>

26ced490

Roll recipe dependencies (trivial). · 330b6055

recipe-roller authored Nov 20, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5f437dc5800881abe0f78cf3b7c976817586a3ef
  5f437dc (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I556968d2dd7c8600ba2ad8453a049549b64e6a10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551499Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

330b6055

[owners][git-cl] Use owners client to show all owners for a file. · eeca9c6e

Edward Lesmes authored Nov 20, 2020

Change-Id: I04949d95ca466452a58ea91cf2db86852c0621bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551378
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

eeca9c6e

19 Nov, 2020 5 commits

[owners] Implement GetFilesApprovalStatus for OwnersClient. · e7d1862b

Edward Lesmes authored Nov 19, 2020

Add a utility method to check approval status for files
when no change has been created yet.

Change-Id: I4cc47e2f598cedc7b7aab68bed356bd3ae566cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551373
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>

e7d1862b

[owners] Validate owners config in Depot Tools client. · b4721682

Edward Lesmes authored Nov 19, 2020

Change-Id: Ia9cb19d2b1f776c41ef7e96e6a0ebfb0fcd41344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2548029
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

b4721682

Fix testRebase · 2f8e0fa4

Gavin Mak authored Nov 19, 2020

Running git rebase --continue may launch a text editor for editing commit messages. This causes testRebase to hang or to fail completely when running locally.
Setting GIT_EDITOR to ':' suppresses this.

Bug:1149625
Change-Id: Ia4a0b6564b198be945866cb890607ac8966c468f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2551375
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

2f8e0fa4

[resultdb] use requests.Session in rdb_wrapper · cc2fe9b7

Scott Lee authored Nov 19, 2020

requests.post() creates a new HTTP connection for each call.
It makes presubmit checks slower and timed out.
This CL updates rdb_wrapper to use requests.Session() to use
a connection pool for Sink requests.

Change-Id: Id02ecce85898ae15993d53df17473bb5dfb7e89f
Bug: 1145762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532895
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>

cc2fe9b7

Revert "Improve the setup logic for tryserver" · 55896522

Xinan Lin authored Nov 19, 2020

This reverts commit 44473361.

Reason for revert: Breaks infra repo. See crrev.com/c/2548285

Original change's description:
> Improve the setup logic for tryserver
>
> If the given change does not have a valid gerrit host name, stop
> initializing the tryserver module.
> Also polished the variable name and docstr added in crrev/c/2528670.
>
> Recipe-Nontrivial-Roll: infra
> Bug:1146487
> Change-Id: I38193b25d37c724fd41d898eb020237fbf7cecdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2544000
> Commit-Queue: Xinan Lin <linxinan@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

TBR=nodir@chromium.org,tandrii@google.com,recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com,linxinan@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: I3871866454adab816ab5549f8273fe16af2d9adb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1146487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2548409Reviewed-by: Xinan Lin <linxinan@chromium.org>
Commit-Queue: Xinan Lin <linxinan@chromium.org>

55896522

18 Nov, 2020 5 commits

Improve the setup logic for tryserver · 44473361

Xinan Lin authored Nov 18, 2020

If the given change does not have a valid gerrit host name, stop
initializing the tryserver module.
Also polished the variable name and docstr added in crrev/c/2528670.

Recipe-Nontrivial-Roll: infra
Bug:1146487
Change-Id: I38193b25d37c724fd41d898eb020237fbf7cecdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2544000
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>

44473361

[owners] Add tests for Depot Tools owners client. · 829ce021

Edward Lesmes authored Nov 18, 2020

Change-Id: I988f5b866560d5839a1121c7129099ffe125fdce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2545108Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

829ce021

Roll recipe dependencies (trivial). · c21b8948

recipe-roller authored Nov 18, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/061a2dcf8d72817b52b2957f7b643f5e2aa60c84
  061a2dc (yiwzhang@google.com)
      [luciexe] stop using FileObjectPOSIX when sending data to logdo...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id8c2ca3473cee94e67a178b435ccd642d7651b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2547471Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c21b8948

Roll recipe dependencies (trivial). · 484196b7

recipe-roller authored Nov 18, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/2cc9f6a9eaab1d5c82cb3efd5b1cab85035b01af
  2cc9f6a (yiwzhang@google.com)
      [tests] Increase the waiting time for pid file from 10 to 20

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9cd5996e51fcd266f23c9d83c5ca99a63657042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2547467Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

484196b7

Roll out new goma client binary VERSION=208 · 19da6ff2

Yoshisato Yanagisawa authored Nov 18, 2020

Bug: b/171358097
Change-Id: I6e923ad877e2765ef36cfb48089682893927466a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2546441Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

19da6ff2

17 Nov, 2020 4 commits

Roll recipe dependencies (trivial). · 868f530e

recipe-roller authored Nov 17, 2020

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/13d238ccaa7d6f54d04205aeb8e30a47558e53de
13d238c (eugenebut@chromium.org)
Add Objective-C Style Tricium analyser

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib00f8c541d1d6d747a227678e739a7733878c7f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2545040Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

868f530e

add support for main in git_cache · 90b4c0f7

Anthony Polito authored Nov 17, 2020

Change-Id: I32dcd812b41518bd8e2ca50eae1862611ff577de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2528797Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>

90b4c0f7

Reland "Add option to git cl st to sort by committer date" · 9abde8c3

Sigurd Schneider authored Nov 17, 2020

This is a reland of 9ca89ac1

Original change's description:
> Add option to git cl st to sort by committer date
>
> Some developers want to see the branches with recent commits first.
> This CL adds the option --dateorder to git cl st which sorts branches
> by the committer date of the most recent branch.
>
> Change-Id: Ibdf3fc35ea784521a3e99b374535f822bb83a55e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2521573
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Change-Id: I974ac297fcf8652855b101f58a98b3cd122fce36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532835
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>

9abde8c3

[owners] Implement GetChangeApprovalStatus for Depot Tools · d4e6fb65

Edward Lesmes authored Nov 17, 2020

Change-Id: I2d24e4e02e099381e10b29c7e9a09d530cde4a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2536817Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d4e6fb65

16 Nov, 2020 1 commit

Make bot_update and tryserver module not crash for multiple changes · da73999f

Xinan Lin authored Nov 16, 2020

Currently bot_update and tryserver crashes at initialization step if
the input contains multiple gerrit changes. This is not friendly for
CrOS CLs, e.g. crrev.com/c/2536761.

This CL moves the “crash” out of initialization, thus the consumer
of these modules could control which gerrit change to pass to bot_update
and tryserver.

This CL does NOT enable the modules here to support multiple patchset,
but allows consumers to choose one.

Bug:1146487
Change-Id: Iec46a8041189912e34da9bc5e8ff4611123ec9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2528670
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>

da73999f

13 Nov, 2020 2 commits

[resultdb] Update rdb version · fd5c1983

Chan Li authored Nov 13, 2020

To include changes:
- https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2536026
- https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2535098

Bug: 1147548
Change-Id: I504a936760e8aafb926b9c1f622610e03207882c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2538208Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

fd5c1983

[depot_tools] Make try-results fetch recent dry-runs · e61ccc59

Gavin Mak authored Nov 13, 2020

Running git cl try-results fetches the latest patchset which may be a trivial change, e.g. rebase or commit message change.
This change allows try-results to get the result of patchsets equivalent to the latest and returns their results.

Bug: 774179
Change-Id: Iec2fea102597773e24c2e887f19282f14c123e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532899Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

e61ccc59

12 Nov, 2020 2 commits

roll_dep.py: Support upstream branch being origin/main. · 5157fbfb

Corentin Wallez authored Nov 12, 2020

Bug: None
Change-Id: I93df760f8d5431e55ef337c05634e7f26ad69fd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2512921
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

5157fbfb

git cl: remove check for likely wrong identities. · f0517095

Andrii Shyshkalov authored Nov 12, 2020

This was important 3+ years ago when we were migrating to Gerrit.
It is no longer important, and probably confusing to non-Googlers
and Googlers alike.

R=dpranke, maruel
TBR=ehmaldonado

Bug: 1148065
Change-Id: I79ad71b5afb9adac286780c2093b01f656491918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2534850
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

f0517095

11 Nov, 2020 3 commits

Add a python2 shim under python2-bin/ · 26cd974a

Henrique Ferreiro authored Nov 11, 2020

Similarly to how python3 is available at python-bin/, this will allow
developers to opt-in to a depot_tools provided python2.

Bug: 1109180
Change-Id: I872eaa1289bb477da73373e99f5e6188a87d39dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2512906Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>

26cd974a

Retry CIPD client download on Linux / macOS · 1607bf45

Matt Kotsenas authored Nov 11, 2020

Transient network conditions can cause the CIPD client download to fail,
so add a retry to the download.

When using `wget` we additionally retry usually fatal errors like
"connection refused" via `--retry-connrefused`. `curl` also has that
parameter, but it was added more recently in version 7.52.0, which isn't
available on supported platforms like Ubuntu 16.04. Once we raise the
minimum supported version of curl, we should add that parameter as well.

In either case, we retry 3 times and wait 5 seconds between each try,
which matches the retries recently added for Windows.

Bug: 1145741
Change-Id: Ib73bb3413ba4d5251c2b027a87dabd1378ab6c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532896Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Matthew Kotsenas <mattkot@microsoft.com>

1607bf45

[cipd] Update cipd and vpython to latest versions. · c135bfa0

Vadim Shtayura authored Nov 11, 2020

R=tandrii@chromium.org
BUG=1124112

Change-Id: Ie303ebfc8d6b94645862d69fcd40fadbaf3d164a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2532900Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

c135bfa0