Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 05 Mar, 2013 1 commit
    • dpranke@chromium.org's avatar
      Use author as determined from scm if we can not get it from rietveld · f6ddfa4b
      dpranke@chromium.org authored 
      Until an issue is uploaded to Rietveld, we don't know the official
email address to use for an owners check. There are three ways to fix
this: we could attempt to log in to rietveld prior to doing the check
and extract the address to use, or we could use ~/.last_codereview_email_address,
or we can use the email address we can determine from the checkout.

All three options have flaws; the first is particularly awkward since there
doesn't seem to be a good way to fetch the email without posting an issue.
The second is flawed if we use different addresses for different repos,
and the third is flawed if the checkout's email address is different from
the rietveld address, or if it is anonymous.

However, since this is only being used for owners checks (in this case),
anonymous checkouts probably don't matter, and hopefully the cases where
the email addresses differ are rare.

R=maruel@chromium.org
BUG=118388, 150049


Review URL: https://chromiumcodereview.appspot.com/12377023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@186259 0039d316-1c4b-4281-b951-d872f2087c98
      f6ddfa4b
  3. 04 Mar, 2013 1 commit
  5. 28 Feb, 2013 2 commits
  7. 27 Feb, 2013 1 commit
  9. 26 Feb, 2013 1 commit
  11. 23 Feb, 2013 1 commit
    • dpranke@chromium.org's avatar
      Change the OWNERS check to print files, not directories · 6b1e3ee9
      dpranke@chromium.org authored 
      Currently, when we run the OWNERS check, we print the list of directories
that contain the relevant OWNERS files for any modified files in a change
still needing approval. 

This has two problems:

1) if we bubble all the way up to the top level OWNERS, we print "" instead of
"src/" or something more useful (bug 157191)

2) for OWNERS files that contain per-file set-noparent entries (like changes to IPC messages), this can be really confusing because an owner of other stuff in the directory might've approved things already.

This change will now print the list of files in the CL that are still unapproved.
This might be a lot more verbose (since you get N lines rather than 1 for N files in a given directory), but hopefully it'll be clearer in the two cases above.

Also, this change takes care of some lingering clean-up in the code to rename some methods to be clearer.

R=maruel@chromium.org
BUG=157191




Review URL: https://chromiumcodereview.appspot.com/12314044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@184219 0039d316-1c4b-4281-b951-d872f2087c98
      6b1e3ee9
  13. 22 Feb, 2013 1 commit
  15. 21 Feb, 2013 1 commit
  17. 20 Feb, 2013 1 commit
  19. 19 Feb, 2013 2 commits
  21. 18 Feb, 2013 1 commit
  23. 17 Feb, 2013 2 commits
  25. 15 Feb, 2013 4 commits
  27. 13 Feb, 2013 1 commit
  29. 12 Feb, 2013 1 commit
  31. 11 Feb, 2013 2 commits
  33. 08 Feb, 2013 1 commit
  35. 01 Feb, 2013 1 commit
  37. 30 Jan, 2013 1 commit
  39. 29 Jan, 2013 1 commit
  41. 26 Jan, 2013 2 commits
  43. 23 Jan, 2013 4 commits
  45. 18 Jan, 2013 4 commits
  47. 17 Jan, 2013 2 commits
  49. 16 Jan, 2013 1 commit