- 25 Aug, 2019 1 commit
-
-
Mike Frysinger authored
Pylint-1.7+ include a score report by default at the end of every module lint. We disable reports in general, so silence this too. Bug: 866772 Change-Id: Ie3df44c80b90daa59e46c8fd37a949176c9b09a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1770420Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 23 Aug, 2019 5 commits
-
-
Vadim Shtayura authored
Has different protobuf guts. The only observable side effect is different formatting of generated files. But 'lucicfg validate' now compares files semantically, so different formatting shouldn't matter. There's a bunch of other internal changes, but clients that rely on them are already aware and updated. R=iannucci@chromium.org BUG=986972 Change-Id: Ifd13c453736e438f28c2cf938003dce00f2cb199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769607Reviewed-by:
-
John Budorick authored
The parsing logic for OWNERS files included via "file:" lines currently rejects inline comments (e.g. "foo@example.com # for foo.cc"), while the normal OWNERS parsing logic correctly ignores such inline comments. This CL makes the inline case ignore inline comments too. Bug: 995474 Change-Id: I6f30554daf0a5f63b81719dced44f59187707eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769603Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
Don't overwrite passed kwargs. Make a copy instead. Otherwise, subsequent calls with the same kwargs will have stdin set to subprocess.PIPE. Bug: 984182 Change-Id: I358ffa1951e8b42486e0ac3a0d3d587a93c6dc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1769405 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Tamer Tas authored
devtools-frontend is missing from {gclient_config.repo_path_map}, causing the breakage: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8904354993541218352 This CL adds devtools-frontend to {gclient_config.repo_path_map} R=tandrii@chromium.org TBR=machenbach@chromium.org CC=yangguo@chromium.org Change-Id: I14cd8e9a9f05bdf16fa1b3c83f95de314418877e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1767977Reviewed-by:Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org>
-
Edward Lemur authored
Add run_on_python2 and run_on_python3 to allow to be tests on either only python2, only python3 or both. Bug: 984182 Change-Id: I87d3b67412129cf3a8e627cd6bc97daa81147657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1758849 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
smut <smut@google.com> Reviewed-by:
-
- 22 Aug, 2019 5 commits
-
-
Sam Clegg authored
On the wasm team we build several CMake-based projects with ninja (LLVM, binaryen, etc), and its useful for us (me at least) to be able to use autoninja with these project too. Change-Id: I7e213448dbbe95ffe3d249c9c6a3d4baa41f50d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1682742Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org>
-
Edward Lemur authored
Bug: 996359 Change-Id: I7c87fd824103c91c1dd5b9b8975354732e5eb0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765839 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Change-Id: I422c836258738ff11eb975361f56aa4ea7b4e2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764448Reviewed-by:
-
Edward Lemur authored
Changes like crrev.com/c/1752507, where a file that was previously in .gitignore becomes part of the repo, makes update_depot_tools fail to rebase. Use git checkout origin/master instead. Bug: 996359 Change-Id: Ib1a43b8842cebce96ab1fabaedc8e5653b9a708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764708 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Tamer Tas authored
devtools-frontend is missing from gclient configs, causing the breakage: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8904421330390983280 This CL creates the devtools-frontend configuration R=tandrii@chromium.org TBR=machenbach@chromium.org CC=yangguo@chromium.org Bug: chromium:995657 Change-Id: I8e5ffce16f2b8f69931a71cd67a709427d1f42ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765591Reviewed-by:
-
- 21 Aug, 2019 3 commits
-
-
Edward Lemur authored
A new-line token is being added on Python 3, so add it explicitly so that it also appears on Python 2. Bug: 984182 Change-Id: I3bfb6ca83d94b6a3452b938f35f5a3174fe85903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764465Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e15c164ce655619b0f7ca5cabb1da02134b43a92 [Path] Make all Path classes hashable. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic12fe56989f60a5b2d409ab33dff54e37b690a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1764462Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lemur authored
pylint.bat is overwritten by bootstrap/win/win_tools.py Bug: 866772 Change-Id: If59c9f5b9fe8bff212e25ec865bde4abfdf6e171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1762665Reviewed-by:
-
- 20 Aug, 2019 3 commits
-
-
Mike Frysinger authored
This allows people to pin a specific version of pylint when running it. The default behavior is unchanged: we run pylint-1.5.6 still as we've created a vpython wheel in cipd for it. But for projects that want to move to a newer version, they can pick any of the new 1.x wrappers. Having the full set of versions here allows projects to incrementally move to newer versions as the lint delta between 1.5 & 1.6 tends to be much smaller than 1.5 & 1.9. We don't include support for the newer 2.x series as those only support Python 3 which the codebase isn't ready for. Bug: 866772 Test: `./pylint ...` still works & shows pylint-1.5 Test: `./pylint-1.5 ...` runs the v1.5 version Test: `./pylint-1.8 ...` runs the v1.8 version Change-Id: I7c47187493564db81e3eb28c6dbd09e6309ead46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752507Reviewed-by:
-
Raul Tambre authored
Windows 10 has support for native ANSI control codes. This means we don't have to wrap stdout/stderr with Colorama, which uses old CMD APIs to handle these sequences. This change inadvertently also works around an issue on Python 3 where Colorama errors when bytes are output by gclient_utils.CheckCallAndFilter due to not wrapping sys.stdout.buffer. Bug: 942522 Change-Id: Ic7dde620b01bd94eb50de353bfc0276cad045a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1735566 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
-
Edward Lemur authored
Change-Id: Id24a1dc88ed9766b15a5145cdb29145d0c436514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1759277 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 19 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2822336a446f5f6fc68e50e1e5c5419548979030 [led] Create LedTestApi (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0afc6492e9a84eac1e63461d27dfd7d415712451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1760144Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/560ef89d75ade5e9f6cdb8bc75991239a4c1b0dd [swarming] Support unicode arguments in all functions (garymm@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I805743842c7109a437867ae94c96dde1ea44c914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1760538Reviewed-by:
-
- 16 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/74065d30431d49f380cba90ac7bb751df5aab235 [recipe_api] Update AggregatedStepFailure.contains_infra_failure when adding infra failure. (ihuh@google.com) R=recipe-roller@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0b40f8c3047407ece2621b0e3fdbf29c32d827ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757447 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 803846, 856278 Change-Id: I60d28dc5d1cc2d697f5faa559d704bc80eec3114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754634Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 15 Aug, 2019 8 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: Iaacb10dfc5ce7c624ac52edb76a9a74c6e2fd1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757122 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/54c9a286d41d9f711837dd4c002fc7fbc9bfde83 [buildbucket] Fix timeout in collect_builds (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9bd486fed5d6b5492a34cec20a1f04f55101de05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757116Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: I9fd81f758c16099b3cb021035a57c35fe363c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1755302Reviewed-by:
-
Edward Lemur authored
This will make it easier to get rid of super_mox.py Bug: 984182 Change-Id: Ic6c9646b8a96ef05ac59293a62f68ad7db7dc2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754977 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Ie29f06c817824c009656cf81d93a605abebe948a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754976Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Idc38678acbfca9cc6b89d77db28fdc24784f2b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753742 Commit-Queue: Edward Lemur <ehmaldonado@google.com> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5ad4574eb507b14945b29450e6aa378fac0ea120 [analyze] Improve module path detection logic. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I67993ee25f91a007dc64f4f13653ddaab20090ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756293Reviewed-by:
-
Daniel Bratell authored
Not everyone builds Chromium for arm so then it's practical to be able to use a smaller SDK package without arm support included. This also removes some samples that should not be needed. Recipe-Nontrivial-Roll: chromiumos Change-Id: I10f64d8907600fe79d3051083d100a7562d3a797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752202 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
- 14 Aug, 2019 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9739dd145b64ef8a9e33d0a4a5e25e8c516d83d4 Make set_worse_status not crash on None status (engeg@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5731702cbe41cde465da4411e99405d4abdc25a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754637Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dbc1acf1456ba2041808ab5ac96d2bbe5ebdbf49 Improve the exception for missing config. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6403bd33f203a49d29aa39504aaf7fd17e73288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754635Reviewed-by:
-
Mike Frysinger authored
We can have --no-squash update the --squash state directly so we don't have to constantly check two different knobs. This means opts.squash is now a tristate: None means load config settings while True/False means the user has specified a command line option. This also means we don't have to detect multiple --squash/--no-squash flags as the argparse module will take care of coalescing. Bug: 993518 Test: `git cl upload` uses my ~/.gitconfig Test: `git cl upload --squash` squashes Test: `git cl upload --no-squash` doesn't squash Change-Id: Ib2577db11d3af03c93cb47d8b78b341213720a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754234Reviewed-by:
-
George Engelbrecht authored
In support of the signing rework we're going to want to have the signers keep track of the calculated hash to ensure that we don't have a TOCTOU type issue. This commit adds the stat command to the gsutil module so that we can ask gs a files hash. Change-Id: Ib35d1541292a18fbfc26fab50f594c682ba4109d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754262Reviewed-by:
-
Nodir Turakulov authored
R=iannucci@chromium.org Bug: iannucci@chromium.org Change-Id: I54feea6646d7f983795cc67e79008587ce3a74f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754235 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
John Budorick authored
Mirroring crrev.com/c/1717663. bot_update runs that take more than an hour are typically hung in irrecoverable ways. Recipe-Nontrivial-Roll: build Change-Id: Ic0afc48db7e0ac3464888e7715621a04f55443ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754263Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org>
-
John Budorick authored
Useful in cases like the green presubmit runs on crrev.com/i/1434617/2 Bug: 925774 Change-Id: I37ce2be843d76ace0615cd3313e5c8421504a1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1687122Reviewed-by:
-
- 13 Aug, 2019 4 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: I6165cf889ebd4e074f1f72b29e8d1216337fb04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752480 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Ib9c5d2762546f29eaca5eae89b0428431067da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753029 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/83800d1aff85a6bfa6b5202485c8a26b44701ff5 Regenerate README from 3fd5281 (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I924af5959cae02f189dcc34b99b166a18739eda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752690Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e7fec5ccb9e70bf17b7878e63052a874afa06856 Change is_luci default to True. (mmoss@google.com) R=recipe-roller@chromium.org, tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9eb8913a8f65b8f107e5856c46aceda10e14c00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752476 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
