Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 08 Jun, 2022 6 commits
  3. 07 Jun, 2022 6 commits
  5. 04 Jun, 2022 1 commit
    • Bruce Dawson's avatar
      Print full path and upgrade details in PyLint warning · 89b222db
      Bruce Dawson authored 
      A run of "git cl presubmit --all" shows that PyLint 1.5 is being run
from nine locations, however the deprecation warnings don't say where.
This makes it difficult to file bugs or fix the remaining instances.
This changes the message to list the path to the presubmit that is
running PyLint 1.5.

This also adds instructions on how to change to version 2.7.

Before:

  pylint-1.5 is deprecated, please switch to 2.7 before 2022-07-11

After (with word wrapping):

  pylint-1.5 is being run on ...src\tools\find_runtime_symbols
  and is deprecated, please switch to 2.7 before 2022-07-11 (add
  version='2.7' to RunPylint call)

Change-Id: Iece2cb904f5d26ad66e3ab78f7ce7aef1878bfd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3688839Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      89b222db
  7. 03 Jun, 2022 5 commits
  9. 02 Jun, 2022 5 commits
  11. 01 Jun, 2022 7 commits
  13. 31 May, 2022 4 commits
  15. 27 May, 2022 6 commits
    • Bruce Dawson's avatar
      Don't halt presubmits on exceptions · 10a82868
      Bruce Dawson authored 
      Some presubmit failures result in uncaught exceptions which historically
have halted presubmit runs. This behavior makes it more difficult to
find all failures, measure presubmit times, or detect other behavior
over time. This is particularly problematic when running "git cl
presubmit --all".

As an example, presubmit --all was broken and would not complete from
when crrev.com/3642633 landed until crrev.com/c/3657600. The minimal
repro was this presubmit command:

    git cl presubmit --files ui\accessibility\ax_mode.h

This command, or presubmit --all, triggered this error, which halts the
presubmits:

Evaluation of CheckChangeOnCommit failed: [Errno 2] No such file or directory: 'chrome/browser/resources/accessibility/accessibility.js'
Traceback (most recent call last):
  File "presubmit_support.py", line 2038, in <module>
    sys.exit(main())
  File "presubmit_support.py", line 2015, in main
    return DoPresubmitChecks(
  File "presubmit_support.py", line 1738, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "presubmit_support.py", line 1602, in ExecPresubmitScript
    self._run_check_function(function_name, context, sink,
  File "presubmit_support.py", line 1640, in _run_check_function
    six.reraise(e_type, e_value, e_tb)
  File "C:\Users\brucedawson\.vpython-root\e726d2\lib\site-packages\six.py", line 686, in reraise
    raise value
  File "presubmit_support.py", line 1630, in _run_check_function
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "PRESUBMIT.py", line 314, in CheckChangeOnCommit
    errs.extend(CheckModesMatch(input_api, output_api))
  File "PRESUBMIT.py", line 283, in CheckModesMatch
    ax_modes_in_js = GetAccessibilityModesFromFile(
  File "PRESUBMIT.py", line 245, in GetAccessibilityModesFromFile
    for line in open(fullpath).readlines():
FileNotFoundError: [Errno 2] No such file or directory: 'chrome/browser/resources/accessibility/accessibility.js'

With this change the exception is handled and presubmits continue after
printing this message:

Evaluation of CheckChangeOnCommit failed: [Errno 2] No such file or directory: 'chrome/browser/resources/accessibility/accessibility.js', Traceback (most recent call last):
  File "presubmit_support.py", line 1630, in _run_check_function
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "PRESUBMIT.py", line 314, in CheckChangeOnCommit
    errs.extend(CheckModesMatch(input_api, output_api))
  File "PRESUBMIT.py", line 283, in CheckModesMatch
    ax_modes_in_js = GetAccessibilityModesFromFile(
  File "PRESUBMIT.py", line 245, in GetAccessibilityModesFromFile
    for line in open(fullpath).readlines():
FileNotFoundError: [Errno 2] No such file or directory: 'chrome/browser/resources/accessibility/accessibility.js'

That is, the crucial information regarding the failure is printed, but
subsequent presubmits are not skipped.

Bug: 1309977
Change-Id: I7cfeda85c830e6c8e567c0df3c50f27af1dbe835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3653978Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      10a82868
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · f69f264f
      recipe-roller authored 
      This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8812990573718281121

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e52acbc0987bdb31369aba51894b98286a418582
  e52acbc (andrewlamb@chromium.org)
      [recipes-py] roll recipe proto.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a16c436667dfcb2a44c760e2d59ad30cf8d8a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3673905
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
      f69f264f
    • Ryan Heise's avatar
      Add Android Go support to Pinpoint CLI · b6083fac
      Ryan Heise authored 
      Bug:1328653
Change-Id: I812eae65b6ea4f5bcd01d315405e90e0b3f1e732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3673717
Auto-Submit: Ryan Heise <heiserya@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      b6083fac
    • Josip Sokcevic's avatar
      Use python3 for cpplint and get_toolchain on Win · 6a8680a8
      Josip Sokcevic authored 
      R=gavinmak@google.com

Change-Id: I7d9ca9530640ffa4b8e60c247f809b0ff477d88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3673716
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
      6a8680a8
    • Bruce Dawson's avatar
      Tag cpplint errors · ac96470e
      Bruce Dawson authored 
      A typical cpplint error report during a presubmit looks like this:

    .../linux_ui.cc:64:  Almost always, snprintf is better than strcpy  [runtime/printf] [4]
    ...
    Changelist failed cpplint.py check.

The problem is that the details of the error go to stderr when
CheckChangeLintsClean is run, whereas the "Changelist failed cpplint.py
check." message is printed at the end of the run. If there a lot of
errors, warnings, or messages then the association between them can be
completely lost.

This change adds the tag (cpplint) to the error messages, and adds a
comment to the "failed cpplint.py check" message to suggest looking for
the tag.

Bug: 1309977
Change-Id: I0d073b57f215e28495cbc3e009cab6ac2f23b65e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3632947
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: 's avatarAravind Vasudevan <aravindvasudev@google.com>
      ac96470e
    • Takuto Ikuta's avatar
      use python3 for download_from_google_storage.bat · 68df7954
      Takuto Ikuta authored 
      This is to fix
https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20x64%20Builder%20(py2%20less)/1151/overview

Bug: 1327534
Change-Id: I3dcead03d0f4e213e1c4e610d8b90fe95ea843d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3670999
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
      68df7954