Commits · eafd7ae790b4725cd394d12f232e1317197cfafb · Linshizhi / Chromium_Depot_tools

08 Sep, 2011 12 commits

Change git_cl.py to use subprocess2 · eafd7ae7

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7848003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100190 0039d316-1c4b-4281-b951-d872f2087c98

eafd7ae7

Remove gclient_utils.CheckCall() from gclient_scm.py · bffad37d

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7847004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100185 0039d316-1c4b-4281-b951-d872f2087c98

bffad37d

Remove gclient_utils.CheckCall() usage from scm.py · da64d639

maruel@chromium.org authored Sep 08, 2011

Remove reference to shutil while at it.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7851001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100182 0039d316-1c4b-4281-b951-d872f2087c98

da64d639

Make gclient_utils.CheckCallError inherit from subprocess2.CalledProcessError. · ca0f8398

maruel@chromium.org authored Sep 08, 2011

This will simply the transition

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7839038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100174 0039d316-1c4b-4281-b951-d872f2087c98

ca0f8398

Remove gclient_utils.Popen() usage from gclient.py · 1ba646fc

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7795061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100173 0039d316-1c4b-4281-b951-d872f2087c98

1ba646fc

Reorder gcl.py imports and remove gclient_utils.Popen() usage · e13e12a8

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7840038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100172 0039d316-1c4b-4281-b951-d872f2087c98

e13e12a8

Remove usage of gclient_utils.CheckCall() from trychange.py · 13c271b7

maruel@chromium.org authored Sep 08, 2011

I'd like to eventually remove this function.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7795060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100169 0039d316-1c4b-4281-b951-d872f2087c98

13c271b7

Revert r100162 "Change default --jobs value from 1 to 4."" · ad9c97b6

maruel@chromium.org authored Sep 08, 2011

One day it'll work. It still breaks webkit.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7850021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100168 0039d316-1c4b-4281-b951-d872f2087c98

ad9c97b6

Reapply r99735 "Change default --jobs value from 1 to 4." · 442ab8fc

maruel@chromium.org authored Sep 08, 2011

It should be fine now that requirements with /@ works fine.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7782034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100162 0039d316-1c4b-4281-b951-d872f2087c98

442ab8fc

Add lint check against "Foo *bar" and "Foo &bar" declarations. · 8b8d8bef

asvitkine@chromium.org authored Sep 08, 2011

Depends on extension mechanism for cpplint.py: http://codereview.appspot.com/4950069/

Pulls r74 of cpplint.py from:
http://google-styleguide.googlecode.com/svn-history/r74/trunk/cpplint/cpplint.py

Taken from WebKit's fork of cpplint.py.

WebKit patch was: http://trac.webkit.org/changeset/46856

Credit Torch Mobile, Inc. who have contributed the WebKit patch in question.

BUG=none
TEST=Run gcl lint on a CL that has a Foo *bar style declaration.

Review URL: http://codereview.chromium.org/7834045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100151 0039d316-1c4b-4281-b951-d872f2087c98

8b8d8bef

Add automatic is_new=True on git copy or rename. · 8baaea7b

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7847005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100140 0039d316-1c4b-4281-b951-d872f2087c98

8baaea7b

Add support forcopied and renamed files. · a19047cd

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/6874006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100138 0039d316-1c4b-4281-b951-d872f2087c98

a19047cd

07 Sep, 2011 4 commits

Add PRESUBMIT.py exclusion for cpplint_chromium.py. · 63c2c1d2

asvitkine@chromium.org authored Sep 07, 2011

Needed for: http://codereview.chromium.org/7834045/

BUG=none
TEST=Check that cpplint_chromium.py does not trigger presubmit warnings.

Review URL: http://codereview.chromium.org/7789033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100025 0039d316-1c4b-4281-b951-d872f2087c98

63c2c1d2

Urls with /@ won't be processed correctly when used as a requirements. · 98023dfb

maruel@chromium.org authored Sep 07, 2011

This is important for parallel checkout.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7840033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99981 0039d316-1c4b-4281-b951-d872f2087c98

98023dfb

Centralize testing to make it simpler to test when rename are supported correctly · ed6ce003

maruel@chromium.org authored Sep 07, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7789030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99980 0039d316-1c4b-4281-b951-d872f2087c98

ed6ce003

Make rietveld status handling saner · 6cdac9ef

maruel@chromium.org authored Sep 07, 2011

Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.

More testing.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7840003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98

6cdac9ef

06 Sep, 2011 3 commits

Improve rietveld tests. · 2f4a0fa9

maruel@chromium.org authored Sep 06, 2011

I plan to do some refactoring and these tests will help reduce the likehood of
regression.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7739039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99799 0039d316-1c4b-4281-b951-d872f2087c98

2f4a0fa9

Revert r99735 "Change default --jobs value from 1 to 4." · 3187f705

maruel@chromium.org authored Sep 06, 2011

It breaks upstream webkit and nacl. I'll make then both use --jobs 1 before
relanding.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7833051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99761 0039d316-1c4b-4281-b951-d872f2087c98

3187f705

Change default --jobs value from 1 to 4. · ee118f98

maruel@chromium.org authored Sep 06, 2011

It is now safe to use.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7779023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99735 0039d316-1c4b-4281-b951-d872f2087c98

ee118f98

03 Sep, 2011 1 commit

Update repo.git URL from broken kernel.org to Chromium hosted. · 0d16357c

tonyg@google.com authored Sep 03, 2011

Review URL: http://codereview.chromium.org/7779014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99564 0039d316-1c4b-4281-b951-d872f2087c98

0d16357c

02 Sep, 2011 2 commits

Improve is_delete detection. · be60565b

maruel@chromium.org authored Sep 02, 2011

Make tests more exhaustive in prospect to file move handling.
Rename 'c' variables to 'p' to easy copy paste.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7828017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99439 0039d316-1c4b-4281-b951-d872f2087c98

be60565b

Do not run integration tests on upload, they are too slow. · d52417c9

maruel@chromium.org authored Sep 02, 2011

gclient_scm_test.py throws randomly gclient_utils.Error.
Simply update the test expectation. It has no effect on runtime.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7828024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99436 0039d316-1c4b-4281-b951-d872f2087c98

d52417c9

01 Sep, 2011 3 commits

Fix parallelization of multiple solutions once for all. · 118fb1cd

maruel@chromium.org authored Sep 01, 2011

Verify correctness with a unit test written explicitly to verify all corner cases.

BUG=60725
TEST=new unit test

Review URL: http://codereview.chromium.org/6598087

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99234 0039d316-1c4b-4281-b951-d872f2087c98

118fb1cd

Make filename processing a static method. · be113f13

maruel@chromium.org authored Sep 01, 2011

This is in preparation to support file rename, as a source_filename needs to be
added and processed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7809001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99185 0039d316-1c4b-4281-b951-d872f2087c98

be113f13

Implement reverse mangling of svn properties. · 03152415

maruel@chromium.org authored Sep 01, 2011

That means some properties will being to be applied.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98

03152415

30 Aug, 2011 1 commit

Add regression test for the parallel jobs dependency issue. · f40e2a56

maruel@chromium.org authored Aug 30, 2011

Well, the funny thing is that it doesn't find the bug but the framework is
already good enough as-is to be worth checked-in, so the next commit can show
the relevant difference.

R=dpranke@chromium.org
BUG=60725
TEST=

Review URL: http://codereview.chromium.org/7773001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98869 0039d316-1c4b-4281-b951-d872f2087c98

f40e2a56

26 Aug, 2011 4 commits

Move the parser creation code in its own function to enable unit testing. · 0895b752

maruel@chromium.org authored Aug 26, 2011

Unit test follow in next CL.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7766005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98480 0039d316-1c4b-4281-b951-d872f2087c98

0895b752

Improve search algorithm for GAE SDK in depot_tools integration tests. · 943b1273

maruel@chromium.org authored Aug 26, 2011

Still not enough to fix presubmit checks on commit queue but a step in the
right direction.
Review URL: http://codereview.chromium.org/7748020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98445 0039d316-1c4b-4281-b951-d872f2087c98

943b1273

Make GAE instance bind all interfaces when a variable is set. · 6b5eae2d

maruel@chromium.org authored Aug 26, 2011

It's mostly for debugging when testing with a leaking service. It's going to be
rarely used but I used it often enough to warrant it being committed.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7744030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98438 0039d316-1c4b-4281-b951-d872f2087c98

6b5eae2d

Ignore C++ comments while checking for Singleton<T> in headers. · d22b970a

dilmah@chromium.org authored Aug 26, 2011

(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Review URL: http://codereview.chromium.org/7747023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98421 0039d316-1c4b-4281-b951-d872f2087c98

d22b970a

23 Aug, 2011 2 commits

Update upload.py from rietveld @ 7696eca367d2. · 4f6d25c4

maruel@chromium.org authored Aug 23, 2011

---

Trap failure to get password from keyring

It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7715013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98

4f6d25c4

Update upload.py from ed59464f8468. · b615edae

maruel@chromium.org authored Aug 23, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7709021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97854 0039d316-1c4b-4281-b951-d872f2087c98

b615edae

10 Aug, 2011 1 commit

chrome_set_ver: Add symlink to chromite_wrapper for new tool · e07b3ce3

zbehan@chromium.org authored Aug 10, 2011

BUG=none
TEST=run it
Review URL: http://codereview.chromium.org/7605017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@96223 0039d316-1c4b-4281-b951-d872f2087c98

e07b3ce3

26 Jul, 2011 2 commits

Update chromite wrapper · 38e22e95

zbehan@chromium.org authored Jul 26, 2011

* Add a new version of the chromite wrapper as chromite_wrapper
* Create symlinks (chromite, cros_sdk, cbuildbot) pointing to it

TEST=inside repo checkout, run cros_sdk, chromite, cbuildbot
Review URL: http://codereview.chromium.org/7484062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94011 0039d316-1c4b-4281-b951-d872f2087c98

38e22e95

Do not interfere with git cl patch <issue> · d587f393

maruel@chromium.org authored Jul 26, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7493050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@94004 0039d316-1c4b-4281-b951-d872f2087c98

d587f393

22 Jul, 2011 4 commits

GTTF: make gclient config overwrite the .gclient file if it exists · 26dd22b8

phajdan.jr@chromium.org authored Jul 22, 2011

This prevents bots waiting 20 minutes and failing the update step.
Review URL: http://codereview.chromium.org/7492019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93678 0039d316-1c4b-4281-b951-d872f2087c98

26dd22b8

Fix git-cl --contributor flag support for presubmit checks. · 13f623ca

maruel@chromium.org authored Jul 22, 2011

Chromium's presubmit check assumes the author is an email address.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7484002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93645 0039d316-1c4b-4281-b951-d872f2087c98

13f623ca

Add merge attribute to OptionsObject in gclient_scm_test.py. · 4dd09375

bauerb@chromium.org authored Jul 22, 2011

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7488015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93628 0039d316-1c4b-4281-b951-d872f2087c98

4dd09375

Add --merge option to gclient sync. · 2aad1b26

bauerb@chromium.org authored Jul 22, 2011

BUG=none
TEST=

Review URL: http://codereview.chromium.org/7277035

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93611 0039d316-1c4b-4281-b951-d872f2087c98

2aad1b26

21 Jul, 2011 1 commit

Fix support for pylint 0.24. · 891f6454

maruel@chromium.org authored Jul 21, 2011

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@93451 0039d316-1c4b-4281-b951-d872f2087c98

891f6454