Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 28 Jan, 2021 1 commit
  3. 27 Jan, 2021 5 commits
  5. 26 Jan, 2021 6 commits
  7. 25 Jan, 2021 5 commits
  9. 22 Jan, 2021 3 commits
  11. 21 Jan, 2021 4 commits
  13. 20 Jan, 2021 4 commits
  15. 19 Jan, 2021 5 commits
  17. 15 Jan, 2021 4 commits
  19. 14 Jan, 2021 3 commits
    • Josip Sokcevic's avatar
      Use real default branch in gclient · 091f5ac0
      Josip Sokcevic authored 
      Currently, gclient sync assumes the default branch is master, and
it doesn't work at all if such branch doesn't exist. This change queries
local git copy to get remote HEAD. If local git version is not
available, it queries remote git server using ls-remote.

This change requires git version 2.28 (depot_tools comes with 2.29).

R=ehmaldonado@chromium.org

Bug: 1156318
Change-Id: Id348e0f1004093f395139e8f4d62adb66b94ca9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628359
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
      091f5ac0
    • Bruce Dawson's avatar
      Avoid capture_output to support Python 3.6 · 2241db8a
      Bruce Dawson authored 
      autoninja.py uses subprocess.run which requires Python 3 and used
capture_output which requires Python 3.6. One user reported this as an
issue and it turns out that it is easy to avoid by using subprocess.NULL
which then means that Python versions back to 3.3 are supported.

Bug: 868590, b/174673874
Change-Id: Ife5e186d9c54747d35ff989dc2afadba5b9a57f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2630525
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: 's avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      2241db8a
    • Bruce Dawson's avatar
      Check whether goma is running when it is enabled · b7ddc5a0
      Bruce Dawson authored 
      One of the mistakes one can make when running ninja is having goma
enabled (use_goma=true in args.gn) but not having goma running. This can
lead to ~1,000 failed compile steps, which is messy.

This change teaches autoninja.py to check whether goma is running. If
not then it tells autoninja to just print a warning message. The
check costs roughly 30 ms which seems reasonable.

In fact, because this change also switches away from vpython (necessary
to use python3 to use subprocess.run) it actually runs about 600 ms
_faster_ than before this change.

If build acceleration is requested through use_rbe then no checking for
whether the service is running is done. That could be added in the
future.

autoninja.py could auto-start goma but that is error prone and has
limited additional value.

This was tested on Linux, OSX, and Windows.

Bug: 868590, b/174673874
Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: 's avatarYoshisato Yanagisawa <yyanagisawa@google.com>
      b7ddc5a0